Wire up DisableSearchHistory and DisableSearchHighlights - #30
Merged
Conversation
Both were declared CLI parameters with apply and undo reg files on disk, but no Features.json entry, so passing either did nothing. The apply phase resolves work from Features.json, and neither switch was there, so it was dropped without a word. Registry-backed features are dispatched generically from their metadata, the same path DisableBing uses minus the app-removal side effect, so the two catalogue entries are the entire fix. No handler code needed. Categorized under Start Menu & Search to match DisableBing. Regenerated the en-US language catalogue so it stays in exact parity with Features.json, which the localization drift test enforces. This clears the two dead parameters found while composing the preset library. The six that remain without a Features.json entry are dispatched by their own blocks in WinSwift.ps1 and are working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two dead parameters found while composing the preset library in #29.
The defect
Both
-DisableSearchHistoryand-DisableSearchHighlightswere declared as CLI parameters inWinSwift.ps1andScripts/Get.ps1, and both had apply and undo reg files on disk:But neither had a
Features.jsonentry. The apply phase resolves work fromFeatures.json(a param whose key doesn't match a feature is dropped), so passing either switch did nothing, silently. They were the only two of 145 parameters in that state.The fix
Registry-backed features are dispatched generically from their metadata — the same path
DisableBingtakes, minus its app-removal side effect — so the two catalogue entries are the entire fix. No handler code required.DisableBing.en-USlanguage catalogue so it stays in exact parity withFeatures.json(the localization drift test enforces this).Six parameters still lack a
Features.jsonentry (EnablePerformanceTweaks,DisableWindowsAds,EnableCompetitiveGaming,DisableMemoryIntegrity,DisableSettingsAds,DisableWidgetsDeep) — those are dispatched by their own blocks inWinSwift.ps1and work correctly. Verified the orphan count is now exactly those six.Verification
Confirmed both features now resolve into
applyIdswhere they were previously dropped, both reg files (apply + undo) exist, and both remain declared as CLI params. Static validation passes (114 files); standalone rebuilt and parse-checked.Not verified end to end: applying needs elevation, so the registry write itself is covered by the generic registry path that every other feature already exercises, not observed here.
🤖 Generated with Claude Code