ref #235 (review)
Referral bonus just adds on a raw value to the application score right now, which is (probably) fine since it's really high so the individual score components (essay vs referral) are still extractable.
However there is a potential very rare race condition mentioned in the above PR where if an app and referral come in at the same time that could cause the bonus to be added twice
- do we really care? maybe? adding the bonus twice is probably fine since we don't necessarily have to rank applications by raw scores, we can just account for the referral as needed in any ranking/acceptance scripts
Current method is still a little dirty though so eventually it'll probably be better to just use a separate field
Made a branch with some of the code changes already:
referral-separate-score-field
This still needs:
- handling if a referral is submitted before an application is even created
- updating existing entries to have a referral bonus field, including applications with currently existing referrals
- probably code review
ref #235 (review)
Referral bonus just adds on a raw value to the application score right now, which is (probably) fine since it's really high so the individual score components (essay vs referral) are still extractable.
However there is a potential very rare race condition mentioned in the above PR where if an app and referral come in at the same time that could cause the bonus to be added twice
Current method is still a little dirty though so eventually it'll probably be better to just use a separate field
Made a branch with some of the code changes already:
referral-separate-score-fieldThis still needs: