Repository navigation
Fix accidental definition tuple_svec(::Type{Union{}}) - #40
Conversation
JET complains about it and it is correct: `Bottom` is `<:Tuple` and it does not have a field `parameters`.
|
Anything missing, so that this PR can be merged? |
|
I'm not entirely sure if this is a true issue, JET's false positive or Julia language deficiency that might be patched. |
I'd say it is a shortcoming of the Julia language. I agree that most of the time this is not wanted, although I also recently learned that
It is endorsed by core Julia developers, see, e.g., Julia#63338, Julia#63935 and Julia#63972 with the involvement of Shuhei, Jameson and Kristoffer. Unfortunately, with the semantics we currently have, Julia needs to allow I hope that we'll have a more elegant mechanism in the future. The most elegant idea I currently know about is described in this comment. Until then, we should fix these problems if they are public API or already known to be problematic (e.g. suboptimum code has been detected or shows up via JET). In the case of this PR it's the latter. That's why I ask for integrating the PR. We can remove the tests if you want to keep complexity low. I think a single line should add inconsiderable complexity. When Julia provides a better mechanism, we can version-gate it and remove even that when LTS supports the better mechanism. Btw.: Great package! |
|
Thanks for the explanation, that makes sense. I will merge this as is then, could you just bump the patch version so that it can be released immediately? |
|
Thanks, @mateuszbaran. I bumped the patch version. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 96.87% 98.43% +1.56%
==========================================
Files 1 1
Lines 64 64
==========================================
+ Hits 62 63 +1
+ Misses 2 1 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JET complains about it and it is correct:
Bottomis<:Tupleand it does not have a fieldparameters.