[ss-159] Accept empty exclude columns for consistency with text columns#36922
Merged
peterdukelarsen merged 3 commits intoJun 8, 2026
Merged
Conversation
peterdukelarsen
requested review from
martykulma
and removed request for
a team and
martykulma
peterdukelarsen
commented
Jun 8, 2026
| # `CREATE SOURCE .. FOR TABLES` (subsource-creating) syntax is treated as | ||
| # though the option were omitted and must succeed. This differs from the | ||
| # `CREATE TABLE .. FROM SOURCE` syntax, where an empty set is rejected with | ||
| # `invalid TEXT COLUMNS option value: cannot be empty`. |
Contributor
Author
There was a problem hiding this comment.
I caught some stale comments that slipped through on the old PR from when I was planning to make this an error. Generally not a fan of mixing changes, but it seemed related and trivial enough.
martykulma
approved these changes
Jun 8, 2026
martykulma
left a comment
martykulma
left a comment
Contributor
There was a problem hiding this comment.
sweet - thanks @peterdukelarsen !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While working on #36890 I noticed that EXCLUDE COLUMNS has the same behavior as TEXT COLUMNS. For consistency's sake I've implemented the same fix.
Description
Removes panic/error log for empty exclude columns because we supported and want to support empty exclude columns.
Verification
Testdrive tests asserting legacy behavior aligns with expectations and new behavior matches it.