From c0a8511c3b1d5d1cee1e26f6b4f7e9c25b5d8560 Mon Sep 17 00:00:00 2001 From: akarnokd Date: Thu, 25 Jun 2026 21:16:53 +0200 Subject: [PATCH 1/2] 4.x: Cleanup + lambda instead of inner class check --- ...edulerTest.java => SchedulerMainTest.java} | 2 +- .../disposables/CompositeDisposableTest.java | 34 ++--- .../disposables/SequentialDisposableTest.java | 42 +++--- .../disposables/SerialDisposableTests.java | 42 +++--- .../flowable/BlockingFlowableNextTest.java | 24 ++-- .../flowable/FlowableRefCountTest.java | 2 +- .../FlowableReplayEagerTruncateTest.java | 16 +-- .../flowable/FlowableReplayTest.java | 32 ++--- .../operators/flowable/FlowableRetryTest.java | 37 +++-- .../FlowableRetryWithPredicateTest.java | 6 +- .../operators/flowable/FlowableScanTest.java | 10 +- .../flowable/FlowableSequenceEqualTest.java | 12 +- .../flowable/FlowableSingleTest.java | 8 +- .../flowable/FlowableSkipWhileTest.java | 2 +- .../flowable/FlowableSubscribeOnTest.java | 6 +- .../flowable/FlowableSwitchIfEmptyTest.java | 6 +- .../flowable/FlowableSwitchTest.java | 14 +- .../flowable/FlowableTakeLastTest.java | 18 +-- .../operators/flowable/FlowableTakeTest.java | 6 +- .../operators/flowable/FlowableTakeTest2.java | 2 +- .../FlowableTakeUntilPredicateTest.java | 2 +- .../flowable/FlowableTakeWhileTest.java | 6 +- .../flowable/FlowableThrottleFirstTest.java | 2 +- .../flowable/FlowableThrottleLatestTest.java | 2 +- .../flowable/FlowableTimeoutTests.java | 4 +- .../FlowableTimeoutWithSelectorTest.java | 18 +-- .../operators/flowable/FlowableTimerTest.java | 4 +- .../flowable/FlowableToFutureTest.java | 2 +- .../operators/flowable/FlowableToMapTest.java | 4 +- .../flowable/FlowableToMultimapTest.java | 4 +- .../flowable/FlowableUnsubscribeOnTest.java | 2 +- .../operators/flowable/FlowableUsingTest.java | 8 +- .../FlowableWindowWithFlowableTest.java | 36 ++--- .../flowable/FlowableWindowWithSizeTest.java | 4 +- ...lowableWindowWithStartEndFlowableTest.java | 6 +- .../flowable/FlowableWindowWithTimeTest.java | 24 ++-- .../flowable/FlowableWithLatestFromTest.java | 4 +- .../flowable/FlowableZipIterableTest.java | 6 +- .../operators/flowable/FlowableZipTest.java | 12 +- .../operators/maybe/MaybeAmbTest.java | 2 +- .../operators/maybe/MaybeCacheTest.java | 2 +- .../operators/maybe/MaybeConcatArrayTest.java | 2 +- .../operators/maybe/MaybeCreateTest.java | 12 +- .../operators/maybe/MaybeDelayOtherTest.java | 2 +- .../maybe/MaybeDelaySubscriptionTest.java | 2 +- .../operators/maybe/MaybeDetachTest.java | 8 +- .../maybe/MaybeDoAfterSuccessTest.java | 2 +- .../operators/maybe/MaybeDoOnEventTest.java | 2 +- .../maybe/MaybeDoOnLifecycleTest.java | 2 +- .../MaybeFlatMapIterableFlowableTest.java | 6 +- .../MaybeFlatMapIterableObservableTest.java | 3 +- .../operators/maybe/MaybeMergeArrayTest.java | 8 +- .../operators/maybe/MaybePeekTest.java | 4 +- .../maybe/MaybeSafeSubscribeTest.java | 8 +- .../maybe/MaybeTimeoutPublisherTest.java | 2 +- .../operators/maybe/MaybeTimeoutTest.java | 2 +- .../maybe/MaybeUnsubscribeOnTest.java | 2 +- .../operators/maybe/MaybeZipArrayTest.java | 4 +- .../FlowableConcatMapCompletableTest.java | 2 +- .../mixed/FlowableConcatMapMaybeTest.java | 4 +- .../mixed/FlowableConcatMapSingleTest.java | 4 +- .../FlowableSwitchMapCompletableTest.java | 2 +- .../mixed/FlowableSwitchMapMaybeTest.java | 8 +- .../mixed/FlowableSwitchMapSingleTest.java | 8 +- .../mixed/ObservableConcatMapMaybeTest.java | 4 +- .../mixed/ObservableConcatMapSingleTest.java | 4 +- .../ObservableSwitchMapCompletableTest.java | 2 +- .../mixed/ObservableSwitchMapMaybeTest.java | 8 +- .../mixed/ObservableSwitchMapSingleTest.java | 8 +- .../BlockingObservableNextTest.java | 34 ++--- .../observable/ObservableAllTest.java | 4 +- .../observable/ObservableAnyTest.java | 4 +- .../observable/ObservableBlockingTest.java | 6 +- .../observable/ObservableBufferTest.java | 34 ++--- .../observable/ObservableCollectTest.java | 4 +- .../ObservableCombineLatestTest.java | 6 +- .../ObservableConcatMapCompletableTest.java | 6 +- .../ObservableConcatMapEagerTest.java | 2 +- .../ObservableConcatMapSchedulerTest.java | 13 +- .../observable/ObservableConcatMapTest.java | 14 +- .../observable/ObservableConcatTest.java | 12 +- .../ObservableConcatWithCompletableTest.java | 4 +- .../ObservableConcatWithMaybeTest.java | 6 +- .../ObservableConcatWithSingleTest.java | 6 +- .../observable/ObservableCreateTest.java | 4 +- .../observable/ObservableDebounceTest.java | 8 +- .../observable/ObservableDelayTest.java | 12 +- .../ObservableDematerializeTest.java | 4 +- .../observable/ObservableDistinctTest.java | 4 +- .../observable/ObservableDoAfterNextTest.java | 2 +- .../observable/ObservableDoFinallyTest.java | 4 +- .../observable/ObservableDoOnEachTest.java | 31 ----- .../ObservableDoOnSubscribeTest.java | 2 +- .../observable/ObservableElementAtTest.java | 6 +- .../ObservableFlatMapCompletableTest.java | 6 +- .../ObservableFlatMapMaybeTest.java | 10 +- .../ObservableFlatMapSingleTest.java | 8 +- .../observable/ObservableFlatMapTest.java | 15 +- .../ObservableFlattenIterableTest.java | 2 +- .../ObservableFromIterableTest.java | 14 +- .../observable/ObservableGroupByTest.java | 20 +-- .../observable/ObservableGroupJoinTest.java | 2 +- .../observable/ObservableJoinTest.java | 4 +- .../ObservableMapNotificationTest.java | 2 +- .../observable/ObservableMapTest.java | 74 ---------- .../ObservableMergeDelayErrorTest.java | 3 +- .../observable/ObservableMergeTest.java | 18 +-- .../ObservableMergeWithCompletableTest.java | 2 +- .../ObservableMergeWithMaybeTest.java | 12 +- .../ObservableMergeWithSingleTest.java | 13 +- .../observable/ObservableObserveOnTest.java | 16 ++- .../ObservableOnErrorResumeNextTest.java | 2 +- .../ObservableOnErrorResumeWithTest.java | 2 +- .../ObservableOnErrorReturnTest.java | 2 +- .../observable/ObservablePublishTest.java | 11 +- .../observable/ObservableRangeLongTest.java | 2 +- .../observable/ObservableRangeTest.java | 2 +- .../observable/ObservableRedoTest.java | 3 +- .../observable/ObservableReduceTest.java | 4 +- .../observable/ObservableRefCountTest.java | 2 +- .../ObservableReplayEagerTruncateTest.java | 14 +- .../observable/ObservableReplayTest.java | 14 +- .../observable/ObservableRetryTest.java | 31 ++--- .../ObservableRetryWithPredicateTest.java | 6 +- .../observable/ObservableScanTest.java | 2 +- .../observable/ObservableSkipWhileTest.java | 2 +- .../ObservableSwitchIfEmptyTest.java | 2 +- .../observable/ObservableSwitchTest.java | 24 ++-- .../observable/ObservableTakeLastTest.java | 5 +- .../observable/ObservableTakeTest.java | 2 +- .../ObservableTakeUntilPredicateTest.java | 2 +- .../observable/ObservableTakeWhileTest.java | 6 +- .../ObservableThrottleLatestTest.java | 2 +- .../observable/ObservableTimeoutTests.java | 4 +- .../ObservableTimeoutWithSelectorTest.java | 16 +-- .../observable/ObservableTimerTest.java | 4 +- .../observable/ObservableToFutureTest.java | 2 +- .../observable/ObservableToMapTest.java | 4 +- .../observable/ObservableToMultimapTest.java | 4 +- .../ObservableUnsubscribeOnTest.java | 2 +- .../observable/ObservableUsingTest.java | 8 +- .../ObservableWindowWithObservableTest.java | 36 ++--- ...vableWindowWithStartEndObservableTest.java | 7 +- .../ObservableWindowWithTimeTest.java | 22 +-- .../ObservableWithLatestFromTest.java | 2 +- .../observable/ObservableZipIterableTest.java | 6 +- .../observable/ObservableZipTest.java | 8 +- .../operators/single/SingleCacheTest.java | 2 +- .../operators/single/SingleCreateTest.java | 8 +- .../operators/single/SingleDeferTest.java | 2 +- .../operators/single/SingleDelayTest.java | 4 +- .../operators/single/SingleDetachTest.java | 6 +- .../single/SingleDoAfterSuccessTest.java | 2 +- .../single/SingleDoOnLifecycleTest.java | 2 +- .../operators/single/SingleDoOnTest.java | 2 +- .../SingleFlatMapIterableFlowableTest.java | 9 +- .../SingleFlatMapIterableObservableTest.java | 3 +- .../single/SingleFromPublisherTest.java | 2 +- .../operators/single/SingleLiftTest.java | 2 +- .../operators/single/SingleMiscTest.java | 8 +- .../single/SingleSafeSubscribeTest.java | 6 +- .../operators/single/SingleTakeUntilTest.java | 2 +- .../operators/single/SingleTimeoutTest.java | 2 +- .../single/SingleUnsubscribeOnTest.java | 2 +- .../operators/single/SingleUsingTest.java | 2 +- .../schedulers/AbstractDirectTaskTest.java | 28 ++-- ...asicFuseableConditionalSubscriberTest.java | 12 +- .../BasicFuseableSubscriberTest.java | 2 +- .../subscribers/BlockingSubscriberTest.java | 4 +- .../DeferredScalarSubscriberTest.java | 4 +- .../subscribers/FlowableConsumersTest.java | 2 +- .../InnerQueuedSubscriberTest.java | 4 +- .../SinglePostCompleteSubscriberTest.java | 2 +- .../subscribers/StrictSubscriberTest.java | 20 +-- .../subscriptions/SubscriptionHelperTest.java | 2 +- .../internal/util/AtomicThrowableTest.java | 2 +- .../internal/util/EndConsumerHelperTest.java | 24 ++-- .../util/HalfSerializerObserverTest.java | 8 +- .../util/HalfSerializerSubscriberTest.java | 8 +- .../rxjava4/internal/util/MiscUtilTest.java | 2 +- .../internal/util/QueueDrainHelperTest.java | 34 ++--- .../io/reactivex/rxjava4/maybe/MaybeTest.java | 6 +- .../ObservableErrorHandlingTests.java | 4 +- .../observable/ObservableSubscriberTest.java | 9 +- .../rxjava4/observable/ObservableTest.java | 30 +--- .../rxjava4/observers/SafeObserverTest.java | 10 +- .../observers/SerializedObserverTest.java | 14 +- .../rxjava4/observers/TestObserverTest.java | 4 +- .../rxjava4/operators/SimpleQueueTest.java | 6 +- .../parallel/ParallelDoOnNextTryTest.java | 4 +- .../parallel/ParallelFilterTryTest.java | 4 +- .../parallel/ParallelFromPublisherTest.java | 6 +- .../rxjava4/parallel/ParallelJoinTest.java | 28 ++-- .../rxjava4/parallel/ParallelMapTest.java | 2 +- .../rxjava4/parallel/ParallelMapTryTest.java | 4 +- .../rxjava4/parallel/ParallelRunOnTest.java | 6 +- .../rxjava4/plugins/RxJavaPluginsTest.java | 26 ++-- .../processors/AsyncProcessorTest.java | 6 +- .../processors/BehaviorProcessorTest.java | 4 +- .../processors/MulticastProcessorTest.java | 10 +- .../processors/PublishProcessorTest.java | 10 +- ...ReplayProcessorBoundedConcurrencyTest.java | 6 +- .../ReplayProcessorConcurrencyTest.java | 6 +- .../processors/ReplayProcessorTest.java | 18 +-- .../processors/SerializedProcessorTest.java | 2 +- .../AbstractSchedulerConcurrencyTests.java | 128 ++++++++---------- .../schedulers/AbstractSchedulerTests.java | 51 ++++--- .../schedulers/ComputationSchedulerTests.java | 2 +- .../rxjava4/schedulers/SchedulerTest.java | 8 +- .../schedulers/SchedulerWorkerTest.java | 2 +- .../rxjava4/schedulers/TestSchedulerTest.java | 31 ++--- ...acheTest.java => SingleCacheMainTest.java} | 8 +- .../rxjava4/single/SingleSubscribeTest.java | 2 +- .../reactivex/rxjava4/single/SingleTest.java | 7 +- .../rxjava4/subjects/AsyncSubjectTest.java | 6 +- .../rxjava4/subjects/BehaviorSubjectTest.java | 6 +- .../subjects/CompletableSubjectTest.java | 2 +- .../rxjava4/subjects/MaybeSubjectTest.java | 2 +- .../rxjava4/subjects/PublishSubjectTest.java | 10 +- .../ReplaySubjectBoundedConcurrencyTest.java | 6 +- .../ReplaySubjectConcurrencyTest.java | 6 +- .../rxjava4/subjects/ReplaySubjectTest.java | 10 +- .../subjects/SerializedSubjectTest.java | 4 +- .../rxjava4/subjects/SingleSubjectTest.java | 2 +- .../subscribers/ResourceSubscriberTest.java | 2 +- .../subscribers/SafeSubscriberTest.java | 14 +- .../subscribers/SerializedSubscriberTest.java | 14 +- .../subscribers/TestSubscriberTest.java | 10 +- .../rxjava4/testsupport/TestHelper.java | 82 +++++------ .../testsupport/TestObserverExTest.java | 4 +- .../testsupport/TestSubscriberExTest.java | 12 +- .../CheckAnonymousClassForLambda.java | 110 +++++++++++++++ 232 files changed, 1128 insertions(+), 1182 deletions(-) rename src/test/java/io/reactivex/rxjava4/core/{SchedulerTest.java => SchedulerMainTest.java} (99%) rename src/test/java/io/reactivex/rxjava4/single/{SingleCacheTest.java => SingleCacheMainTest.java} (93%) create mode 100644 src/test/java/io/reactivex/rxjava4/validators/CheckAnonymousClassForLambda.java diff --git a/src/test/java/io/reactivex/rxjava4/core/SchedulerTest.java b/src/test/java/io/reactivex/rxjava4/core/SchedulerMainTest.java similarity index 99% rename from src/test/java/io/reactivex/rxjava4/core/SchedulerTest.java rename to src/test/java/io/reactivex/rxjava4/core/SchedulerMainTest.java index d246aa365e..e32847fbf3 100644 --- a/src/test/java/io/reactivex/rxjava4/core/SchedulerTest.java +++ b/src/test/java/io/reactivex/rxjava4/core/SchedulerMainTest.java @@ -26,7 +26,7 @@ import io.reactivex.rxjava4.schedulers.Schedulers; -public class SchedulerTest { +public class SchedulerMainTest { private static final String DRIFT_USE_NANOTIME = "rxjava4.scheduler.use-nanotime"; @After diff --git a/src/test/java/io/reactivex/rxjava4/disposables/CompositeDisposableTest.java b/src/test/java/io/reactivex/rxjava4/disposables/CompositeDisposableTest.java index 73ab2fe113..6421800773 100644 --- a/src/test/java/io/reactivex/rxjava4/disposables/CompositeDisposableTest.java +++ b/src/test/java/io/reactivex/rxjava4/disposables/CompositeDisposableTest.java @@ -56,17 +56,14 @@ public void shouldUnsubscribeAll() throws InterruptedException { final List threads = new ArrayList<>(); for (int i = 0; i < count; i++) { - final Thread t = new Thread() /* NFI */ { - @Override - public void run() { - try { - start.await(); - cd.dispose(); - } catch (final InterruptedException e) { - fail(e.getMessage()); - } + final Thread t = new Thread(() -> { + try { + start.await(); + cd.dispose(); + } catch (final InterruptedException e) { + fail(e.getMessage()); } - }; + }); t.start(); threads.add(t); } @@ -201,17 +198,14 @@ public void unsubscribeIdempotenceConcurrently() final List threads = new ArrayList<>(); for (int i = 0; i < count; i++) { - final Thread t = new Thread() /* NFI */ { - @Override - public void run() { - try { - start.await(); - cd.dispose(); - } catch (final InterruptedException e) { - fail(e.getMessage()); - } + final Thread t = new Thread(() -> { + try { + start.await(); + cd.dispose(); + } catch (final InterruptedException e) { + fail(e.getMessage()); } - }; + }); t.start(); threads.add(t); } diff --git a/src/test/java/io/reactivex/rxjava4/disposables/SequentialDisposableTest.java b/src/test/java/io/reactivex/rxjava4/disposables/SequentialDisposableTest.java index 89d441f8b5..791cc38158 100644 --- a/src/test/java/io/reactivex/rxjava4/disposables/SequentialDisposableTest.java +++ b/src/test/java/io/reactivex/rxjava4/disposables/SequentialDisposableTest.java @@ -131,19 +131,16 @@ public void settingUnderlyingWhenUnsubscribedCausesImmediateUnsubscriptionConcur final List threads = new ArrayList<>(); for (int i = 0; i < count; i++) { - final Thread t = new Thread() /* NFI */ { - @Override - public void run() { - try { - start.await(); - serialDisposable.dispose(); - } catch (InterruptedException e) { - fail(e.getMessage()); - } finally { - end.countDown(); - } + final Thread t = new Thread(() -> { + try { + start.await(); + serialDisposable.dispose(); + } catch (InterruptedException e) { + fail(e.getMessage()); + } finally { + end.countDown(); } - }; + }); t.start(); threads.add(t); } @@ -174,19 +171,16 @@ public void concurrentSetDisposableShouldNotInterleave() final Disposable subscription = mock(Disposable.class); subscriptions.add(subscription); - final Thread t = new Thread() /* NFI */ { - @Override - public void run() { - try { - start.await(); - serialDisposable.update(subscription); - } catch (InterruptedException e) { - fail(e.getMessage()); - } finally { - end.countDown(); - } + final Thread t = new Thread(() -> { + try { + start.await(); + serialDisposable.update(subscription); + } catch (InterruptedException e) { + fail(e.getMessage()); + } finally { + end.countDown(); } - }; + }); t.start(); threads.add(t); } diff --git a/src/test/java/io/reactivex/rxjava4/disposables/SerialDisposableTests.java b/src/test/java/io/reactivex/rxjava4/disposables/SerialDisposableTests.java index 43baa0a554..e2cd022582 100644 --- a/src/test/java/io/reactivex/rxjava4/disposables/SerialDisposableTests.java +++ b/src/test/java/io/reactivex/rxjava4/disposables/SerialDisposableTests.java @@ -131,19 +131,16 @@ public void settingUnderlyingWhenUnsubscribedCausesImmediateUnsubscriptionConcur final List threads = new ArrayList<>(); for (int i = 0; i < count; i++) { - final Thread t = new Thread() /* NFI */ { - @Override - public void run() { - try { - start.await(); - serialDisposable.dispose(); - } catch (InterruptedException e) { - fail(e.getMessage()); - } finally { - end.countDown(); - } + final Thread t = new Thread(() -> { + try { + start.await(); + serialDisposable.dispose(); + } catch (InterruptedException e) { + fail(e.getMessage()); + } finally { + end.countDown(); } - }; + }); t.start(); threads.add(t); } @@ -174,19 +171,16 @@ public void concurrentSetDisposableShouldNotInterleave() final Disposable subscription = mock(Disposable.class); subscriptions.add(subscription); - final Thread t = new Thread() /* NFI */ { - @Override - public void run() { - try { - start.await(); - serialDisposable.set(subscription); - } catch (InterruptedException e) { - fail(e.getMessage()); - } finally { - end.countDown(); - } + final Thread t = new Thread(() -> { + try { + start.await(); + serialDisposable.set(subscription); + } catch (InterruptedException e) { + fail(e.getMessage()); + } finally { + end.countDown(); } - }; + }); t.start(); threads.add(t); } diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/BlockingFlowableNextTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/BlockingFlowableNextTest.java index 79a9fdb025..9449a1fc92 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/BlockingFlowableNextTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/BlockingFlowableNextTest.java @@ -34,31 +34,25 @@ public class BlockingFlowableNextTest extends RxJavaTest { private void fireOnNextInNewThread(final FlowableProcessor o, final String value) { - new Thread() /* NFI */ { - @Override - public void run() { + new Thread(() -> { try { Thread.sleep(500); } catch (InterruptedException e) { // ignore } o.onNext(value); - } - }.start(); + }).start(); } private void fireOnErrorInNewThread(final FlowableProcessor o) { - new Thread() /* NFI */ { - @Override - public void run() { - try { - Thread.sleep(500); - } catch (InterruptedException e) { - // ignore - } - o.onError(new TestException()); + new Thread(() -> { + try { + Thread.sleep(500); + } catch (InterruptedException e) { + // ignore } - }.start(); + o.onError(new TestException()); + }).start(); } @Test diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRefCountTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRefCountTest.java index 8113c9c6bd..e7b8d8f12b 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRefCountTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRefCountTest.java @@ -528,7 +528,7 @@ public void disposed() { @Test public void noOpConnect() { final int[] calls = { 0 }; - Flowable f = new ConnectableFlowable() { + Flowable f = new ConnectableFlowable() /* NFI */ { @Override public void connect(Consumer connection) { calls[0]++; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayEagerTruncateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayEagerTruncateTest.java index 7a425d4fa0..71b11bd32d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayEagerTruncateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayEagerTruncateTest.java @@ -664,7 +664,7 @@ public boolean isDisposed() { @Test public void boundedReplayBuffer() { - BoundedReplayBuffer buf = new BoundedReplayBuffer(true) { + BoundedReplayBuffer buf = new BoundedReplayBuffer(true) /* NFI */ { private static final long serialVersionUID = -9081211580719235896L; @Override @@ -995,7 +995,7 @@ public void unsafeChildThrows() { .doOnNext(_ -> count.getAndIncrement()) .replay().autoConnect(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { throw new TestException(); @@ -1257,7 +1257,7 @@ public void connectConsumerThrows() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -1342,7 +1342,7 @@ public void unsubscribeReplayRace() { public void reentrantOnNext() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1364,7 +1364,7 @@ public void onNext(Integer t) { public void reentrantOnNextBound() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1386,7 +1386,7 @@ public void onNext(Integer t) { public void reentrantOnNextCancel() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1408,7 +1408,7 @@ public void onNext(Integer t) { public void reentrantOnNextCancelBounded() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1517,7 +1517,7 @@ public void sizedTruncation() { public void delayedUpstreamOnSubscribe() { final Subscriber[] sub = { null }; - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { sub[0] = s; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayTest.java index c4cc561f67..b2726e7f4b 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayTest.java @@ -667,7 +667,7 @@ public boolean isDisposed() { @Test public void boundedReplayBuffer() { - BoundedReplayBuffer buf = new BoundedReplayBuffer(false) { + BoundedReplayBuffer buf = new BoundedReplayBuffer(false) /* NFI */ { private static final long serialVersionUID = -9081211580719235896L; @Override @@ -704,7 +704,7 @@ void truncate() { @Test(expected = IllegalStateException.class) public void boundedRemoveFirstOneItemOnly() { - BoundedReplayBuffer buf = new BoundedReplayBuffer(false) { + BoundedReplayBuffer buf = new BoundedReplayBuffer(false) /* NFI */ { private static final long serialVersionUID = -9081211580719235896L; @Override @@ -1014,7 +1014,7 @@ public void unsafeChildOnNextThrows() { .doOnNext(_ -> count.getAndIncrement()) .replay().autoConnect(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { throw new TestException(); @@ -1037,7 +1037,7 @@ public void unsafeChildOnErrorThrows() throws Throwable { .replay() .autoConnect(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onError(Throwable t) { super.onError(t); @@ -1060,7 +1060,7 @@ public void unsafeChildOnCompleteThrows() throws Throwable { .replay() .autoConnect(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onComplete() { super.onComplete(); @@ -1322,7 +1322,7 @@ public void connectConsumerThrows() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -1407,7 +1407,7 @@ public void unsubscribeReplayRace() { public void reentrantOnNext() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1429,7 +1429,7 @@ public void onNext(Integer t) { public void reentrantOnNextBound() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1451,7 +1451,7 @@ public void onNext(Integer t) { public void reentrantOnNextCancel() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1473,7 +1473,7 @@ public void onNext(Integer t) { public void reentrantOnNextCancelBounded() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1582,9 +1582,9 @@ public void sizedTruncation() { public void delayedUpstreamOnSubscribe() { final Subscriber[] sub = { null }; - new Flowable() { + new Flowable() /* NFI */ { @Override - protected void subscribeActual(Subscriber s) { + protected void subscribeActual(Subscriber s) /* NFI */ { sub[0] = s; } } @@ -1871,7 +1871,7 @@ public void unsafeChildOnNextThrowsSizeBound() { .doOnNext(_ -> count.getAndIncrement()) .replay(1000).autoConnect(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { throw new TestException(); @@ -1894,7 +1894,7 @@ public void unsafeChildOnErrorThrowsSizeBound() throws Throwable { .replay(1000) .autoConnect(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onError(Throwable t) { super.onError(t); @@ -1917,7 +1917,7 @@ public void unsafeChildOnCompleteThrowsSizeBound() throws Throwable { .replay(1000) .autoConnect(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onComplete() { super.onComplete(); @@ -1969,7 +1969,7 @@ public void delayedUpstreamSubscription() { AtomicLong requested = new AtomicLong(); - ref.get().onSubscribe(new Subscription() { + ref.get().onSubscribe(new Subscription() /* NFI */ { @Override public void request(long n) { BackpressureHelper.add(requested, n); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryTest.java index 0db9b751f3..ef0c9ae569 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryTest.java @@ -45,7 +45,7 @@ public class FlowableRetryTest extends RxJavaTest { public void iterativeBackoff() { Subscriber consumer = TestHelper.mockSubscriber(); - Flowable producer = Flowable.unsafeCreate(new Publisher() { + Flowable producer = Flowable.unsafeCreate(new Publisher() /* NFI */ { private AtomicInteger count = new AtomicInteger(4); long last = System.currentTimeMillis(); @@ -338,7 +338,7 @@ public static class FuncWithErrors implements Publisher { @Override public void subscribe(final Subscriber subscriber) { - subscriber.onSubscribe(new Subscription() { + subscriber.onSubscribe(new Subscription() /* NFI */ { final AtomicLong req = new AtomicLong(); // 0 = not set, 1 = fast path, 2 = backpressure final AtomicInteger path = new AtomicInteger(0); @@ -405,7 +405,7 @@ public void retryAllowsSubscriptionAfterAllSubscriptionsUnsubscribed() throws In final AtomicInteger subsCount = new AtomicInteger(0); Publisher onSubscribe = s -> { subsCount.incrementAndGet(); - s.onSubscribe(new Subscription() { + s.onSubscribe(new Subscription() /* NFI */ { @Override public void request(long n) { @@ -508,7 +508,7 @@ static final class SlowFlowable implements Publisher { @Override public void subscribe(final Subscriber subscriber) { final AtomicBoolean terminate = new AtomicBoolean(false); - subscriber.onSubscribe(new Subscription() { + subscriber.onSubscribe(new Subscription() /* NFI */ { @Override public void request(long n) { // TODO Auto-generated method stub @@ -524,25 +524,22 @@ public void cancel() { efforts.getAndIncrement(); active.getAndIncrement(); maxActive.set(Math.max(active.get(), maxActive.get())); - final Thread thread = new Thread(context) { - @Override - public void run() { - long nr = 0; - try { - while (!terminate.get()) { - Thread.sleep(emitDelay); - if (nextBeforeFailure.getAndDecrement() > 0) { - subscriber.onNext(nr++); - } else { - active.decrementAndGet(); - subscriber.onError(new RuntimeException("expected-failed")); - break; - } + final Thread thread = new Thread(() -> { + long nr = 0; + try { + while (!terminate.get()) { + Thread.sleep(emitDelay); + if (nextBeforeFailure.getAndDecrement() > 0) { + subscriber.onNext(nr++); + } else { + active.decrementAndGet(); + subscriber.onError(new RuntimeException("expected-failed")); + break; } - } catch (InterruptedException t) { } + } catch (InterruptedException t) { } - }; + }, context); thread.start(); } } diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryWithPredicateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryWithPredicateTest.java index 8369a53623..12e97bb4c4 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryWithPredicateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryWithPredicateTest.java @@ -59,7 +59,7 @@ public void withNothingToRetry() { @Test public void retryTwice() { - Flowable source = Flowable.unsafeCreate(new Publisher() { + Flowable source = Flowable.unsafeCreate(new Publisher() /* NFI */ { int count; @Override public void subscribe(Subscriber t1) { @@ -120,7 +120,7 @@ public void retryTwiceAndGiveUp() { @Test public void retryOnSpecificException() { - Flowable source = Flowable.unsafeCreate(new Publisher() { + Flowable source = Flowable.unsafeCreate(new Publisher() /* NFI */ { int count; @Override public void subscribe(Subscriber t1) { @@ -157,7 +157,7 @@ public void subscribe(Subscriber t1) { public void retryOnSpecificExceptionAndNotOther() { final IOException ioe = new IOException(); final TestException te = new TestException(); - Flowable source = Flowable.unsafeCreate(new Publisher() { + Flowable source = Flowable.unsafeCreate(new Publisher() /* NFI */ { int count; @Override public void subscribe(Subscriber t1) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableScanTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableScanTest.java index 1e2fece48d..f656f412c3 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableScanTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableScanTest.java @@ -108,7 +108,7 @@ public void backpressureWithInitialValue() { final AtomicInteger count = new AtomicInteger(); Flowable.range(1, 100) .scan(0, Integer::sum) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -142,7 +142,7 @@ public void backpressureWithoutInitialValue() { final AtomicInteger count = new AtomicInteger(); Flowable.range(1, 100) .scan(Integer::sum) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -176,7 +176,7 @@ public void noBackpressureWithInitialValue() { final AtomicInteger count = new AtomicInteger(); Flowable.range(1, 100) .scan(0, Integer::sum) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -302,7 +302,7 @@ public void scanShouldNotRequestZero() { subscriber.onSubscribe(p); }).scan(100, Integer::sum); - f.subscribe(new TestSubscriber(1L) { + f.subscribe(new TestSubscriber(1L) /* NFI */ { @Override public void onNext(Integer integer) { @@ -511,7 +511,7 @@ public void scanErrorBackpressured() { @Test public void scanTake() { - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSequenceEqualTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSequenceEqualTest.java index a8c7f441e7..12cb1a5bef 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSequenceEqualTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSequenceEqualTest.java @@ -347,7 +347,7 @@ public void syncFusedCrashFlowable() { @Test public void cancelAndDrainRaceFlowable() { - Flowable neverNever = new Flowable() { + Flowable neverNever = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { } @@ -376,7 +376,7 @@ protected void subscribeActual(Subscriber s) { @Test public void sourceOverflowsFlowable() { - Flowable.sequenceEqual(Flowable.never(), new Flowable() { + Flowable.sequenceEqual(Flowable.never(), new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -394,7 +394,7 @@ protected void subscribeActual(Subscriber s) { public void doubleErrorFlowable() { List errors = TestHelper.trackPluginErrors(); try { - Flowable.sequenceEqual(Flowable.never(), new Flowable() { + Flowable.sequenceEqual(Flowable.never(), new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -437,7 +437,7 @@ public void syncFusedCrash() { @Test public void cancelAndDrainRace() { - Flowable neverNever = new Flowable() { + Flowable neverNever = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { } @@ -465,7 +465,7 @@ protected void subscribeActual(Subscriber s) { @Test public void sourceOverflows() { - Flowable.sequenceEqual(Flowable.never(), new Flowable() { + Flowable.sequenceEqual(Flowable.never(), new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -482,7 +482,7 @@ protected void subscribeActual(Subscriber s) { public void doubleError() { List errors = TestHelper.trackPluginErrors(); try { - Flowable.sequenceEqual(Flowable.never(), new Flowable() { + Flowable.sequenceEqual(Flowable.never(), new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSingleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSingleTest.java index af3431ad80..a75cc6b31a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSingleTest.java @@ -82,7 +82,7 @@ public void singleDoesNotRequestMoreThanItNeedsIf1Then2RequestedFlowable() { .singleElement() // .toFlowable() - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -118,7 +118,7 @@ public void singleDoesNotRequestMoreThanItNeedsIf3RequestedFlowable() { .singleElement() // .toFlowable() - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -153,7 +153,7 @@ public void singleRequestsExactlyWhatItNeedsIf1RequestedFlowable() { .singleElement() // .toFlowable() - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -314,7 +314,7 @@ public void singleOrDefaultWithPredicateAndEmptyFlowable() { public void singleWithBackpressureFlowable() { Flowable flowable = Flowable.just(1, 2).singleElement().toFlowable(); - Subscriber subscriber = spy(new DefaultSubscriber() { + Subscriber subscriber = spy(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSkipWhileTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSkipWhileTest.java index dd74055988..d089b09d06 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSkipWhileTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSkipWhileTest.java @@ -38,7 +38,7 @@ public class FlowableSkipWhileTest extends RxJavaTest { return v < 5; }; - private static final Predicate INDEX_LESS_THAN_THREE = new Predicate() { + private static final Predicate INDEX_LESS_THAN_THREE = new Predicate() /* NFI */ { int index; @Override public boolean test(Integer value) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSubscribeOnTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSubscribeOnTest.java index eba8817184..d057363e38 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSubscribeOnTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSubscribeOnTest.java @@ -165,7 +165,7 @@ public void unsubscribeInfiniteStream() throws InterruptedException { @Test public void backpressureReschedulesCorrectly() throws InterruptedException { final CountDownLatch latch = new CountDownLatch(10); - TestSubscriberEx ts = new TestSubscriberEx<>(new DefaultSubscriber() { + TestSubscriberEx ts = new TestSubscriberEx<>(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -198,7 +198,7 @@ public void setProducerSynchronousRequest() { TestSubscriber ts = new TestSubscriber<>(); Flowable.just(1, 2, 3).lift((FlowableOperator) child -> { final AtomicLong requested = new AtomicLong(); - child.onSubscribe(new Subscription() { + child.onSubscribe(new Subscription() /* NFI */ { @Override public void request(long n) { @@ -213,7 +213,7 @@ public void cancel() { } }); - Subscriber parent = new DefaultSubscriber() { + Subscriber parent = new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSwitchIfEmptyTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSwitchIfEmptyTest.java index 2f43311ec5..f13a3bc167 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSwitchIfEmptyTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSwitchIfEmptyTest.java @@ -52,7 +52,7 @@ public void switchWhenEmpty() throws Exception { @Test public void switchWithProducer() throws Exception { final AtomicBoolean emitted = new AtomicBoolean(false); - Flowable withProducer = Flowable.unsafeCreate(subscriber -> subscriber.onSubscribe(new Subscription() { + Flowable withProducer = Flowable.unsafeCreate(subscriber -> subscriber.onSubscribe(new Subscription() /* NFI */ { @Override public void request(long n) { if (n > 0 && emitted.compareAndSet(false, true)) { @@ -84,7 +84,7 @@ public void switchTriggerUnsubscribe() throws Exception { Flowable.empty() .switchIfEmpty(withProducer) - .lift((FlowableOperator) _ -> new DefaultSubscriber() { + .lift((FlowableOperator) _ -> new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -153,7 +153,7 @@ public void backpressureOnFirstObservable() { @Test public void requestsNotLost() throws InterruptedException { final TestSubscriber ts = new TestSubscriber<>(0L); - Flowable.unsafeCreate((Publisher) subscriber -> subscriber.onSubscribe(new Subscription() { + Flowable.unsafeCreate((Publisher) subscriber -> subscriber.onSubscribe(new Subscription() /* NFI */ { final AtomicBoolean completed = new AtomicBoolean(false); @Override public void request(long n) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSwitchTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSwitchTest.java index ba422a2fe8..84f7e32cf5 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSwitchTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSwitchTest.java @@ -370,7 +370,7 @@ public void backpressure() { publishCompleted(o3, 55); final TestSubscriberEx testSubscriber = new TestSubscriberEx<>(); - Flowable.switchOnNext(o).subscribe(new DefaultSubscriber() { + Flowable.switchOnNext(o).subscribe(new DefaultSubscriber() /* NFI */ { private int requested; @@ -431,7 +431,7 @@ public void issue2654() { .share() ; - TestSubscriberEx ts = new TestSubscriberEx() { + TestSubscriberEx ts = new TestSubscriberEx() /* NFI */ { @Override public void onNext(String t) { super.onNext(t); @@ -742,7 +742,7 @@ public void mapperThrows() { public void badMainSource() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -782,7 +782,7 @@ public void badInnerSource() { List errors = TestHelper.trackPluginErrors(); try { Flowable.just(1).hide() - .switchMap(Functions.justFunction(new Flowable() { + .switchMap(Functions.justFunction(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -805,7 +805,7 @@ protected void subscribeActual(Subscriber subscriber) { public void innerCompletesReentrant() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -826,7 +826,7 @@ public void onNext(Integer t) { public void innerErrorsReentrant() { final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -873,7 +873,7 @@ public void badSource() { @Test public void innerOverflow() { Flowable.just(1).hide() - .switchMap(Functions.justFunction(new Flowable() { + .switchMap(Functions.justFunction(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeLastTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeLastTest.java index 1289cee04b..b7687ab31e 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeLastTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeLastTest.java @@ -117,7 +117,7 @@ public void backpressure2() { } private Function newSlowProcessor() { - return new Function() { + return new Function() /* NFI */ { int c; @Override @@ -149,7 +149,8 @@ public void issue1522() { @Test public void ignoreRequest1() { // If `takeLast` does not ignore `request` properly, StackOverflowError will be thrown. - Flowable.range(0, 100000).takeLast(100000).subscribe(new DefaultSubscriber() { + Flowable.range(0, 100000).takeLast(100000) + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -175,7 +176,8 @@ public void onNext(Integer integer) { @Test public void ignoreRequest2() { // If `takeLast` does not ignore `request` properly, StackOverflowError will be thrown. - Flowable.range(0, 100000).takeLast(100000).subscribe(new DefaultSubscriber() { + Flowable.range(0, 100000).takeLast(100000) + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -200,7 +202,7 @@ public void onNext(Integer integer) { @Test public void ignoreRequest3() { // If `takeLast` does not ignore `request` properly, it will enter an infinite loop. - Flowable.range(0, 100000).takeLast(100000).subscribe(new DefaultSubscriber() { + Flowable.range(0, 100000).takeLast(100000).subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -226,7 +228,7 @@ public void onNext(Integer integer) { @Test public void ignoreRequest4() { // If `takeLast` does not ignore `request` properly, StackOverflowError will be thrown. - Flowable.range(0, 100000).takeLast(100000).subscribe(new DefaultSubscriber() { + Flowable.range(0, 100000).takeLast(100000).subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -252,7 +254,7 @@ public void onNext(Integer integer) { @Test public void unsubscribeTakesEffectEarlyOnFastPath() { final AtomicInteger count = new AtomicInteger(); - Flowable.range(0, 100000).takeLast(100000).subscribe(new DefaultSubscriber() { + Flowable.range(0, 100000).takeLast(100000).subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -280,7 +282,7 @@ public void onNext(Integer integer) { @Test public void requestOverflow() { final List list = new ArrayList<>(); - Flowable.range(1, 100).takeLast(50).subscribe(new DefaultSubscriber() { + Flowable.range(1, 100).takeLast(50).subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onStart() { @@ -340,7 +342,7 @@ public void badRequest() { @Test public void cancelThenRequest() { Flowable.never().takeLast(2) - .subscribe(new FlowableSubscriber() { + .subscribe(new FlowableSubscriber() /* NFI */ { @Override public void onNext(@NonNull Object t) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeTest.java index 77ad1c3e98..7c9fa429c8 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeTest.java @@ -265,7 +265,7 @@ public void takeObserveOn() { public void producerRequestThroughTake() { TestSubscriber ts = new TestSubscriber<>(3); final AtomicLong requested = new AtomicLong(); - Flowable.unsafeCreate((Publisher) s -> s.onSubscribe(new Subscription() { + Flowable.unsafeCreate((Publisher) s -> s.onSubscribe(new Subscription() /* NFI */ { @Override public void request(long n) { @@ -284,7 +284,7 @@ public void cancel() { public void producerRequestThroughTakeIsModified() { TestSubscriber ts = new TestSubscriber<>(3); final AtomicLong requested = new AtomicLong(); - Flowable.unsafeCreate((Publisher) s -> s.onSubscribe(new Subscription() { + Flowable.unsafeCreate((Publisher) s -> s.onSubscribe(new Subscription() /* NFI */ { @Override public void request(long n) { @@ -348,7 +348,7 @@ public void doesntRequestMoreThanNeededFromUpstream() throws InterruptedExceptio public void takeFinalValueThrows() { Flowable source = Flowable.just(1).take(1); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { throw new TestException(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeTest2.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeTest2.java index 5291721020..3fcc31da49 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeTest2.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeTest2.java @@ -159,7 +159,7 @@ public void noOverrequest() { public void cancelIgnored() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { BooleanSubscription bs = new BooleanSubscription(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeUntilPredicateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeUntilPredicateTest.java index b7e19009d6..18a6da09aa 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeUntilPredicateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeUntilPredicateTest.java @@ -153,7 +153,7 @@ public void doubleOnSubscribe() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeWhileTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeWhileTest.java index c5a921883f..86815d7d80 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeWhileTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTakeWhileTest.java @@ -76,7 +76,7 @@ public void takeWhileOnSubject1() { @Test public void takeWhile2() { Flowable w = Flowable.just("one", "two", "three"); - Flowable take = w.takeWhile(new Predicate() { + Flowable take = w.takeWhile(new Predicate() /* NFI */ { int index; @Override @@ -144,7 +144,7 @@ public void unsubscribeAfterTake() { Subscriber subscriber = TestHelper.mockSubscriber(); Flowable take = Flowable.unsafeCreate(w) - .takeWhile(new Predicate() { + .takeWhile(new Predicate() /* NFI */ { int index; @Override @@ -257,7 +257,7 @@ public void doubleOnSubscribe() { @Test public void badSource() { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableThrottleFirstTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableThrottleFirstTest.java index 6bf8710891..c27754155f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableThrottleFirstTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableThrottleFirstTest.java @@ -216,7 +216,7 @@ public void dispose() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableThrottleLatestTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableThrottleLatestTest.java index 1fae409dce..50f07510ad 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableThrottleLatestTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableThrottleLatestTest.java @@ -251,7 +251,7 @@ public void reentrantComplete() { TestScheduler sch = new TestScheduler(); final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimeoutTests.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimeoutTests.java index f91c54a919..9e894808cd 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimeoutTests.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimeoutTests.java @@ -344,7 +344,7 @@ public void timedEmpty() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -370,7 +370,7 @@ protected void subscribeActual(Subscriber subscriber) { public void badSourceOther() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimeoutWithSelectorTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimeoutWithSelectorTest.java index fa292d8dbb..646bdbdee7 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimeoutWithSelectorTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimeoutWithSelectorTest.java @@ -363,7 +363,7 @@ public void badInnerSource() { PublishProcessor pp = PublishProcessor.create(); TestSubscriberEx ts = pp - .timeout(Functions.justFunction(new Flowable() { + .timeout(Functions.justFunction(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -392,7 +392,7 @@ public void badInnerSourceOther() { PublishProcessor pp = PublishProcessor.create(); TestSubscriberEx ts = pp - .timeout(Functions.justFunction(new Flowable() { + .timeout(Functions.justFunction(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -426,7 +426,7 @@ public void withOtherMainError() { public void badSourceTimeout() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -495,7 +495,7 @@ public void lateOnTimeoutError() { final Subscriber[] sub = { null, null }; - final Flowable pp2 = new Flowable() { + final Flowable pp2 = new Flowable() /* NFI */ { int count; @@ -539,7 +539,7 @@ public void lateOnTimeoutFallbackRace() { final Subscriber[] sub = { null, null }; - final Flowable pp2 = new Flowable() { + final Flowable pp2 = new Flowable() /* NFI */ { int count; @@ -584,7 +584,7 @@ public void onErrorOnTimeoutRace() { final Subscriber[] sub = { null, null }; - final Flowable pp2 = new Flowable() { + final Flowable pp2 = new Flowable() /* NFI */ { int count; @@ -629,7 +629,7 @@ public void onCompleteOnTimeoutRace() { final Subscriber[] sub = { null, null }; - final Flowable pp2 = new Flowable() { + final Flowable pp2 = new Flowable() /* NFI */ { int count; @@ -672,7 +672,7 @@ public void onCompleteOnTimeoutRaceFallback() { final Subscriber[] sub = { null, null }; - final Flowable pp2 = new Flowable() { + final Flowable pp2 = new Flowable() /* NFI */ { int count; @@ -741,7 +741,7 @@ public void timeoutConsumerDoubleOnSubscribe() { List errors = TestHelper.trackPluginErrors(); try { BehaviorProcessor.createDefault(1) - .timeout(Functions.justFunction(new Flowable() { + .timeout(Functions.justFunction(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { BooleanSubscription bs1 = new BooleanSubscription(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimerTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimerTest.java index 0f3bb41dc0..44853a1b64 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimerTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableTimerTest.java @@ -232,7 +232,7 @@ public void withMultipleStaggeredSubscribersAndPublish() { public void onceObserverThrows() { Flowable source = Flowable.timer(100, TimeUnit.MILLISECONDS, scheduler); - source.safeSubscribe(new DefaultSubscriber() { + source.safeSubscribe(new DefaultSubscriber() /* NFI */ { @Override public void onNext(Long t) { @@ -263,7 +263,7 @@ public void periodicObserverThrows() { InOrder inOrder = inOrder(subscriber); - source.safeSubscribe(new DefaultSubscriber() { + source.safeSubscribe(new DefaultSubscriber() /* NFI */ { @Override public void onNext(Long t) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToFutureTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToFutureTest.java index f2179b93f4..19581cf26f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToFutureTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToFutureTest.java @@ -112,7 +112,7 @@ public void cancelledBeforeSubscribe() throws Exception { @Test public void cancellationDuringFutureGet() throws Exception { - Future future = new Future() { + Future future = new Future() /* NFI */ { private AtomicBoolean isCancelled = new AtomicBoolean(false); private AtomicBoolean isDone = new AtomicBoolean(false); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToMapTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToMapTest.java index 143c995bb8..d754444f0f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToMapTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToMapTest.java @@ -133,7 +133,7 @@ public void toMapWithErrorInValueSelectorFlowable() { public void toMapWithFactoryFlowable() { Flowable source = Flowable.just("a", "bb", "ccc", "dddd"); - Supplier> mapFactory = () -> new LinkedHashMap() { + Supplier> mapFactory = () -> new LinkedHashMap() /* NFI */ { private static final long serialVersionUID = -3296811238780863394L; @@ -272,7 +272,7 @@ public void toMapWithErrorInValueSelector() { public void toMapWithFactory() { Flowable source = Flowable.just("a", "bb", "ccc", "dddd"); - Supplier> mapFactory = () -> new LinkedHashMap() { + Supplier> mapFactory = () -> new LinkedHashMap() /* NFI */ { private static final long serialVersionUID = -3296811238780863394L; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToMultimapTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToMultimapTest.java index a44e1906ec..82684c59e0 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToMultimapTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableToMultimapTest.java @@ -77,7 +77,7 @@ public void toMultimapWithValueSelectorFlowable() { public void toMultimapWithMapFactoryFlowable() { Flowable source = Flowable.just("a", "b", "cc", "dd", "eee", "fff"); - Supplier>> mapFactory = () -> new LinkedHashMap>() { + Supplier>> mapFactory = () -> new LinkedHashMap>() /* NFI */ { private static final long serialVersionUID = -2084477070717362859L; @@ -268,7 +268,7 @@ public void toMultimapWithValueSelector() { public void toMultimapWithMapFactory() { Flowable source = Flowable.just("a", "b", "cc", "dd", "eee", "fff"); - Supplier>> mapFactory = () -> new LinkedHashMap>() { + Supplier>> mapFactory = () -> new LinkedHashMap>() /* NFI */ { private static final long serialVersionUID = -2084477070717362859L; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableUnsubscribeOnTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableUnsubscribeOnTest.java index ad5d1ff083..9a0ba48f3e 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableUnsubscribeOnTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableUnsubscribeOnTest.java @@ -231,7 +231,7 @@ public void error() { public void signalAfterDispose() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableUsingTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableUsingTest.java index 6cdc08a234..45b75058bb 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableUsingTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableUsingTest.java @@ -98,7 +98,7 @@ public void usingWithSubscribingTwiceDisposeEagerly() { private void performTestUsingWithSubscribingTwice(boolean disposeEagerly) { // When subscribe is called, a new resource should be created. - Supplier resourceFactory = () -> new Resource() { + Supplier resourceFactory = () -> new Resource() /* NFI */ { boolean first = true; @@ -286,7 +286,7 @@ private static Consumer createOnErrorAction(final List events } private static Supplier createResourceFactory(final List events) { - return () -> new Resource() { + return () -> new Resource() /* NFI */ { @Override public String getTextFromWeb() { @@ -437,7 +437,7 @@ public void doubleOnSubscribe() { public void eagerDisposedOnComplete() { final TestSubscriber ts = new TestSubscriber<>(); - Flowable.using(Functions.justSupplier(1), Functions.justFunction(new Flowable() { + Flowable.using(Functions.justSupplier(1), Functions.justFunction(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -452,7 +452,7 @@ protected void subscribeActual(Subscriber subscriber) { public void eagerDisposedOnError() { final TestSubscriber ts = new TestSubscriber<>(); - Flowable.using(Functions.justSupplier(1), Functions.justFunction(new Flowable() { + Flowable.using(Functions.justSupplier(1), Functions.justFunction(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithFlowableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithFlowableTest.java index 7db4f52470..c53b53e527 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithFlowableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithFlowableTest.java @@ -46,7 +46,7 @@ public void windowViaFlowableNormal1() { final List> values = new ArrayList<>(); - Subscriber> wo = new DefaultSubscriber>() { + Subscriber> wo = new DefaultSubscriber>() /* NFI */ { @Override public void onNext(Flowable args) { final Subscriber mo = TestHelper.mockSubscriber(); @@ -103,7 +103,7 @@ public void windowViaFlowableBoundaryCompletes() { final List> values = new ArrayList<>(); - Subscriber> wo = new DefaultSubscriber>() { + Subscriber> wo = new DefaultSubscriber>() /* NFI */ { @Override public void onNext(Flowable args) { final Subscriber mo = TestHelper.mockSubscriber(); @@ -159,7 +159,7 @@ public void windowViaFlowableBoundaryThrows() { final List> values = new ArrayList<>(); - Subscriber> wo = new DefaultSubscriber>() { + Subscriber> wo = new DefaultSubscriber>() /* NFI */ { @Override public void onNext(Flowable args) { final Subscriber mo = TestHelper.mockSubscriber(); @@ -209,7 +209,7 @@ public void windowViaFlowableThrows() { final List> values = new ArrayList<>(); - Subscriber> wo = new DefaultSubscriber>() { + Subscriber> wo = new DefaultSubscriber>() /* NFI */ { @Override public void onNext(Flowable args) { final Subscriber mo = TestHelper.mockSubscriber(); @@ -279,7 +279,7 @@ public void innerBadSource() { public void reentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -377,7 +377,7 @@ public void mainAndBoundaryBothError() { final AtomicReference> ref = new AtomicReference<>(); TestSubscriberEx> ts = Flowable.error(new TestException("main")) - .window(new Flowable() { + .window(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -413,14 +413,14 @@ public void mainCompleteBoundaryErrorRace() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - TestSubscriberEx> ts = new Flowable() { + TestSubscriberEx> ts = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); refMain.set(subscriber); } } - .window(new Flowable() { + .window(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -453,14 +453,14 @@ public void mainNextBoundaryNextRace() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - TestSubscriber> ts = new Flowable() { + TestSubscriber> ts = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); refMain.set(subscriber); } } - .window(new Flowable() { + .window(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -486,14 +486,14 @@ public void takeOneAnotherBoundary() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - TestSubscriberEx> ts = new Flowable() { + TestSubscriberEx> ts = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); refMain.set(subscriber); } } - .window(new Flowable() { + .window(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -518,18 +518,18 @@ public void disposeMainBoundaryCompleteRace() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - final TestSubscriber> ts = new Flowable() { + final TestSubscriber> ts = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); refMain.set(subscriber); } } - .window(new Flowable() { + .window(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { final AtomicInteger counter = new AtomicInteger(); - subscriber.onSubscribe(new Subscription() { + subscriber.onSubscribe(new Subscription() /* NFI */ { @Override public void cancel() { @@ -568,18 +568,18 @@ public void disposeMainBoundaryErrorRace() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - final TestSubscriber> ts = new Flowable() { + final TestSubscriber> ts = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); refMain.set(subscriber); } } - .window(new Flowable() { + .window(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { final AtomicInteger counter = new AtomicInteger(); - subscriber.onSubscribe(new Subscription() { + subscriber.onSubscribe(new Subscription() /* NFI */ { @Override public void cancel() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithSizeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithSizeTest.java index 313b72fa90..fc4505407a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithSizeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithSizeTest.java @@ -170,7 +170,7 @@ public void backpressureOuter() { final Subscriber subscriber = TestHelper.mockSubscriber(); - source.subscribe(new DefaultSubscriber>() { + source.subscribe(new DefaultSubscriber>() /* NFI */ { @Override public void onStart() { request(1); @@ -178,7 +178,7 @@ public void onStart() { @Override public void onNext(Flowable t) { - t.subscribe(new DefaultSubscriber() { + t.subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onNext(Integer t) { list.add(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithStartEndFlowableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithStartEndFlowableTest.java index 857b616792..1cb42bc755 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithStartEndFlowableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithStartEndFlowableTest.java @@ -99,7 +99,7 @@ private void complete(final Subscriber subscriber, int delay) { } private Consumer> observeWindow(final List list, final List> lists) { - return stringFlowable -> stringFlowable.subscribe(new DefaultSubscriber() { + return stringFlowable -> stringFlowable.subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { lists.add(new ArrayList<>(list)); @@ -191,7 +191,7 @@ public void dispose() { public void reentrant() { final FlowableProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -298,7 +298,7 @@ public void windowCloseIngoresCancel() { List errors = TestHelper.trackPluginErrors(); try { BehaviorProcessor.createDefault(1) - .window(BehaviorProcessor.createDefault(1), _ -> new Flowable() { + .window(BehaviorProcessor.createDefault(1), _ -> new Flowable() /* NFI */ { @Override protected void subscribeActual( Subscriber s) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithTimeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithTimeTest.java index 34e04f42e4..a840f37d45 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithTimeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWindowWithTimeTest.java @@ -122,7 +122,7 @@ private void complete(final Subscriber subscriber, int delay) { } private Consumer> observeWindow(final List list, final List> lists) { - return stringFlowable -> stringFlowable.subscribe(new DefaultSubscriber() { + return stringFlowable -> stringFlowable.subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { lists.add(new ArrayList<>(list)); @@ -549,7 +549,7 @@ public void exactUnboundedReentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -577,7 +577,7 @@ public void exactBoundedReentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -605,7 +605,7 @@ public void exactBoundedReentrant2() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -633,7 +633,7 @@ public void skipReentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -817,7 +817,7 @@ public void nextWindowMissingBackpressureDrainOnSize() { final PublishProcessor pp = PublishProcessor.create(); TestSubscriber> ts = pp.window(1, TimeUnit.MINUTES, 1) - .subscribeWith(new TestSubscriber>(2) { + .subscribeWith(new TestSubscriber>(2) /* NFI */ { int calls; @Override public void onNext(Flowable t) { @@ -861,7 +861,7 @@ public void exactTimeBoundNoInterruptWindowOutputOnComplete() throws Exception { final CountDownLatch secondWindowProcessing = new CountDownLatch(1); pp.window(100, TimeUnit.MILLISECONDS) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Flowable v) throws Exception { @@ -902,7 +902,7 @@ public void exactTimeBoundNoInterruptWindowOutputOnError() throws Exception { final CountDownLatch secondWindowProcessing = new CountDownLatch(1); pp.window(100, TimeUnit.MILLISECONDS) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Flowable v) throws Exception { @@ -942,7 +942,7 @@ public void exactTimeAndSizeBoundNoInterruptWindowOutputOnComplete() throws Exce final CountDownLatch secondWindowProcessing = new CountDownLatch(1); pp.window(100, TimeUnit.MILLISECONDS, 10) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Flowable v) throws Exception { @@ -983,7 +983,7 @@ public void exactTimeAndSizeBoundNoInterruptWindowOutputOnError() throws Excepti final CountDownLatch secondWindowProcessing = new CountDownLatch(1); pp.window(100, TimeUnit.MILLISECONDS, 10) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Flowable v) throws Exception { @@ -1023,7 +1023,7 @@ public void skipTimeAndSizeBoundNoInterruptWindowOutputOnComplete() throws Excep final CountDownLatch secondWindowProcessing = new CountDownLatch(1); pp.window(90, 100, TimeUnit.MILLISECONDS) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Flowable v) throws Exception { @@ -1064,7 +1064,7 @@ public void skipTimeAndSizeBoundNoInterruptWindowOutputOnError() throws Exceptio final CountDownLatch secondWindowProcessing = new CountDownLatch(1); pp.window(90, 100, TimeUnit.MILLISECONDS) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Flowable v) throws Exception { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWithLatestFromTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWithLatestFromTest.java index 87a4730e85..d1dd21bc57 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWithLatestFromTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableWithLatestFromTest.java @@ -589,7 +589,7 @@ public void manyCombinerThrows() { public void manyErrors() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -613,7 +613,7 @@ public void otherErrors() { List errors = TestHelper.trackPluginErrors(); try { Flowable.just(1) - .withLatestFrom(new Flowable() { + .withLatestFrom(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableZipIterableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableZipIterableTest.java index 8c46710ca6..385324468b 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableZipIterableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableZipIterableTest.java @@ -227,7 +227,7 @@ public void zipIterableHasNextThrows() { Subscriber subscriber = TestHelper.mockSubscriber(); InOrder io = inOrder(subscriber); - Iterable r2 = () -> new Iterator() { + Iterable r2 = () -> new Iterator() /* NFI */ { int count; @Override @@ -270,7 +270,7 @@ public void zipIterableNextThrows() { Subscriber subscriber = TestHelper.mockSubscriber(); InOrder io = inOrder(subscriber); - Iterable r2 = () -> new Iterator() { + Iterable r2 = () -> new Iterator() /* NFI */ { @Override public boolean hasNext() { return true; @@ -346,7 +346,7 @@ public void iteratorThrows() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableZipTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableZipTest.java index a88f28d36b..07b5251458 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableZipTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableZipTest.java @@ -679,7 +679,7 @@ public void startWithOnCompletedTwice() { final Subscriber subscriber = TestHelper.mockSubscriber(); Flowable.zip(Flowable.just(1), - Flowable.just(1), Integer::sum).subscribe(new DefaultSubscriber() { + Flowable.just(1), Integer::sum).subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -746,7 +746,7 @@ public void startInfiniteAndFinite() throws InterruptedException { .zipWith(ASYNC_OBSERVABLE_OF_INFINITE_INTEGERS(infiniteFlowable), (a, b) -> a + "-" + b); final ArrayList list = new ArrayList<>(); - os.subscribe(new DefaultSubscriber() { + os.subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -953,7 +953,7 @@ public void downstreamBackpressureRequestsWithInfiniteSyncFlowables() { } private Flowable createInfiniteFlowable(final AtomicInteger generated) { - Flowable flowable = Flowable.fromIterable(() -> new Iterator() { + Flowable flowable = Flowable.fromIterable(() -> new Iterator() /* NFI */ { @Override public void remove() { @@ -1029,7 +1029,7 @@ public void issue1812() { public void unboundedDownstreamOverrequesting() { Flowable source = Flowable.range(1, 2).zipWith(Flowable.range(1, 2), (t1, t2) -> t1 + 10 * t2); - TestSubscriberEx ts = new TestSubscriberEx() { + TestSubscriberEx ts = new TestSubscriberEx() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -1350,7 +1350,7 @@ public void multiError() { @SuppressWarnings("rawtypes") final Subscriber[] sub = { null }; - TestSubscriberEx ts = Flowable.zip(pp, new Flowable() { + TestSubscriberEx ts = Flowable.zip(pp, new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { sub[0] = s; @@ -1517,7 +1517,7 @@ public void fusedInputThrows2Backpressured() { @Test public void cancelOnBackpressureBoundary() { - TestSubscriber ts = new TestSubscriber(1L) { + TestSubscriber ts = new TestSubscriber(1L) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeAmbTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeAmbTest.java index 8443db8a45..f63789f475 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeAmbTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeAmbTest.java @@ -106,7 +106,7 @@ public void innerErrorRace() { @Test public void disposeNoFurtherSignals() { - TestObserver to = Maybe.ambArray(new Maybe() { + TestObserver to = Maybe.ambArray(new Maybe() /* NFI */ { @Override protected void subscribeActual( MaybeObserver observer) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeCacheTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeCacheTest.java index c687017909..cafe7fc703 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeCacheTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeCacheTest.java @@ -245,7 +245,7 @@ public void doubleDispose() { final Disposable[] dout = { null }; - source.subscribe(new MaybeObserver() { + source.subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeConcatArrayTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeConcatArrayTest.java index c02c0496db..2ad81c4a71 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeConcatArrayTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeConcatArrayTest.java @@ -114,7 +114,7 @@ public void errorAfterTermination() { final MaybeObserver[] o = { null }; Maybe.concatArray(MaybeConcatConfig.DELAY_ERROR, Maybe.just(1), Maybe.error(new IOException()), - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeCreateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeCreateTest.java index 9616451000..bf768b3078 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeCreateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeCreateTest.java @@ -71,7 +71,7 @@ public void onSuccessThrows() { assertTrue(d.isDisposed()); assertTrue(e.isDisposed()); - }).subscribe(new MaybeObserver() { + }).subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -110,7 +110,7 @@ public void onErrorThrows() { assertTrue(d.isDisposed()); assertTrue(e.isDisposed()); - }).subscribe(new MaybeObserver() { + }).subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -149,7 +149,7 @@ public void onCompleteThrows() { assertTrue(d.isDisposed()); assertTrue(e.isDisposed()); - }).subscribe(new MaybeObserver() { + }).subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -184,7 +184,7 @@ public void onSuccessThrows2() { } assertTrue(e.isDisposed()); - }).subscribe(new MaybeObserver() { + }).subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -219,7 +219,7 @@ public void onErrorThrows2() { } assertTrue(e.isDisposed()); - }).subscribe(new MaybeObserver() { + }).subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -254,7 +254,7 @@ public void onCompleteThrows2() { } assertTrue(e.isDisposed()); - }).subscribe(new MaybeObserver() { + }).subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDelayOtherTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDelayOtherTest.java index dfb3ee5fc9..e4d8de2ecf 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDelayOtherTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDelayOtherTest.java @@ -220,7 +220,7 @@ public void withOtherPublisherDoubleOnSubscribe() { @Test public void otherPublisherNextSlipsThrough() { - Maybe.just(1).delay(new Flowable() { + Maybe.just(1).delay(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDelaySubscriptionTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDelaySubscriptionTest.java index 9f825f94e3..853c8ee683 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDelaySubscriptionTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDelaySubscriptionTest.java @@ -115,7 +115,7 @@ public void withPublisherCallAfterTerminalEvent() { List errors = TestHelper.trackPluginErrors(); try { - Flowable f = new Flowable() { + Flowable f = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDetachTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDetachTest.java index 41d2a89b00..4be1afd2bd 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDetachTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDetachTest.java @@ -61,7 +61,7 @@ public void cancelDetaches() throws Exception { Disposable d = Disposable.empty(); final WeakReference wr = new WeakReference<>(d); - TestObserver to = new Maybe() { + TestObserver to = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(wr.get()); @@ -87,7 +87,7 @@ public void completeDetaches() throws Exception { Disposable d = Disposable.empty(); final WeakReference wr = new WeakReference<>(d); - TestObserver to = new Maybe() { + TestObserver to = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(wr.get()); @@ -113,7 +113,7 @@ public void errorDetaches() throws Exception { Disposable d = Disposable.empty(); final WeakReference wr = new WeakReference<>(d); - TestObserver to = new Maybe() { + TestObserver to = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(wr.get()); @@ -139,7 +139,7 @@ public void successDetaches() throws Exception { Disposable d = Disposable.empty(); final WeakReference wr = new WeakReference<>(d); - TestObserver to = new Maybe() { + TestObserver to = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(wr.get()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoAfterSuccessTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoAfterSuccessTest.java index 07c2cc5367..ce1889b2e7 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoAfterSuccessTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoAfterSuccessTest.java @@ -34,7 +34,7 @@ public class MaybeDoAfterSuccessTest extends RxJavaTest { final Consumer afterSuccess = e -> values.add(-e); - final TestObserver to = new TestObserver() { + final TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoOnEventTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoOnEventTest.java index 34965164cf..f8b62b79ba 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoOnEventTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoOnEventTest.java @@ -49,7 +49,7 @@ public void onSubscribeCrash() { try { final Disposable bs = Disposable.empty(); - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(bs); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoOnLifecycleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoOnLifecycleTest.java index 568c4780a4..e75b955835 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoOnLifecycleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeDoOnLifecycleTest.java @@ -84,7 +84,7 @@ public void onSubscribeCrash() throws Throwable { Disposable bs = Disposable.empty(); - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(bs); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeFlatMapIterableFlowableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeFlatMapIterableFlowableTest.java index 04be60ac66..3bd407bb4a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeFlatMapIterableFlowableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeFlatMapIterableFlowableTest.java @@ -231,7 +231,7 @@ public void async4() { @Test public void fusedEmptyCheck() { Maybe.just(1) - .flattenAsFlowable(_ -> Arrays.asList(1, 2, 3)).subscribe(new FlowableSubscriber() { + .flattenAsFlowable(_ -> Arrays.asList(1, 2, 3)).subscribe(new FlowableSubscriber() /* NFI */ { QueueSubscription qs; @SuppressWarnings("unchecked") @Override @@ -364,7 +364,7 @@ public void slowPathCancelAfterHasNext() { final TestSubscriber ts = new TestSubscriber<>(0L); Maybe.just(1) - .flattenAsFlowable(_ -> (Iterable) () -> new Iterator() { + .flattenAsFlowable(_ -> (Iterable) () -> new Iterator() /* NFI */ { int count; @Override public boolean hasNext() { @@ -398,7 +398,7 @@ public void fastPathCancelAfterHasNext() { final TestSubscriber ts = new TestSubscriber<>(0L); Maybe.just(1) - .flattenAsFlowable(_ -> (Iterable) () -> new Iterator() { + .flattenAsFlowable(_ -> (Iterable) () -> new Iterator() /* NFI */ { int count; @Override public boolean hasNext() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeFlatMapIterableObservableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeFlatMapIterableObservableTest.java index 4f1aadafc4..42aaefa359 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeFlatMapIterableObservableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeFlatMapIterableObservableTest.java @@ -215,7 +215,8 @@ public void async4() { @Test public void fusedEmptyCheck() { Maybe.just(1) - .flattenAsObservable(_ -> Arrays.asList(1, 2, 3)).subscribe(new Observer() { + .flattenAsObservable(_ -> Arrays.asList(1, 2, 3)) + .subscribe(new Observer() /* NFI */ { QueueDisposable qd; @SuppressWarnings("unchecked") @Override diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeMergeArrayTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeMergeArrayTest.java index 06b6bbb061..845e8e42ce 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeMergeArrayTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeMergeArrayTest.java @@ -61,7 +61,7 @@ public void fusedPollMixed() { @Test public void fusedEmptyCheck() { Maybe.mergeArray(Maybe.just(1), Maybe.empty(), Maybe.just(2)) - .subscribe(new FlowableSubscriber() { + .subscribe(new FlowableSubscriber() /* NFI */ { QueueSubscription qs; @Override public void onSubscribe(Subscription s) { @@ -159,7 +159,7 @@ public void errorRace() { @Test public void mergeBadSource() { - Maybe.mergeArray(new Maybe() { + Maybe.mergeArray(new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); @@ -176,7 +176,7 @@ protected void subscribeActual(MaybeObserver observer) { @Test public void smallOffer2Throws() { Maybe.mergeArray(Maybe.never(), Maybe.never()) - .subscribe(new FlowableSubscriber() { + .subscribe(new FlowableSubscriber() /* NFI */ { @SuppressWarnings("rawtypes") @Override @@ -211,7 +211,7 @@ public void largeOffer2Throws() { Maybe[] a = new Maybe[1024]; Arrays.fill(a, Maybe.never()); Maybe.mergeArray(a) - .subscribe(new FlowableSubscriber() { + .subscribe(new FlowableSubscriber() /* NFI */ { @SuppressWarnings("rawtypes") @Override diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybePeekTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybePeekTest.java index b4334c8499..02e4b383f7 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybePeekTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybePeekTest.java @@ -48,7 +48,7 @@ public void doubleError() { final Throwable[] err = { null }; try { - TestObserverEx to = new Maybe() { + TestObserverEx to = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); @@ -74,7 +74,7 @@ protected void subscribeActual(MaybeObserver observer) { public void doubleComplete() { final int[] compl = { 0 }; - TestObserver to = new Maybe() { + TestObserver to = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeSafeSubscribeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeSafeSubscribeTest.java index d99df27e31..0e912f96bd 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeSafeSubscribeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeSafeSubscribeTest.java @@ -91,7 +91,7 @@ public void onSubscribeCrash() throws Throwable { Disposable d = Disposable.empty(); - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(@NonNull MaybeObserver observer) { observer.onSubscribe(d); @@ -121,7 +121,7 @@ public void onSuccessCrash() throws Throwable { MaybeObserver consumer = mock(MaybeObserver.class); doThrow(new TestException()).when(consumer).onSuccess(any()); - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(@NonNull MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); @@ -146,7 +146,7 @@ public void onErrorCrash() throws Throwable { MaybeObserver consumer = mock(MaybeObserver.class); doThrow(new TestException()).when(consumer).onError(any()); - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(@NonNull MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); @@ -176,7 +176,7 @@ public void onCompleteCrash() throws Throwable { MaybeObserver consumer = mock(MaybeObserver.class); doThrow(new TestException()).when(consumer).onComplete(); - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(@NonNull MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutPublisherTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutPublisherTest.java index a08ad7527d..75e0bdf814 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutPublisherTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutPublisherTest.java @@ -212,7 +212,7 @@ public void badSourceOther() { public void mainSuccessAfterOtherSignal() { PublishProcessor pp = PublishProcessor.create(); - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(@NonNull MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutTest.java index c0f3cdf50b..945791b778 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutTest.java @@ -329,7 +329,7 @@ public void onCompleteRace() { public void mainSuccessAfterOtherSignal() { MaybeSubject ms = MaybeSubject.create(); - new Maybe() { + new Maybe() /* NFI */ { @Override protected void subscribeActual(@NonNull MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeUnsubscribeOnTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeUnsubscribeOnTest.java index 21877cc78c..18fe23d671 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeUnsubscribeOnTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeUnsubscribeOnTest.java @@ -100,7 +100,7 @@ public void disposeRace() { final Disposable[] ds = { null }; pp.singleElement().unsubscribeOn(Schedulers.computation()) - .subscribe(new MaybeObserver() { + .subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { ds[0] = d; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeZipArrayTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeZipArrayTest.java index c6e111a876..307a907246 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeZipArrayTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeZipArrayTest.java @@ -150,13 +150,13 @@ public void bothComplete() { AtomicReference> ref1 = new AtomicReference<>(); AtomicReference> ref2 = new AtomicReference<>(); - Maybe m1 = new Maybe() { + Maybe m1 = new Maybe() /* NFI */ { @Override protected void subscribeActual(@NonNull MaybeObserver observer) { ref1.set(observer); } }; - Maybe m2 = new Maybe() { + Maybe m2 = new Maybe() /* NFI */ { @Override protected void subscribeActual(@NonNull MaybeObserver observer) { ref2.set(observer); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapCompletableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapCompletableTest.java index a0c5e6549d..4c57e0460d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapCompletableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapCompletableTest.java @@ -249,7 +249,7 @@ public void disposed() { public void queueOverflow() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapMaybeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapMaybeTest.java index c416a535c7..605858efa1 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapMaybeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapMaybeTest.java @@ -203,7 +203,7 @@ public void doubleOnSubscribe() { public void queueOverflow() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -254,7 +254,7 @@ public void innerErrorAfterMainError() { final AtomicReference> obs = new AtomicReference<>(); TestSubscriberEx ts = pp.concatMapMaybe( - (Function>) _ -> new Maybe() { + (Function>) _ -> new Maybe() /* NFI */ { @Override protected void subscribeActual( MaybeObserver observer) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapSingleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapSingleTest.java index 7444e9eac3..38c4f74e0a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapSingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableConcatMapSingleTest.java @@ -135,7 +135,7 @@ public void doubleOnSubscribe() { public void queueOverflow() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -186,7 +186,7 @@ public void innerErrorAfterMainError() { final AtomicReference> obs = new AtomicReference<>(); TestSubscriberEx ts = pp.concatMapSingle( - (Function>) _ -> new Single() { + (Function>) _ -> new Single() /* NFI */ { @Override protected void subscribeActual( SingleObserver observer) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapCompletableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapCompletableTest.java index fdf19d8fde..0f1f56db38 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapCompletableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapCompletableTest.java @@ -247,7 +247,7 @@ public void onErrorInnerErrorRace() { public void innerErrorThenMainError() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapMaybeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapMaybeTest.java index 3d0daf3fe1..07efc61904 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapMaybeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapMaybeTest.java @@ -306,7 +306,7 @@ public void cancel() { public void mainErrorAfterTermination() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -330,7 +330,7 @@ public void innerErrorAfterTermination() { try { final AtomicReference> moRef = new AtomicReference<>(); - TestSubscriberEx ts = new Flowable() { + TestSubscriberEx ts = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -338,7 +338,7 @@ protected void subscribeActual(Subscriber s) { s.onError(new TestException("outer")); } } - .switchMapMaybe((Function>) _ -> new Maybe() { + .switchMapMaybe((Function>) _ -> new Maybe() /* NFI */ { @Override protected void subscribeActual( MaybeObserver observer) { @@ -488,7 +488,7 @@ public void nextInnerSuccessRace() { @Test public void requestMoreOnNext() { - TestSubscriber ts = new TestSubscriber(1) { + TestSubscriber ts = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapSingleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapSingleTest.java index 50f8225380..4b51f0394b 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapSingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/FlowableSwitchMapSingleTest.java @@ -268,7 +268,7 @@ public void cancel() { public void mainErrorAfterTermination() { List errors = TestHelper.trackPluginErrors(); try { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -292,7 +292,7 @@ public void innerErrorAfterTermination() { try { final AtomicReference> moRef = new AtomicReference<>(); - TestSubscriberEx ts = new Flowable() { + TestSubscriberEx ts = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -300,7 +300,7 @@ protected void subscribeActual(Subscriber s) { s.onError(new TestException("outer")); } } - .switchMapSingle((Function>) _ -> new Single() { + .switchMapSingle((Function>) _ -> new Single() /* NFI */ { @Override protected void subscribeActual( SingleObserver observer) { @@ -449,7 +449,7 @@ public void nextInnerSuccessRace() { @Test public void requestMoreOnNext() { - TestSubscriber ts = new TestSubscriber(1) { + TestSubscriber ts = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableConcatMapMaybeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableConcatMapMaybeTest.java index a68366bca8..33985ebd85 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableConcatMapMaybeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableConcatMapMaybeTest.java @@ -192,7 +192,7 @@ public void cancel() { public void mainErrorAfterInnerError() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -221,7 +221,7 @@ public void innerErrorAfterMainError() { final AtomicReference> obs = new AtomicReference<>(); TestObserverEx to = ps.concatMapMaybe( - (Function>) _ -> new Maybe() { + (Function>) _ -> new Maybe() /* NFI */ { @Override protected void subscribeActual( MaybeObserver observer) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableConcatMapSingleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableConcatMapSingleTest.java index b84b0818fc..3a8741d3f4 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableConcatMapSingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableConcatMapSingleTest.java @@ -124,7 +124,7 @@ public void cancel() { public void mainErrorAfterInnerError() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -153,7 +153,7 @@ public void innerErrorAfterMainError() { final AtomicReference> obs = new AtomicReference<>(); TestObserverEx to = ps.concatMapSingle( - (Function>) _ -> new Single() { + (Function>) _ -> new Single() /* NFI */ { @Override protected void subscribeActual( SingleObserver observer) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapCompletableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapCompletableTest.java index 63f867c4ad..cd703deea8 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapCompletableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapCompletableTest.java @@ -246,7 +246,7 @@ public void onErrorInnerErrorRace() { public void innerErrorThenMainError() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapMaybeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapMaybeTest.java index 8abc681bb2..4d148916a2 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapMaybeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapMaybeTest.java @@ -286,7 +286,7 @@ public void cancel() { public void mainErrorAfterTermination() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -310,7 +310,7 @@ public void innerErrorAfterTermination() { try { final AtomicReference> moRef = new AtomicReference<>(); - TestObserverEx to = new Observable() { + TestObserverEx to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -318,7 +318,7 @@ protected void subscribeActual(Observer observer) { observer.onError(new TestException("outer")); } } - .switchMapMaybe((Function>) _ -> new Maybe() { + .switchMapMaybe((Function>) _ -> new Maybe() /* NFI */ { @Override protected void subscribeActual( MaybeObserver observer) { @@ -478,7 +478,7 @@ public void checkDisposed() { public void drainReentrant() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapSingleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapSingleTest.java index 4bccccc17c..0b79b704c5 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapSingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/mixed/ObservableSwitchMapSingleTest.java @@ -265,7 +265,7 @@ public void cancel() { public void mainErrorAfterTermination() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -289,7 +289,7 @@ public void innerErrorAfterTermination() { try { final AtomicReference> moRef = new AtomicReference<>(); - TestObserverEx to = new Observable() { + TestObserverEx to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -297,7 +297,7 @@ protected void subscribeActual(Observer observer) { observer.onError(new TestException("outer")); } } - .switchMapSingle((Function>) _ -> new Single() { + .switchMapSingle((Function>) _ -> new Single() /* NFI */ { @Override protected void subscribeActual( SingleObserver observer) { @@ -456,7 +456,7 @@ public void checkDisposed() { public void drainReentrant() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/BlockingObservableNextTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/BlockingObservableNextTest.java index bfc0abfa37..7ed482a86b 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/BlockingObservableNextTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/BlockingObservableNextTest.java @@ -34,31 +34,25 @@ public class BlockingObservableNextTest extends RxJavaTest { private void fireOnNextInNewThread(final Subject o, final String value) { - new Thread() { - @Override - public void run() { - try { - Thread.sleep(500); - } catch (InterruptedException e) { - // ignore - } - o.onNext(value); + new Thread(() -> { + try { + Thread.sleep(500); + } catch (InterruptedException e) { + // ignore } - }.start(); + o.onNext(value); + }).start(); } private void fireOnErrorInNewThread(final Subject o) { - new Thread() { - @Override - public void run() { - try { - Thread.sleep(500); - } catch (InterruptedException e) { - // ignore - } - o.onError(new TestException()); + new Thread(() -> { + try { + Thread.sleep(500); + } catch (InterruptedException e) { + // ignore } - }.start(); + o.onError(new TestException()); + }).start(); } static Iterable next(ObservableSource source) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAllTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAllTest.java index bce4cfc78a..73c70108bc 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAllTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAllTest.java @@ -232,7 +232,7 @@ public void dispose() { public void predicateThrowsObservable() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -260,7 +260,7 @@ protected void subscribeActual(Observer observer) { public void predicateThrows() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAnyTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAnyTest.java index 6902003d9d..9fa13099fa 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAnyTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAnyTest.java @@ -408,7 +408,7 @@ public void doubleOnSubscribe() { public void predicateThrowsSuppressOthers() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -436,7 +436,7 @@ protected void subscribeActual(Observer observer) { public void badSourceSingle() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableBlockingTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableBlockingTest.java index 641d7aaa2c..3ffe632d1c 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableBlockingTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableBlockingTest.java @@ -103,7 +103,7 @@ public void blockingSubscribeObserver() { Observable.range(1, 5) .subscribeOn(Schedulers.computation()) - .blockingSubscribe(new Observer() { + .blockingSubscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -138,7 +138,7 @@ public void blockingSubscribeObserverError() { Observable.range(1, 5).concatWith(Observable.error(ex)) .subscribeOn(Schedulers.computation()) - .blockingSubscribe(new Observer() { + .blockingSubscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -222,7 +222,7 @@ public void delayed() throws Exception { obsRef.get().onNext(1); }, 200, TimeUnit.MILLISECONDS); - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableBufferTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableBufferTest.java index 11ee390358..2ac26fcfb4 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableBufferTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableBufferTest.java @@ -673,7 +673,7 @@ public void bufferWithTimeDoesntUnsubscribeDownstream() throws InterruptedExcept final Observer o = TestHelper.mockObserver(); final CountDownLatch cdl = new CountDownLatch(1); - DisposableObserver observer = new DisposableObserver() { + DisposableObserver observer = new DisposableObserver() /* NFI */ { @Override public void onNext(Object t) { o.onNext(t); @@ -770,7 +770,7 @@ public void supplierThrows3() { @Test public void supplierThrows4() { Observable.never() - .buffer(1, TimeUnit.MILLISECONDS, Schedulers.single(), Integer.MAX_VALUE, new Supplier>() { + .buffer(1, TimeUnit.MILLISECONDS, Schedulers.single(), Integer.MAX_VALUE, new Supplier>() /* NFI */ { int count; @Override public Collection get() throws Exception { @@ -789,7 +789,7 @@ public Collection get() throws Exception { @Test public void supplierThrows5() { Observable.never() - .buffer(1, TimeUnit.MILLISECONDS, Schedulers.single(), 10, new Supplier>() { + .buffer(1, TimeUnit.MILLISECONDS, Schedulers.single(), 10, new Supplier>() /* NFI */ { int count; @Override public Collection get() throws Exception { @@ -808,7 +808,7 @@ public Collection get() throws Exception { @Test public void supplierThrows6() { Observable.never() - .buffer(2, 1, TimeUnit.MILLISECONDS, Schedulers.single(), new Supplier>() { + .buffer(2, 1, TimeUnit.MILLISECONDS, Schedulers.single(), new Supplier>() /* NFI */ { int count; @Override public Collection get() throws Exception { @@ -827,7 +827,7 @@ public Collection get() throws Exception { @Test public void supplierReturnsNull() { Observable.never() - .buffer(1, TimeUnit.MILLISECONDS, Schedulers.single(), Integer.MAX_VALUE, new Supplier>() { + .buffer(1, TimeUnit.MILLISECONDS, Schedulers.single(), Integer.MAX_VALUE, new Supplier>() /* NFI */ { int count; @Override public Collection get() throws Exception { @@ -846,7 +846,7 @@ public Collection get() throws Exception { @Test public void supplierReturnsNull2() { Observable.never() - .buffer(1, TimeUnit.MILLISECONDS, Schedulers.single(), 10, new Supplier>() { + .buffer(1, TimeUnit.MILLISECONDS, Schedulers.single(), 10, new Supplier>() /* NFI */ { int count; @Override public Collection get() throws Exception { @@ -865,7 +865,7 @@ public Collection get() throws Exception { @Test public void supplierReturnsNull3() { Observable.never() - .buffer(2, 1, TimeUnit.MILLISECONDS, Schedulers.single(), new Supplier>() { + .buffer(2, 1, TimeUnit.MILLISECONDS, Schedulers.single(), new Supplier>() /* NFI */ { int count; @Override public Collection get() throws Exception { @@ -914,7 +914,7 @@ public void restartTimer() { @Test public void bufferSupplierCrash2() { Observable.range(1, 2) - .buffer(1, new Supplier>() { + .buffer(1, new Supplier>() /* NFI */ { int calls; @Override public List get() throws Exception { @@ -931,7 +931,7 @@ public List get() throws Exception { @Test public void bufferSkipSupplierCrash2() { Observable.range(1, 2) - .buffer(2, 1, new Supplier>() { + .buffer(2, 1, new Supplier>() /* NFI */ { int calls; @Override public List get() throws Exception { @@ -1022,7 +1022,7 @@ public void bufferTimedExactSupplierCrash() { PublishSubject ps = PublishSubject.create(); TestObserver> to = ps - .buffer(1, TimeUnit.MILLISECONDS, scheduler, 1, new Supplier>() { + .buffer(1, TimeUnit.MILLISECONDS, scheduler, 1, new Supplier>() /* NFI */ { int calls; @Override public List get() throws Exception { @@ -1200,7 +1200,7 @@ public void openClosemainError() { public void openClosebadSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { Disposable bs1 = Disposable.empty(); @@ -1317,7 +1317,7 @@ public void openCloseBadOpen() { List errors = TestHelper.trackPluginErrors(); try { Observable.never() - .buffer(new Observable() { + .buffer(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { @@ -1361,7 +1361,7 @@ public void openCloseBadClose() { try { Observable.never() .buffer(Observable.just(1).concatWith(Observable.never()), - Functions.justFunction(new Observable() { + Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { @@ -1411,7 +1411,7 @@ public void bufferExactBoundarySecondBufferCrash() { PublishSubject ps = PublishSubject.create(); PublishSubject b = PublishSubject.create(); - TestObserver> to = ps.buffer(b, new Supplier>() { + TestObserver> to = ps.buffer(b, new Supplier>() /* NFI */ { int calls; @Override public List get() throws Exception { @@ -1429,7 +1429,7 @@ public List get() throws Exception { @Test public void bufferExactBoundaryBadSource() { - Observable ps = new Observable() { + Observable ps = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -1440,7 +1440,7 @@ protected void subscribeActual(Observer observer) { }; final AtomicReference> ref = new AtomicReference<>(); - Observable b = new Observable() { + Observable b = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -1540,7 +1540,7 @@ public void timedSkipCancelWhenSecondBuffer() { @SuppressWarnings("resource") BufferSkipBoundedObserver> sub = new BufferSkipBoundedObserver<>( - to, new Supplier>() { + to, new Supplier>() /* NFI */ { int calls; @Override diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCollectTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCollectTest.java index 03eb247f7f..a3bad258e5 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCollectTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCollectTest.java @@ -100,7 +100,7 @@ public void collectorFailureDoesNotResultInErrorAndCompletedEmissionsObservable( public void collectorFailureDoesNotResultInErrorAndOnNextEmissionsObservable() { final RuntimeException e = new RuntimeException(); final AtomicBoolean added = new AtomicBoolean(); - BiConsumer throwOnFirstOnly = new BiConsumer() { + BiConsumer throwOnFirstOnly = new BiConsumer() /* NFI */ { boolean once = true; @@ -199,7 +199,7 @@ public void collectorFailureDoesNotResultInErrorAndCompletedEmissions() { public void collectorFailureDoesNotResultInErrorAndOnNextEmissions() { final RuntimeException e = new RuntimeException(); final AtomicBoolean added = new AtomicBoolean(); - BiConsumer throwOnFirstOnly = new BiConsumer() { + BiConsumer throwOnFirstOnly = new BiConsumer() /* NFI */ { boolean once = true; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCombineLatestTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCombineLatestTest.java index 007d4ea640..2cb20f6e5e 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCombineLatestTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCombineLatestTest.java @@ -449,7 +449,7 @@ public void oneToNSourcesScheduled() throws InterruptedException { final CountDownLatch cdl = new CountDownLatch(1); - Observer> observer = new DefaultObserver>() { + Observer> observer = new DefaultObserver>() /* NFI */ { @Override public void onNext(List t) { @@ -943,7 +943,7 @@ public void eagerDispose() { final PublishSubject ps1 = PublishSubject.create(); final PublishSubject ps2 = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -1015,7 +1015,7 @@ public void onErrorDisposeDelayErrorRace() throws Throwable { TestObserverEx to = new TestObserverEx<>(); AtomicReference> ref = new AtomicReference<>(); - Observable o = new Observable() { + Observable o = new Observable() /* NFI */ { @Override public void subscribeActual(Observer observer) { ref.set(observer); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapCompletableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapCompletableTest.java index 1183a12e3e..84e64994ca 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapCompletableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapCompletableTest.java @@ -83,7 +83,7 @@ public void innerError() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -160,7 +160,7 @@ public void concatReportsDisposedOnComplete() { Observable.just(1) .hide() .concatMapCompletable(completableComplete()) - .subscribe(new CompletableObserver() { + .subscribe(new CompletableObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -186,7 +186,7 @@ public void concatReportsDisposedOnError() { Observable.just(1) .hide() .concatMapCompletable(completableError()) - .subscribe(new CompletableObserver() { + .subscribe(new CompletableObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapEagerTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapEagerTest.java index 86aa02bbc1..3350a25e86 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapEagerTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapEagerTest.java @@ -585,7 +585,7 @@ public void innerErrorAfterPoll() { final UnicastSubject us = UnicastSubject.create(); us.onNext(1); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapSchedulerTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapSchedulerTest.java index e10d713f0c..03d6b2715e 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapSchedulerTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapSchedulerTest.java @@ -235,7 +235,8 @@ public void issue2890NoStackoverflow() throws InterruptedException, TimeoutExcep int n = 5000; final AtomicInteger counter = new AtomicInteger(); - Observable.range(1, n).concatMap(func, 2, ImmediateThinScheduler.INSTANCE).subscribe(new DefaultObserver() { + Observable.range(1, n) + .concatMap(func, 2, ImmediateThinScheduler.INSTANCE).subscribe(new DefaultObserver() /* NFI */ { @Override public void onNext(Integer t) { // Consume after sleep for 1 ms @@ -470,7 +471,7 @@ public void doubleOnSubscribe() { public void immediateInnerNextOuterError() { final PublishSubject ps = PublishSubject.create(); - final TestObserverEx to = new TestObserverEx() { + final TestObserverEx to = new TestObserverEx() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -494,7 +495,7 @@ public void onNext(Integer t) { public void immediateInnerNextOuterError2() { final PublishSubject ps = PublishSubject.create(); - final TestObserverEx to = new TestObserverEx() { + final TestObserverEx to = new TestObserverEx() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -539,7 +540,8 @@ public void badSource() { public void badInnerSource() { @SuppressWarnings("rawtypes") final Observer[] ts0 = { null }; - TestObserverEx to = Observable.just(1).hide().concatMap(Functions.justFunction(new Observable() { + TestObserverEx to = Observable.just(1).hide() + .concatMap(Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer o) { ts0[0] = o; @@ -565,7 +567,8 @@ protected void subscribeActual(Observer o) { public void badInnerSourceDelayError() { @SuppressWarnings("rawtypes") final Observer[] ts0 = { null }; - TestObserverEx to = Observable.just(1).hide().concatMapDelayError(Functions.justFunction(new Observable() { + TestObserverEx to = Observable.just(1).hide() + .concatMapDelayError(Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer o) { ts0[0] = o; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapTest.java index affa5ae58d..d419367325 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatMapTest.java @@ -105,7 +105,7 @@ public void innerErrorDelayError2() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -131,7 +131,7 @@ protected void subscribeActual(Observer observer) { public void badSourceDelayError() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -249,7 +249,7 @@ public void badInnerDelayError() { try { Observable.just(1).hide() - .concatMapDelayError((Function>) _ -> new Observable() { + .concatMapDelayError((Function>) _ -> new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { o[0] = observer; @@ -275,7 +275,7 @@ public void concatReportsDisposedOnComplete() { Observable.fromArray(Observable.just(1), Observable.just(2)) .hide() .concatMap(Functions.>identity()) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -305,7 +305,7 @@ public void concatReportsDisposedOnError() { Observable.fromArray(Observable.just(1), Observable.error(new TestException())) .hide() .concatMap(Functions.>identity()) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -335,7 +335,7 @@ public void reentrantNoOverflow() { final PublishSubject ps = PublishSubject.create(); TestObserver to = ps.concatMap((Function>) v -> Observable.just(v + 1), 1) - .subscribeWith(new TestObserver() { + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -365,7 +365,7 @@ public void reentrantNoOverflowHidden() { final PublishSubject ps = PublishSubject.create(); TestObserver to = ps.concatMap((Function>) v -> Observable.just(v + 1).hide(), 1) - .subscribeWith(new TestObserver() { + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatTest.java index 8555a5608f..7f96f13e97 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatTest.java @@ -453,7 +453,7 @@ public void concatUnsubscribeConcurrent() { static class TestObservable implements ObservableSource { - private final Disposable upstream = new Disposable() { + private final Disposable upstream = new Disposable() /* NFI */ { @Override public void dispose() { subscribed = false; @@ -663,7 +663,7 @@ public void issue2890NoStackoverflow() throws InterruptedException, TimeoutExcep final AtomicInteger counter = new AtomicInteger(); Observable.range(1, n) - .concatMap(func).subscribe(new DefaultObserver() { + .concatMap(func).subscribe(new DefaultObserver() /* NFI */ { @Override public void onNext(Integer t) { // Consume after sleep for 1 ms @@ -975,7 +975,7 @@ public void concatReportsDisposedOnComplete() { final Disposable[] disposable = { null }; Observable.concatArray(Observable.just(1), Observable.just(2)) - .subscribe(new Observer<>() { + .subscribe(new Observer<>() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -1005,7 +1005,7 @@ public void concatReportsDisposedOnCompleteDelayError() { Observable.concatArray( ObservableConcatConfig.DELAY_ERROR, Observable.just(1), Observable.just(2)) - .subscribe(new Observer<>() { + .subscribe(new Observer<>() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -1033,7 +1033,7 @@ public void concatReportsDisposedOnError() { final Disposable[] disposable = { null }; Observable.concatArray(Observable.just(1), Observable.error(new TestException())) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -1063,7 +1063,7 @@ public void concatReportsDisposedOnErrorDelayError() { Observable.concatArray( ObservableConcatConfig.DELAY_ERROR, Observable.just(1), Observable.error(new TestException())) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithCompletableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithCompletableTest.java index 666c4fa8c9..adea898aeb 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithCompletableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithCompletableTest.java @@ -87,7 +87,7 @@ public void cancelOther() { @Test public void badSource() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { Disposable bs1 = Disposable.empty(); @@ -108,7 +108,7 @@ protected void subscribeActual(Observer observer) { @Test public void consumerDisposed() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { Disposable bs1 = Disposable.empty(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithMaybeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithMaybeTest.java index 450a807f76..9b02c50ddf 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithMaybeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithMaybeTest.java @@ -98,7 +98,7 @@ public void cancelOther() { @Test public void consumerDisposed() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { Disposable bs1 = Disposable.empty(); @@ -119,7 +119,7 @@ protected void subscribeActual(Observer observer) { @Test public void badSource() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { Disposable bs1 = Disposable.empty(); @@ -140,7 +140,7 @@ protected void subscribeActual(Observer observer) { @Test public void badSource2() { - Flowable.empty().concatWith(new Maybe() { + Flowable.empty().concatWith(new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { Disposable bs1 = Disposable.empty(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithSingleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithSingleTest.java index 5f4b1bdfee..a022ae8ec6 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithSingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableConcatWithSingleTest.java @@ -87,7 +87,7 @@ public void cancelOther() { @Test public void consumerDisposed() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { Disposable bs1 = Disposable.empty(); @@ -108,7 +108,7 @@ protected void subscribeActual(Observer observer) { @Test public void badSource() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { Disposable bs1 = Disposable.empty(); @@ -129,7 +129,7 @@ protected void subscribeActual(Observer observer) { @Test public void badSource2() { - Flowable.empty().concatWith(new Single() { + Flowable.empty().concatWith(new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { Disposable bs1 = Disposable.empty(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCreateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCreateTest.java index 8ba48f41e7..30912a01c8 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCreateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableCreateTest.java @@ -279,7 +279,7 @@ public void onErrorCrash() { } assertTrue(d.isDisposed()); }) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { } @@ -312,7 +312,7 @@ public void onCompleteCrash() { } assertTrue(d.isDisposed()); }) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { } diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDebounceTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDebounceTest.java index d3a4e9e720..5258d8503b 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDebounceTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDebounceTest.java @@ -347,7 +347,7 @@ public void dispose() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -405,7 +405,7 @@ public void disposeInOnNext() { public void disposedInOnComplete() { final TestObserver to = new TestObserver<>(); - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -427,7 +427,7 @@ public void emitLate() { if (o != 1) { return Observable.never(); } - return new Observable() { + return new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -452,7 +452,7 @@ public void timedDoubleOnSubscribe() { public void timedDisposedIgnoredBySource() { final TestObserver to = new TestObserver<>(); - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual( Observer observer) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDelayTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDelayTest.java index 8759af3c8c..629e10970f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDelayTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDelayTest.java @@ -551,7 +551,7 @@ public void backpressureWithTimedDelay() { Observable.range(1, Flowable.bufferSize() * 2) .delay(100, TimeUnit.MILLISECONDS) .observeOn(Schedulers.computation()) - .map(new Function() { + .map(new Function() /* NFI */ { int c; @@ -580,7 +580,7 @@ public void backpressureWithSubscriptionTimedDelay() { .delaySubscription(100, TimeUnit.MILLISECONDS) .delay(100, TimeUnit.MILLISECONDS) .observeOn(Schedulers.computation()) - .map(new Function() { + .map(new Function() /* NFI */ { int c; @@ -608,7 +608,7 @@ public void backpressureWithSelectorDelay() { Observable.range(1, Flowable.bufferSize() * 2) .delay((Function>) _ -> Observable.timer(100, TimeUnit.MILLISECONDS)) .observeOn(Schedulers.computation()) - .map(new Function() { + .map(new Function() /* NFI */ { int c; @@ -637,7 +637,7 @@ public void backpressureWithSelectorDelayAndSubscriptionDelay() { .delay(Observable.timer(500, TimeUnit.MILLISECONDS) , (Function>) _ -> Observable.timer(100, TimeUnit.MILLISECONDS)) .observeOn(Schedulers.computation()) - .map(new Function() { + .map(new Function() /* NFI */ { int c; @@ -794,7 +794,7 @@ public void onCompleteFinal() { Observable.empty() .delay(1, TimeUnit.MILLISECONDS, scheduler) - .subscribe(new DisposableObserver() { + .subscribe(new DisposableObserver() /* NFI */ { @Override public void onNext(Object value) { } @@ -823,7 +823,7 @@ public void onErrorFinal() { Observable.error(new TestException()) .delay(1, TimeUnit.MILLISECONDS, scheduler) - .subscribe(new DisposableObserver() { + .subscribe(new DisposableObserver() /* NFI */ { @Override public void onNext(Object value) { } diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDematerializeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDematerializeTest.java index ec1bbb9fb6..a1540cbd57 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDematerializeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDematerializeTest.java @@ -187,7 +187,7 @@ public void doubleOnSubscribe() { public void eventsAfterDematerializedTerminal() { List errors = TestHelper.trackPluginErrors(); try { - new Observable>() { + new Observable>() /* NFI */ { @Override protected void subscribeActual(Observer> observer) { observer.onSubscribe(Disposable.empty()); @@ -211,7 +211,7 @@ protected void subscribeActual(Observer> observer) @Test @SuppressWarnings("unchecked") public void nonNotificationInstanceAfterDispose() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDistinctTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDistinctTest.java index ca7aafd46e..e01f3779e6 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDistinctTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDistinctTest.java @@ -143,7 +143,7 @@ public void fusedAsync() { public void fusedClear() { Observable.just(1, 1, 2, 1, 3, 2, 4, 5, 4) .distinct() - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { QueueDisposable qd = (QueueDisposable)d; @@ -192,7 +192,7 @@ public void collectionSupplierIsNull() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoAfterNextTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoAfterNextTest.java index 097f882012..4592280392 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoAfterNextTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoAfterNextTest.java @@ -35,7 +35,7 @@ public class ObservableDoAfterNextTest extends RxJavaTest { final Consumer afterNext = e -> values.add(-e); - final TestObserver to = new TestObserver() { + final TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoFinallyTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoFinallyTest.java index b0c0ce72cb..73d47d750d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoFinallyTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoFinallyTest.java @@ -333,7 +333,7 @@ public void actionThrowsConditional() { public void clearIsEmpty() { Observable.range(1, 5) .doFinally(this) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -380,7 +380,7 @@ public void clearIsEmptyConditional() { Observable.range(1, 5) .doFinally(this) .filter(Functions.alwaysTrue()) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoOnEachTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoOnEachTest.java index 9552abc96f..f80747b672 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoOnEachTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoOnEachTest.java @@ -142,37 +142,6 @@ public void issue1451Case2() { assertEquals(expectedCount, count.get()); } - // FIXME crashing ObservableSource can't propagate to an Observer -// @Test -// public void testFatalError() { -// try { -// Observable.just(1, 2, 3) -// .flatMap(new Function>() { -// @Override -// public Observable apply(Integer integer) { -// return Observable.create(new ObservableSource() { -// @Override -// public void accept(Observer o) { -// throw new NullPointerException("Test NPE"); -// } -// }); -// } -// }) -// .doOnNext(new Consumer() { -// @Override -// public void accept(Object o) { -// System.out.println("Won't come here"); -// } -// }) -// .subscribe(); -// fail("should have thrown an exception"); -// } catch (OnErrorNotImplementedException e) { -// assertTrue(e.getCause() instanceof NullPointerException); -// assertEquals(e.getCause().getMessage(), "Test NPE"); -// System.out.println("Received exception: " + e); -// } -// } - @Test public void onErrorThrows() { TestObserverEx to = new TestObserverEx<>(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoOnSubscribeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoOnSubscribeTest.java index 1115617dcb..c3fef7242a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoOnSubscribeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableDoOnSubscribeTest.java @@ -82,7 +82,7 @@ public void onSubscribeCrash() { try { final Disposable bs = Disposable.empty(); - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(bs); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableElementAtTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableElementAtTest.java index 152b1a73ed..4f274c1e86 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableElementAtTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableElementAtTest.java @@ -214,7 +214,7 @@ public void errorObservable() { public void badSourceObservable() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -240,7 +240,7 @@ protected void subscribeActual(Observer observer) { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -265,7 +265,7 @@ protected void subscribeActual(Observer observer) { public void badSource2() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapCompletableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapCompletableTest.java index ea6af9b005..2456c4c0d1 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapCompletableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapCompletableTest.java @@ -271,7 +271,7 @@ public void disposed() { @Test public void innerObserver() { Observable.range(1, 3) - .flatMapCompletable(_ -> new Completable() { + .flatMapCompletable(_ -> new Completable() /* NFI */ { @Override protected void subscribeActual(CompletableObserver observer) { observer.onSubscribe(Disposable.empty()); @@ -296,7 +296,7 @@ public void fusedInternalsObservable() { Observable.range(1, 10) .flatMapCompletable(_ -> Completable.complete()) .toObservable() - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { QueueDisposable qd = (QueueDisposable)d; @@ -326,7 +326,7 @@ public void onComplete() { @Test public void innerObserverObservable() { Observable.range(1, 3) - .flatMapCompletable(_ -> new Completable() { + .flatMapCompletable(_ -> new Completable() /* NFI */ { @Override protected void subscribeActual(CompletableObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapMaybeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapMaybeTest.java index 68f57c8376..9554ad713d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapMaybeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapMaybeTest.java @@ -245,7 +245,7 @@ public void doubleOnSubscribe() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -268,7 +268,7 @@ public void badInnerSource() { List errors = TestHelper.trackPluginErrors(); try { Observable.just(1) - .flatMapMaybe(Functions.justFunction(new Maybe() { + .flatMapMaybe(Functions.justFunction(new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); @@ -290,7 +290,7 @@ public void emissionQueueTrigger() { final PublishSubject ps1 = PublishSubject.create(); final PublishSubject ps2 = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -317,7 +317,7 @@ public void emissionQueueTrigger2() { final PublishSubject ps2 = PublishSubject.create(); final PublishSubject ps3 = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -344,7 +344,7 @@ public void onNext(Integer t) { public void disposeInner() { final TestObserver to = new TestObserver<>(); - Observable.just(1).flatMapMaybe((Function>) _ -> new Maybe() { + Observable.just(1).flatMapMaybe((Function>) _ -> new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapSingleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapSingleTest.java index c6252d3d68..0af8888b6b 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapSingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapSingleTest.java @@ -207,7 +207,7 @@ public void doubleOnSubscribe() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -230,7 +230,7 @@ public void badInnerSource() { List errors = TestHelper.trackPluginErrors(); try { Observable.just(1) - .flatMapSingle(Functions.justFunction(new Single() { + .flatMapSingle(Functions.justFunction(new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { observer.onSubscribe(Disposable.empty()); @@ -252,7 +252,7 @@ public void emissionQueueTrigger() { final PublishSubject ps1 = PublishSubject.create(); final PublishSubject ps2 = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -277,7 +277,7 @@ public void onNext(Integer t) { public void disposeInner() { final TestObserver to = new TestObserver<>(); - Observable.just(1).flatMapSingle((Function>) _ -> new Single() { + Observable.just(1).flatMapSingle((Function>) _ -> new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapTest.java index 38d7a4379c..039225a8fe 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlatMapTest.java @@ -366,7 +366,7 @@ public void flatMapRangeMixedAsyncLoop() { } TestObserverEx to = new TestObserverEx<>(); Observable.range(0, 1000) - .flatMap(new Function>() { + .flatMap(new Function>() /* NFI */ { final Random rnd = new Random(); @Override public Observable apply(Integer t) { @@ -490,7 +490,7 @@ public void mergeScalarError() { public void scalarReentrant() { final PublishSubject> ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -513,7 +513,7 @@ public void onNext(Integer t) { public void scalarReentrant2() { final PublishSubject> ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -666,7 +666,8 @@ public void failingFusedInnerCancelsSource() { final AtomicInteger counter = new AtomicInteger(); Observable.range(1, 5) .doOnNext(_ -> counter.getAndIncrement()) - .flatMap((Function>) _ -> Observable.fromIterable(() -> new Iterator() { + .flatMap((Function>) _ -> + Observable.fromIterable(() -> new Iterator() /* NFI */ { @Override public boolean hasNext() { return true; @@ -695,7 +696,7 @@ public void scalarQueueNoOverflow() { final PublishSubject ps = PublishSubject.create(); TestObserver to = ps.flatMap((Function>) v -> Observable.just(v + 1), 1) - .subscribeWith(new TestObserver() { + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -725,7 +726,7 @@ public void scalarQueueNoOverflowHidden() { final PublishSubject ps = PublishSubject.create(); TestObserver to = ps.flatMap((Function>) v -> Observable.just(v + 1).hide(), 1) - .subscribeWith(new TestObserver() { + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -858,7 +859,7 @@ public void innerErrorsMainCancelled() { @Test public void signalsAfterMapperCrash() throws Throwable { TestHelper.withErrorTracking(errors -> { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(@NonNull Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlattenIterableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlattenIterableTest.java index fe08f0fa52..cf9876e971 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlattenIterableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFlattenIterableTest.java @@ -44,7 +44,7 @@ public void failingInnerCancelsSource() { final AtomicInteger counter = new AtomicInteger(); Observable.range(1, 5) .doOnNext(_ -> counter.getAndIncrement()) - .flatMapIterable((Function>) _ -> (Iterable) () -> new Iterator() { + .flatMapIterable((Function>) _ -> (Iterable) () -> new Iterator() /* NFI */ { @Override public boolean hasNext() { return true; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFromIterableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFromIterableTest.java index f753b57a4e..61de80404f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFromIterableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableFromIterableTest.java @@ -57,7 +57,7 @@ public void listIterable() { */ @Test public void rawIterable() { - Iterable it = () -> new Iterator() { + Iterable it = () -> new Iterator() /* NFI */ { int i; @@ -134,7 +134,7 @@ public void subscribeMultipleTimes() { @Test public void doesNotCallIteratorHasNextMoreThanRequiredWithBackpressure() { final AtomicBoolean called = new AtomicBoolean(false); - Iterable iterable = () -> new Iterator() { + Iterable iterable = () -> new Iterator() /* NFI */ { int count = 1; @@ -165,7 +165,7 @@ public Integer next() { @Test public void doesNotCallIteratorHasNextMoreThanRequiredFastPath() { final AtomicBoolean called = new AtomicBoolean(false); - Iterable iterable = () -> new Iterator() { + Iterable iterable = () -> new Iterator() /* NFI */ { @Override public void remove() { @@ -189,7 +189,7 @@ public Integer next() { } }; - Observable.fromIterable(iterable).subscribe(new DefaultObserver() { + Observable.fromIterable(iterable).subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -240,7 +240,7 @@ public void hasNext2Throws() { public void hasNextCancels() { final TestObserver to = new TestObserver<>(); - Observable.fromIterable(() -> new Iterator() { + Observable.fromIterable(() -> new Iterator() /* NFI */ { int count; @Override @@ -282,7 +282,7 @@ public void fusionRejected() { @Test public void fusionClear() { Observable.fromIterable(Arrays.asList(1, 2, 3)) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @SuppressWarnings("unchecked") @@ -322,7 +322,7 @@ public void onComplete() { public void disposeAfterHasNext() { TestObserver to = new TestObserver<>(); - Observable.fromIterable(() -> new Iterator() { + Observable.fromIterable(() -> new Iterator() /* NFI */ { int count; @Override public boolean hasNext() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableGroupByTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableGroupByTest.java index 04dcb1a849..447df2297c 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableGroupByTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableGroupByTest.java @@ -106,7 +106,7 @@ public void error() { grouped.flatMap((Function, Observable>) o -> { groupCounter.incrementAndGet(); return o.map(v -> "Event => key: " + o.getKey() + " value: " + v); - }).subscribe(new DefaultObserver() { + }).subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -180,7 +180,7 @@ public void groupedEventStream() throws Throwable { return eventGroupedObservable.map(event -> "Source: " + event.source + " Message: " + event.message); - }).subscribe(new DefaultObserver() { + }).subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -246,7 +246,7 @@ private void doTestUnsubscribeOnNestedTakeAndAsyncInfiniteStream(Observable "testUnsubscribe => Source: " + event.source + " Message: " + event.message); - }).subscribe(new DefaultObserver() { + }).subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -344,7 +344,7 @@ public void staggeredCompletion() throws InterruptedException { return group; } }) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -378,7 +378,7 @@ public void completionIfInnerNotSubscribed() throws InterruptedException { final AtomicInteger eventCounter = new AtomicInteger(); Observable.range(0, 100) .groupBy(i -> i % 2) - .subscribe(new DefaultObserver>() { + .subscribe(new DefaultObserver>() /* NFI */ { @Override public void onComplete() { @@ -705,7 +705,7 @@ public void normalBehavior() { Observable m = source.groupBy(keysel, valuesel) .flatMap((Function, Observable>) g -> { System.out.println("-----------> NEXT: " + g.getKey()); - return g.take(2).map(new Function() { + return g.take(2).map(new Function() /* NFI */ { int count; @@ -813,7 +813,7 @@ public void groupByBackpressure3() throws InterruptedException { Observable.range(1, 4000).groupBy(IS_EVEN2) .flatMap(g -> g.doOnComplete(() -> System.out.println("//////////////////// COMPLETED-A")) - .observeOn(Schedulers.computation()).map(new Function() { + .observeOn(Schedulers.computation()).map(new Function() /* NFI */ { int c; @@ -896,7 +896,7 @@ public void groupByShouldPropagateError() { final TestObserverEx inner2 = new TestObserverEx<>(); final TestObserverEx> outer - = new TestObserverEx<>(new DefaultObserver>() { + = new TestObserverEx<>(new DefaultObserver>() /* NFI */ { @Override public void onComplete() { @@ -962,7 +962,7 @@ public void dispose() { public void reentrantComplete() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -984,7 +984,7 @@ public void onNext(Integer t) { public void reentrantCompleteCancel() { final PublishSubject ps = PublishSubject.create(); - TestObserverEx to = new TestObserverEx() { + TestObserverEx to = new TestObserverEx() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableGroupJoinTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableGroupJoinTest.java index 38b2cdb349..a3ba8156ee 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableGroupJoinTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableGroupJoinTest.java @@ -143,7 +143,7 @@ public void normal1() { PPF::new); q.subscribe( - new Observer() { + new Observer() /* NFI */ { @Override public void onNext(final PPF ppf) { ppf.fruits.filter(t1 -> ppf.person.id == t1.personId).subscribe(t1 -> observer.onNext(Arrays.asList(ppf.person.name, t1.fruit))); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableJoinTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableJoinTest.java index 73bd79b2d1..77d21bf0c5 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableJoinTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableJoinTest.java @@ -345,7 +345,7 @@ public void resultSelectorThrows2() { public void badOuterSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -376,7 +376,7 @@ public void badEndSource() { TestObserverEx to = Observable.just(1) .join(Observable.just(2), Functions.justFunction(Observable.never()), - Functions.justFunction(new Observable() { + Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { o[0] = observer; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMapNotificationTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMapNotificationTest.java index 6195f88acb..d78d59396d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMapNotificationTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMapNotificationTest.java @@ -42,7 +42,7 @@ public void just() { @Test public void dispose() { - TestHelper.checkDisposed(new Observable() { + TestHelper.checkDisposed(new Observable() /* NFI */ { @SuppressWarnings({ "rawtypes", "unchecked" }) @Override protected void subscribeActual(Observer observer) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMapTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMapTest.java index 8b0c31d77a..7c4e0ff48f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMapTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMapTest.java @@ -182,59 +182,6 @@ public void mapWithErrorInFunc() { Observable.range(1, 1).lastElement().map(i -> i / 0).blockingGet(); } - // FIXME RS subscribers can't throw -// @Test(expected = OnErrorNotImplementedException.class) -// public void verifyExceptionIsThrownIfThereIsNoExceptionHandler() { -// -// ObservableSource creator = new ObservableSource() { -// -// @Override -// public void subscribeActual(Observer observer) { -// observer.onSubscribe(EmptyDisposable.INSTANCE); -// observer.onNext("a"); -// observer.onNext("b"); -// observer.onNext("c"); -// observer.onComplete(); -// } -// }; -// -// Function> manyMapper = new Function>() { -// -// @Override -// public Observable apply(Object object) { -// return Observable.just(object); -// } -// }; -// -// Function mapper = new Function() { -// private int count = 0; -// -// @Override -// public Object apply(Object object) { -// ++count; -// if (count > 2) { -// throw new RuntimeException(); -// } -// return object; -// } -// }; -// -// Consumer onNext = new Consumer() { -// -// @Override -// public void accept(Object object) { -// System.out.println(object.toString()); -// } -// }; -// -// try { -// Observable.unsafeCreate(creator).flatMap(manyMapper).map(mapper).subscribe(onNext); -// } catch (RuntimeException e) { -// e.printStackTrace(); -// throw e; -// } -// } - private static Map getMap(String prefix) { Map m = new HashMap<>(); m.put("firstName", prefix + "First"); @@ -242,27 +189,6 @@ private static Map getMap(String prefix) { return m; } - // FIXME RS subscribers can't throw -// @Test(expected = OnErrorNotImplementedException.class) -// public void testShouldNotSwallowOnErrorNotImplementedException() { -// Observable.just("a", "b").flatMap(new Function>() { -// @Override -// public Observable apply(String s) { -// return Observable.just(s + "1", s + "2"); -// } -// }).flatMap(new Function>() { -// @Override -// public Observable apply(String s) { -// return Observable.error(new Exception("test")); -// } -// }).forEach(new Consumer() { -// @Override -// public void accept(String s) { -// System.out.println(s); -// } -// }); -// } - @Test public void dispose() { TestHelper.checkDisposed(Observable.range(1, 5).map(Functions.identity())); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeDelayErrorTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeDelayErrorTest.java index 69148179ec..3353a41dcc 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeDelayErrorTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeDelayErrorTest.java @@ -290,7 +290,8 @@ public void synchronousError() { final Observable> o1 = Observable.error(new RuntimeException("unit test")); final CountDownLatch latch = new CountDownLatch(1); - Observable.merge(o1, ObservableMergeConfig.DELAY_ERROR).subscribe(new DefaultObserver() { + Observable.merge(o1, ObservableMergeConfig.DELAY_ERROR) + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { fail("Expected onError path"); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeTest.java index 938f584627..1dc2885577 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeTest.java @@ -203,7 +203,7 @@ public void synchronizationOfMultipleSequences() throws Throwable { final AtomicInteger totalCounter = new AtomicInteger(); Observable m = Observable.mergeArray(Observable.unsafeCreate(o1), Observable.unsafeCreate(o2)); - m.subscribe(new DefaultObserver() { + m.subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -460,7 +460,7 @@ public void earlyUnsubscribe() { private Observable createObservableOf5IntervalsOf1SecondIncrementsWithSubscriptionHook(final Scheduler scheduler, final AtomicBoolean unsubscribed) { return Observable.unsafeCreate(child -> Observable.interval(1, TimeUnit.SECONDS, scheduler) .take(5) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(final Disposable d) { child.onSubscribe(Disposable.fromRunnable(() -> { @@ -596,7 +596,7 @@ public void backpressureUpstream() throws InterruptedException { final AtomicInteger generated2 = new AtomicInteger(); Observable o2 = createInfiniteObservable(generated2).subscribeOn(Schedulers.computation()); - TestObserverEx testObserver = new TestObserverEx() { + TestObserverEx testObserver = new TestObserverEx() /* NFI */ { @Override public void onNext(Integer t) { System.err.println("TestObserver received => " + t + " on thread " + Thread.currentThread()); @@ -636,7 +636,7 @@ public void backpressureUpstream2() throws InterruptedException { final AtomicInteger generated1 = new AtomicInteger(); Observable o1 = createInfiniteObservable(generated1).subscribeOn(Schedulers.computation()); - TestObserverEx testObserver = new TestObserverEx() { + TestObserverEx testObserver = new TestObserverEx() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -675,7 +675,7 @@ public void backpressureDownstreamWithConcurrentStreams() throws InterruptedExce final AtomicInteger generated2 = new AtomicInteger(); Observable o2 = createInfiniteObservable(generated2).subscribeOn(Schedulers.computation()); - TestObserverEx to = new TestObserverEx() { + TestObserverEx to = new TestObserverEx() /* NFI */ { @Override public void onNext(Integer t) { if (t < 100) { @@ -725,7 +725,7 @@ public void backpressureBothUpstreamAndDownstreamWithRegularObservables() throws final AtomicInteger generated1 = new AtomicInteger(); Observable> o1 = createInfiniteObservable(generated1).map(_ -> Observable.just(1, 2, 3)); - TestObserverEx to = new TestObserverEx() { + TestObserverEx to = new TestObserverEx() /* NFI */ { int i; @Override @@ -870,7 +870,7 @@ private Observable mergeNSyncStreamsOfN(final int outerSize, final int } private Observable createInfiniteObservable(final AtomicInteger generated) { - Observable o = Observable.fromIterable(() -> new Iterator() { + Observable o = Observable.fromIterable(() -> new Iterator() /* NFI */ { @Override public void remove() { @@ -946,7 +946,7 @@ public void fastMergeHiddenScalar() { @Test public void slowMergeFullScalar() { for (final int req : new int[] { 16, 32, 64, 128, 256 }) { - TestObserverEx to = new TestObserverEx() { + TestObserverEx to = new TestObserverEx() /* NFI */ { int remaining = req; @Override @@ -964,7 +964,7 @@ public void onNext(Integer t) { @Test public void slowMergeHiddenScalar() { for (final int req : new int[] { 16, 32, 64, 128, 256 }) { - TestObserverEx to = new TestObserverEx() { + TestObserverEx to = new TestObserverEx() /* NFI */ { int remaining = req; @Override public void onNext(Integer t) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithCompletableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithCompletableTest.java index 354f8e81c9..681b0b021f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithCompletableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithCompletableTest.java @@ -106,7 +106,7 @@ public void completeRace() { @Test public void isDisposed() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithMaybeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithMaybeTest.java index a635c20b8c..7afe1b983b 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithMaybeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithMaybeTest.java @@ -124,7 +124,7 @@ public void onNextSlowPath() { final PublishSubject ps = PublishSubject.create(); final MaybeSubject cs = MaybeSubject.create(); - TestObserver to = ps.mergeWith(cs).subscribeWith(new TestObserver() { + TestObserver to = ps.mergeWith(cs).subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -148,7 +148,8 @@ public void onSuccessSlowPath() { final PublishSubject ps = PublishSubject.create(); final MaybeSubject cs = MaybeSubject.create(); - TestObserver to = ps.mergeWith(cs).subscribeWith(new TestObserver() { + TestObserver to = ps.mergeWith(cs) + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -171,7 +172,7 @@ public void onErrorMainOverflow() { List errors = TestHelper.trackPluginErrors(); try { final AtomicReference> observerRef = new AtomicReference<>(); - TestObserver to = new Observable() { + TestObserver to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -217,7 +218,7 @@ public void doubleOnSubscribeMain() { @Test public void isDisposed() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -239,7 +240,8 @@ public void onNextSlowPathCreateQueue() { final PublishSubject ps = PublishSubject.create(); final MaybeSubject cs = MaybeSubject.create(); - TestObserver to = ps.mergeWith(cs).subscribeWith(new TestObserver() { + TestObserver to = ps.mergeWith(cs) + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithSingleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithSingleTest.java index 76ee9b711f..c4dab7d1e1 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithSingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableMergeWithSingleTest.java @@ -116,7 +116,8 @@ public void onNextSlowPath() { final PublishSubject ps = PublishSubject.create(); final SingleSubject cs = SingleSubject.create(); - TestObserver to = ps.mergeWith(cs).subscribeWith(new TestObserver() { + TestObserver to = ps.mergeWith(cs) + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -140,7 +141,8 @@ public void onSuccessSlowPath() { final PublishSubject ps = PublishSubject.create(); final SingleSubject cs = SingleSubject.create(); - TestObserver to = ps.mergeWith(cs).subscribeWith(new TestObserver() { + TestObserver to = ps.mergeWith(cs) + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -163,7 +165,7 @@ public void onErrorMainOverflow() { List errors = TestHelper.trackPluginErrors(); try { final AtomicReference> observerRef = new AtomicReference<>(); - TestObserver to = new Observable() { + TestObserver to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -209,7 +211,7 @@ public void doubleOnSubscribeMain() { @Test public void isDisposed() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -231,7 +233,8 @@ public void onNextSlowPathCreateQueue() { final PublishSubject ps = PublishSubject.create(); final SingleSubject cs = SingleSubject.create(); - TestObserver to = ps.mergeWith(cs).subscribeWith(new TestObserver() { + TestObserver to = ps.mergeWith(cs) + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableObserveOnTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableObserveOnTest.java index a2e0a40b04..7dc6e6c96a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableObserveOnTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableObserveOnTest.java @@ -267,7 +267,9 @@ public void nonBlockingOuterWhileBlockingOnNext() throws InterruptedException { final CountDownLatch nextLatch = new CountDownLatch(1); final AtomicLong completeTime = new AtomicLong(); // use subscribeOn to make async, observeOn to move - Observable.range(1, 2).subscribeOn(Schedulers.newThread()).observeOn(Schedulers.newThread()).subscribe(new DefaultObserver() { + Observable.range(1, 2).subscribeOn(Schedulers.newThread()) + .observeOn(Schedulers.newThread()) + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -357,7 +359,7 @@ public void afterUnsubscribeCalledThenObserverOnNextNeverCalled() { @Test public void backpressureWithTakeBefore() { final AtomicInteger generated = new AtomicInteger(); - Observable o = Observable.fromIterable(() -> new Iterator() { + Observable o = Observable.fromIterable(() -> new Iterator() /* NFI */ { @Override public void remove() { @@ -430,7 +432,7 @@ public void badSource() { List errors = TestHelper.trackPluginErrors(); try { TestScheduler scheduler = new TestScheduler(); - TestObserver to = new Observable() { + TestObserver to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -574,7 +576,7 @@ public void outputFusedCancelReentrant() throws Exception { final CountDownLatch cdl = new CountDownLatch(1); us.observeOn(Schedulers.single()) - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { Disposable upstream; int count; @Override @@ -610,7 +612,7 @@ public void onComplete() { @Test public void nonFusedPollThrows() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -618,7 +620,7 @@ protected void subscribeActual(Observer observer) { @SuppressWarnings("unchecked") ObserveOnObserver oo = (ObserveOnObserver)observer; - oo.queue = new SimpleQueue() { + oo.queue = new SimpleQueue() /* NFI */ { @Override public boolean offer(Integer value) { @@ -663,7 +665,7 @@ public void outputFusedOneSignal() { bs.observeOn(ImmediateThinScheduler.INSTANCE) .concatMap((Function>) v -> Observable.just(v + 1)) - .subscribeWith(new TestObserver() { + .subscribeWith(new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorResumeNextTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorResumeNextTest.java index a50457cd2c..c4becba9e4 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorResumeNextTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorResumeNextTest.java @@ -197,7 +197,7 @@ public void backpressure() { Observable.range(0, 100000) .onErrorResumeNext((Function>) _ -> Observable.just(1)) .observeOn(Schedulers.computation()) - .map(new Function() { + .map(new Function() /* NFI */ { int c; @Override diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorResumeWithTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorResumeWithTest.java index 1ef30f6feb..a48c144ced 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorResumeWithTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorResumeWithTest.java @@ -142,7 +142,7 @@ public void backpressure() { Observable.range(0, 100000) .onErrorResumeWith(Observable.just(1)) .observeOn(Schedulers.computation()) - .map(new Function() { + .map(new Function() /* NFI */ { int c; @Override diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorReturnTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorReturnTest.java index 690266d67b..b877642a09 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorReturnTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableOnErrorReturnTest.java @@ -128,7 +128,7 @@ public void backpressure() { Observable.range(0, 100000) .onErrorReturn(_ -> 1) .observeOn(Schedulers.computation()) - .map(new Function() { + .map(new Function() /* NFI */ { int c; @Override diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservablePublishTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservablePublishTest.java index 48bb52c7e3..c8c25834cf 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservablePublishTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservablePublishTest.java @@ -82,7 +82,8 @@ public void backpressureFastSlow() { Observable fast = is.observeOn(Schedulers.computation()) .doOnComplete(() -> System.out.println("^^^^^^^^^^^^^ completed FAST")); - Observable slow = is.observeOn(Schedulers.computation()).map(new Function() { + Observable slow = is.observeOn(Schedulers.computation()) + .map(new Function() /* NFI */ { int c; @Override @@ -146,7 +147,7 @@ public void backpressureTwoConsumers() { final TestObserver to2 = new TestObserver<>(); - final TestObserver to1 = new TestObserver() { + final TestObserver to1 = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (values().size() == 2) { @@ -433,7 +434,7 @@ public void just() { ConnectableObservable co = ps.publish(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -471,7 +472,7 @@ public void nextCancelRace() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -565,7 +566,7 @@ public void selectorInnerError() { public void delayedUpstreamOnSubscribe() { final Observer[] sub = { null }; - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { sub[0] = observer; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRangeLongTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRangeLongTest.java index 0e67066e2e..8a27981837 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRangeLongTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRangeLongTest.java @@ -105,7 +105,7 @@ public void noBackpressure() { @Test public void emptyRangeSendsOnCompleteEagerlyWithRequestZero() { final AtomicBoolean completed = new AtomicBoolean(false); - Observable.rangeLong(1L, 0L).subscribe(new DefaultObserver() { + Observable.rangeLong(1L, 0L).subscribe(new DefaultObserver() /* NFI */ { @Override public void onStart() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRangeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRangeTest.java index f724f44a65..7a7cc464d9 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRangeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRangeTest.java @@ -106,7 +106,7 @@ public void noBackpressure() { @Test public void emptyRangeSendsOnCompleteEagerlyWithRequestZero() { final AtomicBoolean completed = new AtomicBoolean(false); - Observable.range(1, 0).subscribe(new DefaultObserver() { + Observable.range(1, 0).subscribe(new DefaultObserver() /* NFI */ { @Override public void onStart() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRedoTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRedoTest.java index 9cec9e2ec4..ca232ebc74 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRedoTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRedoTest.java @@ -27,7 +27,8 @@ public void redoCancel() { final TestObserver to = new TestObserver<>(); Observable.just(1) - .repeatWhen((Function, ObservableSource>) o -> o.map(new Function() { + .repeatWhen((Function, ObservableSource>) o -> + o.map(new Function() /* NFI */ { int count; @Override public Object apply(Object v) throws Exception { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReduceTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReduceTest.java index 2db10ae727..221595307f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReduceTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReduceTest.java @@ -215,7 +215,7 @@ public void reduceMaybeCheckDisposed() { public void reduceMaybeBadSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -248,7 +248,7 @@ public void seedDisposed() { public void seedBadSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRefCountTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRefCountTest.java index 8a99360105..ef8c4f8940 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRefCountTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRefCountTest.java @@ -497,7 +497,7 @@ public void disposed() { @Test public void noOpConnect() { final int[] calls = { 0 }; - Observable o = new ConnectableObservable() { + Observable o = new ConnectableObservable() /* NFI */ { @Override public void connect(Consumer connection) { calls[0]++; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReplayEagerTruncateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReplayEagerTruncateTest.java index 99a1042018..b03faacc8f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReplayEagerTruncateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReplayEagerTruncateTest.java @@ -648,7 +648,7 @@ public boolean isDisposed() { @Test public void boundedReplayBuffer() { - BoundedReplayBuffer buf = new BoundedReplayBuffer(false) { + BoundedReplayBuffer buf = new BoundedReplayBuffer(false) /* NFI */ { private static final long serialVersionUID = -5182053207244406872L; @Override @@ -1114,7 +1114,7 @@ public void connectConsumerThrows() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -1199,7 +1199,7 @@ public void unsubscribeReplayRace() { public void reentrantOnNext() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1221,7 +1221,7 @@ public void onNext(Integer t) { public void reentrantOnNextBound() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1243,7 +1243,7 @@ public void onNext(Integer t) { public void reentrantOnNextCancel() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1265,7 +1265,7 @@ public void onNext(Integer t) { public void reentrantOnNextCancelBounded() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1287,7 +1287,7 @@ public void onNext(Integer t) { public void delayedUpstreamOnSubscribe() { final Observer[] sub = { null }; - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { sub[0] = observer; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReplayTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReplayTest.java index 254c3f840e..2f2d5b1ed1 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReplayTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableReplayTest.java @@ -648,7 +648,7 @@ public boolean isDisposed() { @Test public void boundedReplayBuffer() { - BoundedReplayBuffer buf = new BoundedReplayBuffer(false) { + BoundedReplayBuffer buf = new BoundedReplayBuffer(false) /* NFI */ { private static final long serialVersionUID = -5182053207244406872L; @Override @@ -1114,7 +1114,7 @@ public void connectConsumerThrows() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -1199,7 +1199,7 @@ public void unsubscribeReplayRace() { public void reentrantOnNext() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1221,7 +1221,7 @@ public void onNext(Integer t) { public void reentrantOnNextBound() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1243,7 +1243,7 @@ public void onNext(Integer t) { public void reentrantOnNextCancel() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1265,7 +1265,7 @@ public void onNext(Integer t) { public void reentrantOnNextCancelBounded() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1287,7 +1287,7 @@ public void onNext(Integer t) { public void delayedUpstreamOnSubscribe() { final Observer[] sub = { null }; - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { sub[0] = observer; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRetryTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRetryTest.java index b7384c9d8a..0843e8418a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRetryTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRetryTest.java @@ -45,7 +45,7 @@ public class ObservableRetryTest extends RxJavaTest { public void iterativeBackoff() { Observer consumer = TestHelper.mockObserver(); - Observable producer = Observable.unsafeCreate(new ObservableSource() { + Observable producer = Observable.unsafeCreate(new ObservableSource() /* NFI */ { private AtomicInteger count = new AtomicInteger(4); long last = System.currentTimeMillis(); @@ -463,25 +463,22 @@ public void subscribe(final Observer observer) { efforts.getAndIncrement(); active.getAndIncrement(); maxActive.set(Math.max(active.get(), maxActive.get())); - final Thread thread = new Thread(context) { - @Override - public void run() { - long nr = 0; - try { - while (!terminate.get()) { - Thread.sleep(emitDelay); - if (nextBeforeFailure.getAndDecrement() > 0) { - observer.onNext(nr++); - } else { - active.decrementAndGet(); - observer.onError(new RuntimeException("expected-failed")); - break; - } + final Thread thread = new Thread(() -> { + long nr = 0; + try { + while (!terminate.get()) { + Thread.sleep(emitDelay); + if (nextBeforeFailure.getAndDecrement() > 0) { + observer.onNext(nr++); + } else { + active.decrementAndGet(); + observer.onError(new RuntimeException("expected-failed")); + break; } - } catch (InterruptedException t) { } + } catch (InterruptedException t) { } - }; + }, context); thread.start(); } } diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRetryWithPredicateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRetryWithPredicateTest.java index 98063c004f..52b18c457a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRetryWithPredicateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableRetryWithPredicateTest.java @@ -59,7 +59,7 @@ public void withNothingToRetry() { @Test public void retryTwice() { - Observable source = Observable.unsafeCreate(new ObservableSource() { + Observable source = Observable.unsafeCreate(new ObservableSource() /* NFI */ { int count; @Override public void subscribe(Observer t1) { @@ -120,7 +120,7 @@ public void retryTwiceAndGiveUp() { @Test public void retryOnSpecificException() { - Observable source = Observable.unsafeCreate(new ObservableSource() { + Observable source = Observable.unsafeCreate(new ObservableSource() /* NFI */ { int count; @Override public void subscribe(Observer t1) { @@ -157,7 +157,7 @@ public void subscribe(Observer t1) { public void retryOnSpecificExceptionAndNotOther() { final IOException ioe = new IOException(); final TestException te = new TestException(); - Observable source = Observable.unsafeCreate(new ObservableSource() { + Observable source = Observable.unsafeCreate(new ObservableSource() /* NFI */ { int count; @Override public void subscribe(Observer t1) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableScanTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableScanTest.java index b97849fcad..f714e97624 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableScanTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableScanTest.java @@ -107,7 +107,7 @@ public void noBackpressureWithInitialValue() { final AtomicInteger count = new AtomicInteger(); Observable.range(1, 100) .scan(0, Integer::sum) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSkipWhileTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSkipWhileTest.java index f085338181..b78065fda0 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSkipWhileTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSkipWhileTest.java @@ -37,7 +37,7 @@ public class ObservableSkipWhileTest extends RxJavaTest { return v < 5; }; - private static final Predicate INDEX_LESS_THAN_THREE = new Predicate() { + private static final Predicate INDEX_LESS_THAN_THREE = new Predicate() /* NFI */ { int index; @Override public boolean test(Integer value) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSwitchIfEmptyTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSwitchIfEmptyTest.java index 30e32c9f0f..3a3699bfcf 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSwitchIfEmptyTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSwitchIfEmptyTest.java @@ -57,7 +57,7 @@ public void switchTriggerUnsubscribe() throws Exception { Observable.empty() .switchIfEmpty(withProducer) - .lift((ObservableOperator) _ -> new DefaultObserver() { + .lift((ObservableOperator) _ -> new DefaultObserver() /* NFI */ { @Override public void onComplete() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSwitchTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSwitchTest.java index 570b32de00..9f9964cbcb 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSwitchTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableSwitchTest.java @@ -372,7 +372,7 @@ public void issue2654() { .share() ; - TestObserverEx to = new TestObserverEx() { + TestObserverEx to = new TestObserverEx() /* NFI */ { @Override public void onNext(String t) { super.onNext(t); @@ -678,7 +678,7 @@ public void mapperThrows() { public void badMainSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -718,7 +718,7 @@ public void badInnerSource() { List errors = TestHelper.trackPluginErrors(); try { Observable.just(1).hide() - .switchMap(Functions.justFunction(new Observable() { + .switchMap(Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -741,7 +741,7 @@ protected void subscribeActual(Observer observer) { public void innerCompletesReentrant() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -762,7 +762,7 @@ public void onNext(Integer t) { public void innerErrorsReentrant() { final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -807,7 +807,7 @@ public void outerInnerErrorRaceIgnoreDispose() { try { final AtomicReference> obs1 = new AtomicReference<>(); - final Observable ps1 = new Observable() { + final Observable ps1 = new Observable() /* NFI */ { @Override protected void subscribeActual( Observer observer) { @@ -815,7 +815,7 @@ protected void subscribeActual( } }; final AtomicReference> obs2 = new AtomicReference<>(); - final Observable ps2 = new Observable() { + final Observable ps2 = new Observable() /* NFI */ { @Override protected void subscribeActual( Observer observer) { @@ -1027,7 +1027,7 @@ public void doubleOnSubscribe() { public void mainCompleteCancelRace() { for (int i = 0; i < TestHelper.RACE_LONG_LOOPS; i++) { AtomicReference> ref = new AtomicReference<>(); - Observable o = new Observable() { + Observable o = new Observable() /* NFI */ { @Override protected void subscribeActual(@NonNull Observer observer) { ref.set(observer); @@ -1052,14 +1052,14 @@ public void mainCompleteInnerErrorRace() { for (int i = 0; i < TestHelper.RACE_LONG_LOOPS; i++) { AtomicReference> ref1 = new AtomicReference<>(); - Observable o1 = new Observable() { + Observable o1 = new Observable() /* NFI */ { @Override protected void subscribeActual(@NonNull Observer observer) { ref1.set(observer); } }; AtomicReference> ref2 = new AtomicReference<>(); - Observable o2 = new Observable() { + Observable o2 = new Observable() /* NFI */ { @Override protected void subscribeActual(@NonNull Observer observer) { ref2.set(observer); @@ -1083,14 +1083,14 @@ protected void subscribeActual(@NonNull Observer obser @Test public void innerNoSubscriptionYet() { AtomicReference> ref1 = new AtomicReference<>(); - Observable o1 = new Observable() { + Observable o1 = new Observable() /* NFI */ { @Override protected void subscribeActual(@NonNull Observer observer) { ref1.set(observer); } }; AtomicReference> ref2 = new AtomicReference<>(); - Observable o2 = new Observable() { + Observable o2 = new Observable() /* NFI */ { @Override protected void subscribeActual(@NonNull Observer observer) { ref2.set(observer); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeLastTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeLastTest.java index 38596a048b..1d6dd50603 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeLastTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeLastTest.java @@ -110,7 +110,7 @@ public void backpressure2() { } private Function newSlowProcessor() { - return new Function() { + return new Function() /* NFI */ { int c; @Override @@ -140,7 +140,8 @@ public void issue1522() { @Test public void unsubscribeTakesEffectEarlyOnFastPath() { final AtomicInteger count = new AtomicInteger(); - Observable.range(0, 100000).takeLast(100000).subscribe(new DefaultObserver() { + Observable.range(0, 100000).takeLast(100000) + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onStart() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeTest.java index 722322a4a7..cfe2023b56 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeTest.java @@ -253,7 +253,7 @@ public void interrupt() throws InterruptedException { public void takeFinalValueThrows() { Observable source = Observable.just(1).take(1); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { throw new TestException(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeUntilPredicateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeUntilPredicateTest.java index 7a23f3b8e7..7719a276a0 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeUntilPredicateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeUntilPredicateTest.java @@ -141,7 +141,7 @@ public void doubleOnSubscribe() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeWhileTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeWhileTest.java index d862cea98e..8a2a12c4a7 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeWhileTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTakeWhileTest.java @@ -71,7 +71,7 @@ public void takeWhileOnSubject1() { @Test public void takeWhile2() { Observable w = Observable.just("one", "two", "three"); - Observable take = w.takeWhile(new Predicate() { + Observable take = w.takeWhile(new Predicate() /* NFI */ { int index; @Override @@ -132,7 +132,7 @@ public void unsubscribeAfterTake() { Observer observer = TestHelper.mockObserver(); Observable take = Observable.unsafeCreate(w) - .takeWhile(new Predicate() { + .takeWhile(new Predicate() /* NFI */ { int index; @Override @@ -230,7 +230,7 @@ public void doubleOnSubscribe() { @Test public void badSource() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableThrottleLatestTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableThrottleLatestTest.java index 6b2d0fd209..ac0ed09d06 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableThrottleLatestTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableThrottleLatestTest.java @@ -196,7 +196,7 @@ public void reentrantComplete() { TestScheduler sch = new TestScheduler(); final PublishSubject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimeoutTests.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimeoutTests.java index c7d3c6a36f..1ca20e4d0d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimeoutTests.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimeoutTests.java @@ -341,7 +341,7 @@ public void timedEmpty() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -367,7 +367,7 @@ protected void subscribeActual(Observer observer) { public void badSourceOther() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimeoutWithSelectorTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimeoutWithSelectorTest.java index 8712bbb727..ea3a67889f 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimeoutWithSelectorTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimeoutWithSelectorTest.java @@ -361,7 +361,7 @@ public void badInnerSource() { PublishSubject ps = PublishSubject.create(); TestObserverEx to = ps - .timeout(Functions.justFunction(new Observable() { + .timeout(Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -390,7 +390,7 @@ public void badInnerSourceOther() { PublishSubject ps = PublishSubject.create(); TestObserverEx to = ps - .timeout(Functions.justFunction(new Observable() { + .timeout(Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -423,7 +423,7 @@ public void withOtherMainError() { @Test @SuppressUndeliverable public void badSourceTimeout() { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -486,7 +486,7 @@ public void lateOnTimeoutError() { final Observer[] sub = { null, null }; - final Observable pp2 = new Observable() { + final Observable pp2 = new Observable() /* NFI */ { int count; @@ -530,7 +530,7 @@ public void lateOnTimeoutFallbackRace() { final Observer[] sub = { null, null }; - final Observable pp2 = new Observable() { + final Observable pp2 = new Observable() /* NFI */ { int count; @@ -575,7 +575,7 @@ public void onErrorOnTimeoutRace() { final Observer[] sub = { null, null }; - final Observable pp2 = new Observable() { + final Observable pp2 = new Observable() /* NFI */ { int count; @@ -620,7 +620,7 @@ public void onCompleteOnTimeoutRace() { final Observer[] sub = { null, null }; - final Observable pp2 = new Observable() { + final Observable pp2 = new Observable() /* NFI */ { int count; @@ -663,7 +663,7 @@ public void onCompleteOnTimeoutRaceFallback() { final Observer[] sub = { null, null }; - final Observable pp2 = new Observable() { + final Observable pp2 = new Observable() /* NFI */ { int count; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimerTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimerTest.java index 24b2d6763e..6730b3055d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimerTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableTimerTest.java @@ -233,7 +233,7 @@ public void withMultipleStaggeredSubscribersAndPublish() { public void onceObserverThrows() { Observable source = Observable.timer(100, TimeUnit.MILLISECONDS, scheduler); - source.safeSubscribe(new DefaultObserver() { + source.safeSubscribe(new DefaultObserver() /* NFI */ { @Override public void onNext(Long t) { @@ -264,7 +264,7 @@ public void periodicObserverThrows() { InOrder inOrder = inOrder(observer); - source.safeSubscribe(new DefaultObserver() { + source.safeSubscribe(new DefaultObserver() /* NFI */ { @Override public void onNext(Long t) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToFutureTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToFutureTest.java index 3f8a12ba36..e19c2046ff 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToFutureTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToFutureTest.java @@ -111,7 +111,7 @@ public void cancelledBeforeSubscribe() throws Exception { @Test public void cancellationDuringFutureGet() throws Exception { - Future future = new Future() { + Future future = new Future() /* NFI */ { private AtomicBoolean isCancelled = new AtomicBoolean(false); private AtomicBoolean isDone = new AtomicBoolean(false); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToMapTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToMapTest.java index b866faa636..38920e0176 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToMapTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToMapTest.java @@ -134,7 +134,7 @@ public void toMapWithErrorInValueSelectorObservable() { public void toMapWithFactoryObservable() { Observable source = Observable.just("a", "bb", "ccc", "dddd"); - Supplier> mapFactory = () -> new LinkedHashMap() { + Supplier> mapFactory = () -> new LinkedHashMap() /* NFI */ { private static final long serialVersionUID = -3296811238780863394L; @@ -273,7 +273,7 @@ public void toMapWithErrorInValueSelector() { public void toMapWithFactory() { Observable source = Observable.just("a", "bb", "ccc", "dddd"); - Supplier> mapFactory = () -> new LinkedHashMap() { + Supplier> mapFactory = () -> new LinkedHashMap() /* NFI */ { private static final long serialVersionUID = -3296811238780863394L; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToMultimapTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToMultimapTest.java index 1ab56252c7..57b0c739cc 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToMultimapTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableToMultimapTest.java @@ -77,7 +77,7 @@ public void toMultimapWithValueSelectorObservable() { public void toMultimapWithMapFactoryObservable() { Observable source = Observable.just("a", "b", "cc", "dd", "eee", "fff"); - Supplier>> mapFactory = () -> new LinkedHashMap>() { + Supplier>> mapFactory = () -> new LinkedHashMap>() /* NFI */ { private static final long serialVersionUID = -2084477070717362859L; @@ -268,7 +268,7 @@ public void toMultimapWithValueSelector() { public void toMultimapWithMapFactory() { Observable source = Observable.just("a", "b", "cc", "dd", "eee", "fff"); - Supplier>> mapFactory = () -> new LinkedHashMap>() { + Supplier>> mapFactory = () -> new LinkedHashMap>() /* NFI */ { private static final long serialVersionUID = -2084477070717362859L; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableUnsubscribeOnTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableUnsubscribeOnTest.java index 2b6495402b..d7f11c62b7 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableUnsubscribeOnTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableUnsubscribeOnTest.java @@ -222,7 +222,7 @@ public void error() { public void signalAfterDispose() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableUsingTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableUsingTest.java index 07014f1f14..e8aa910555 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableUsingTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableUsingTest.java @@ -97,7 +97,7 @@ public void usingWithSubscribingTwiceDisposeEagerly() { private void performTestUsingWithSubscribingTwice(boolean disposeEagerly) { // When subscribe is called, a new resource should be created. - Supplier resourceFactory = () -> new Resource() { + Supplier resourceFactory = () -> new Resource() /* NFI */ { boolean first = true; @@ -285,7 +285,7 @@ private static Consumer createOnErrorAction(final List events } private static Supplier createResourceFactory(final List events) { - return () -> new Resource() { + return () -> new Resource() /* NFI */ { @Override public String getTextFromWeb() { @@ -387,7 +387,7 @@ public void doubleOnSubscribe() { public void eagerDisposedOnComplete() { final TestObserver to = new TestObserver<>(); - Observable.using(Functions.justSupplier(1), Functions.justFunction(new Observable() { + Observable.using(Functions.justSupplier(1), Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -402,7 +402,7 @@ protected void subscribeActual(Observer observer) { public void eagerDisposedOnError() { final TestObserver to = new TestObserver<>(); - Observable.using(Functions.justSupplier(1), Functions.justFunction(new Observable() { + Observable.using(Functions.justSupplier(1), Functions.justFunction(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithObservableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithObservableTest.java index 67d1a85b10..0b0b74483d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithObservableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithObservableTest.java @@ -46,7 +46,7 @@ public void windowViaObservableNormal1() { final List> values = new ArrayList<>(); - Observer> wo = new DefaultObserver>() { + Observer> wo = new DefaultObserver>() /* NFI */ { @Override public void onNext(Observable args) { final Observer mo = TestHelper.mockObserver(); @@ -103,7 +103,7 @@ public void windowViaObservableBoundaryCompletes() { final List> values = new ArrayList<>(); - Observer> wo = new DefaultObserver>() { + Observer> wo = new DefaultObserver>() /* NFI */ { @Override public void onNext(Observable args) { final Observer mo = TestHelper.mockObserver(); @@ -159,7 +159,7 @@ public void windowViaObservableBoundaryThrows() { final List> values = new ArrayList<>(); - Observer> wo = new DefaultObserver>() { + Observer> wo = new DefaultObserver>() /* NFI */ { @Override public void onNext(Observable args) { final Observer mo = TestHelper.mockObserver(); @@ -209,7 +209,7 @@ public void windowViaObservableSourceThrows() { final List> values = new ArrayList<>(); - Observer> wo = new DefaultObserver>() { + Observer> wo = new DefaultObserver>() /* NFI */ { @Override public void onNext(Observable args) { final Observer mo = TestHelper.mockObserver(); @@ -278,7 +278,7 @@ public void innerBadSource() { public void reentrant() { final Subject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -337,7 +337,7 @@ public void mainAndBoundaryBothError() { final AtomicReference> ref = new AtomicReference<>(); TestObserverEx> to = Observable.error(new TestException("main")) - .window(new Observable() { + .window(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -373,14 +373,14 @@ public void mainCompleteBoundaryErrorRace() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - TestObserverEx> to = new Observable() { + TestObserverEx> to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); refMain.set(observer); } } - .window(new Observable() { + .window(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -413,14 +413,14 @@ public void mainNextBoundaryNextRace() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - TestObserver> to = new Observable() { + TestObserver> to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); refMain.set(observer); } } - .window(new Observable() { + .window(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -446,14 +446,14 @@ public void takeOneAnotherBoundary() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - TestObserverEx> to = new Observable() { + TestObserverEx> to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); refMain.set(observer); } } - .window(new Observable() { + .window(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); @@ -478,18 +478,18 @@ public void disposeMainBoundaryCompleteRace() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - final TestObserver> to = new Observable() { + final TestObserver> to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); refMain.set(observer); } } - .window(new Observable() { + .window(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { final AtomicInteger counter = new AtomicInteger(); - observer.onSubscribe(new Disposable() { + observer.onSubscribe(new Disposable() /* NFI */ { @Override public void dispose() { @@ -529,18 +529,18 @@ public void disposeMainBoundaryErrorRace() { final AtomicReference> refMain = new AtomicReference<>(); final AtomicReference> ref = new AtomicReference<>(); - final TestObserver> to = new Observable() { + final TestObserver> to = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); refMain.set(observer); } } - .window(new Observable() { + .window(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { final AtomicInteger counter = new AtomicInteger(); - observer.onSubscribe(new Disposable() { + observer.onSubscribe(new Disposable() /* NFI */ { @Override public void dispose() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithStartEndObservableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithStartEndObservableTest.java index e9948cb090..4fff9f4fb2 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithStartEndObservableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithStartEndObservableTest.java @@ -100,7 +100,7 @@ private void complete(final Observer observer, int delay) { } private Consumer> observeWindow(final List list, final List> lists) { - return stringObservable -> stringObservable.subscribe(new DefaultObserver() { + return stringObservable -> stringObservable.subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { lists.add(new ArrayList<>(list)); @@ -264,7 +264,7 @@ public void dispose() { public void reentrant() { final Subject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -297,7 +297,8 @@ public void windowCloseIngoresCancel() { List errors = TestHelper.trackPluginErrors(); try { BehaviorSubject.createDefault(1) - .window(BehaviorSubject.createDefault(1), (Function>) _ -> new Observable() { + .window(BehaviorSubject.createDefault(1), + (Function>) _ -> new Observable() /* NFI */ { @Override protected void subscribeActual( Observer observer) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithTimeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithTimeTest.java index 58ee010498..141decfd6d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithTimeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithTimeTest.java @@ -121,7 +121,7 @@ private void complete(final Observer observer, int delay) { } private Consumer> observeWindow(final List list, final List> lists) { - return stringObservable -> stringObservable.subscribe(new DefaultObserver() { + return stringObservable -> stringObservable.subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { lists.add(new ArrayList<>(list)); @@ -425,7 +425,7 @@ public void exactUnboundedReentrant() { final Subject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -453,7 +453,7 @@ public void exactBoundedReentrant() { final Subject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -481,7 +481,7 @@ public void exactBoundedReentrant2() { final Subject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -509,7 +509,7 @@ public void skipReentrant() { final Subject ps = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -662,7 +662,7 @@ public void exactTimeBoundNoInterruptWindowOutputOnComplete() throws Exception { final CountDownLatch secondWindowProcessing = new CountDownLatch(1); ps.window(100, TimeUnit.MILLISECONDS) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Observable v) throws Exception { @@ -703,7 +703,7 @@ public void exactTimeBoundNoInterruptWindowOutputOnError() throws Exception { final CountDownLatch secondWindowProcessing = new CountDownLatch(1); ps.window(100, TimeUnit.MILLISECONDS) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Observable v) throws Exception { @@ -743,7 +743,7 @@ public void exactTimeAndSizeBoundNoInterruptWindowOutputOnComplete() throws Exce final CountDownLatch secondWindowProcessing = new CountDownLatch(1); ps.window(100, TimeUnit.MILLISECONDS, 10) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Observable v) throws Exception { @@ -784,7 +784,7 @@ public void exactTimeAndSizeBoundNoInterruptWindowOutputOnError() throws Excepti final CountDownLatch secondWindowProcessing = new CountDownLatch(1); ps.window(100, TimeUnit.MILLISECONDS, 10) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Observable v) throws Exception { @@ -824,7 +824,7 @@ public void skipTimeAndSizeBoundNoInterruptWindowOutputOnComplete() throws Excep final CountDownLatch secondWindowProcessing = new CountDownLatch(1); ps.window(90, 100, TimeUnit.MILLISECONDS) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Observable v) throws Exception { @@ -865,7 +865,7 @@ public void skipTimeAndSizeBoundNoInterruptWindowOutputOnError() throws Exceptio final CountDownLatch secondWindowProcessing = new CountDownLatch(1); ps.window(90, 100, TimeUnit.MILLISECONDS) - .doOnNext(new Consumer>() { + .doOnNext(new Consumer>() /* NFI */ { int count; @Override public void accept(Observable v) throws Exception { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWithLatestFromTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWithLatestFromTest.java index 5c5c5b173d..3b688086d8 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWithLatestFromTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWithLatestFromTest.java @@ -491,7 +491,7 @@ public void manyCombinerThrows() { public void manyErrors() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableZipIterableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableZipIterableTest.java index 690a4ba7ec..7698797942 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableZipIterableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableZipIterableTest.java @@ -228,7 +228,7 @@ public void zipIterableHasNextThrows() { Observer o = TestHelper.mockObserver(); InOrder io = inOrder(o); - Iterable r2 = () -> new Iterator() { + Iterable r2 = () -> new Iterator() /* NFI */ { int count; @Override @@ -271,7 +271,7 @@ public void zipIterableNextThrows() { Observer o = TestHelper.mockObserver(); InOrder io = inOrder(o); - Iterable r2 = () -> new Iterator() { + Iterable r2 = () -> new Iterator() /* NFI */ { @Override public boolean hasNext() { return true; @@ -346,7 +346,7 @@ public void iteratorThrows() { public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - new Observable() { + new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableZipTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableZipTest.java index bcfcb2f6e8..32e5d15236 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableZipTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableZipTest.java @@ -677,7 +677,7 @@ public void startWithOnCompletedTwice() { final Observer observer = TestHelper.mockObserver(); Observable.zip(Observable.just(1), - Observable.just(1), Integer::sum).subscribe(new DefaultObserver() { + Observable.just(1), Integer::sum).subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -744,7 +744,7 @@ public void startInfiniteAndFinite() throws InterruptedException { .zipWith(ASYNC_OBSERVABLE_OF_INFINITE_INTEGERS(infiniteObservable), (a, b) -> a + "-" + b); final ArrayList list = new ArrayList<>(); - os.subscribe(new DefaultObserver() { + os.subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -881,7 +881,7 @@ public void downstreamBackpressureRequestsWithFiniteSyncObservables() { } private Observable createInfiniteObservable(final AtomicInteger generated) { - Observable o = Observable.fromIterable(() -> new Iterator() { + Observable o = Observable.fromIterable(() -> new Iterator() /* NFI */ { @Override public void remove() { @@ -1141,7 +1141,7 @@ public void eagerDispose() { final PublishSubject ps1 = PublishSubject.create(); final PublishSubject ps2 = PublishSubject.create(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCacheTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCacheTest.java index 3ed8c717ca..ed1051d1bd 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCacheTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCacheTest.java @@ -62,7 +62,7 @@ public void doubleDispose() { final Single cached = pp.single(-99).cache(); - SingleObserver doubleDisposer = new SingleObserver() { + SingleObserver doubleDisposer = new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCreateTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCreateTest.java index 13035f97f6..95990e41ea 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCreateTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCreateTest.java @@ -136,7 +136,7 @@ public void createConsumerThrows() { // expected } }) - .subscribe(new SingleObserver() { + .subscribe(new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -168,7 +168,7 @@ public void createConsumerThrowsResource() { assertTrue(d.isDisposed()); }) - .subscribe(new SingleObserver() { + .subscribe(new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -196,7 +196,7 @@ public void createConsumerThrowsOnError() { // expected } }) - .subscribe(new SingleObserver() { + .subscribe(new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { } @@ -226,7 +226,7 @@ public void createConsumerThrowsResourceOnError() { assertTrue(d.isDisposed()); }) - .subscribe(new SingleObserver() { + .subscribe(new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDeferTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDeferTest.java index 198b203471..1ae55eeaeb 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDeferTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDeferTest.java @@ -23,7 +23,7 @@ public class SingleDeferTest extends RxJavaTest { @Test public void normal() { - Single s = Single.defer(new Supplier>() { + Single s = Single.defer(new Supplier>() /* NFI */ { int counter; @Override public Single get() throws Exception { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDelayTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDelayTest.java index 683d0d9031..a14c3a1b63 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDelayTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDelayTest.java @@ -173,7 +173,7 @@ public void withPublisherError2() { try { Single.just(1) - .delaySubscription(new Flowable() { + .delaySubscription(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -209,7 +209,7 @@ public void withObservableError2() { try { Single.just(1) - .delaySubscription(new Observable() { + .delaySubscription(new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDetachTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDetachTest.java index 44c01485da..ecf0828604 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDetachTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDetachTest.java @@ -61,7 +61,7 @@ public void cancelDetaches() throws Exception { Disposable d = Disposable.empty(); final WeakReference wr = new WeakReference<>(d); - TestObserver to = new Single() { + TestObserver to = new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { observer.onSubscribe(wr.get()); @@ -87,7 +87,7 @@ public void errorDetaches() throws Exception { Disposable d = Disposable.empty(); final WeakReference wr = new WeakReference<>(d); - TestObserver to = new Single() { + TestObserver to = new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { observer.onSubscribe(wr.get()); @@ -113,7 +113,7 @@ public void successDetaches() throws Exception { Disposable d = Disposable.empty(); final WeakReference wr = new WeakReference<>(d); - TestObserver to = new Single() { + TestObserver to = new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { observer.onSubscribe(wr.get()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoAfterSuccessTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoAfterSuccessTest.java index f2eabea9f4..3a6ebf60cf 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoAfterSuccessTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoAfterSuccessTest.java @@ -34,7 +34,7 @@ public class SingleDoAfterSuccessTest extends RxJavaTest { final Consumer afterSuccess = e -> values.add(-e); - final TestObserver to = new TestObserver() { + final TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnLifecycleTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnLifecycleTest.java index 53c49d08d1..8756926fe2 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnLifecycleTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnLifecycleTest.java @@ -69,7 +69,7 @@ public void onSubscribeCrash() throws Throwable { Disposable bs = Disposable.empty(); - new Single() { + new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { observer.onSubscribe(bs); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnTest.java index e8e7d34ce1..e4a322bf91 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnTest.java @@ -252,7 +252,7 @@ public void onSubscribeCrash() { try { final Disposable bs = Disposable.empty(); - new Single() { + new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { observer.onSubscribe(bs); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFlatMapIterableFlowableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFlatMapIterableFlowableTest.java index 94e9d5bd51..23b74eb8a4 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFlatMapIterableFlowableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFlatMapIterableFlowableTest.java @@ -216,7 +216,8 @@ public void async4() { @Test public void fusedEmptyCheck() { Single.just(1) - .flattenAsFlowable((Function>) _ -> Arrays.asList(1, 2, 3)).subscribe(new FlowableSubscriber() { + .flattenAsFlowable((Function>) _ -> Arrays.asList(1, 2, 3)) + .subscribe(new FlowableSubscriber() /* NFI */ { QueueSubscription qs; @SuppressWarnings("unchecked") @Override @@ -349,7 +350,7 @@ public void slowPathCancelAfterHasNext() { final TestSubscriber ts = new TestSubscriber<>(0L); Single.just(1) - .flattenAsFlowable((Function>) _ -> (Iterable) () -> new Iterator() { + .flattenAsFlowable((Function>) _ -> (Iterable) () -> new Iterator() /* NFI */ { int count; @Override public boolean hasNext() { @@ -383,7 +384,7 @@ public void fastPathCancelAfterHasNext() { final TestSubscriber ts = new TestSubscriber<>(0L); Single.just(1) - .flattenAsFlowable((Function>) _ -> (Iterable) () -> new Iterator() { + .flattenAsFlowable((Function>) _ -> (Iterable) () -> new Iterator() /* NFI */ { int count; @Override public boolean hasNext() { @@ -446,7 +447,7 @@ public void badRequest() { @Test public void slowPatchCancelAfterOnNext() { - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(@NonNull Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFlatMapIterableObservableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFlatMapIterableObservableTest.java index aab95fe327..ec106c1f76 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFlatMapIterableObservableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFlatMapIterableObservableTest.java @@ -207,7 +207,8 @@ public void async4() { @Test public void fusedEmptyCheck() { Single.just(1) - .flattenAsObservable((Function>) _ -> Arrays.asList(1, 2, 3)).subscribe(new Observer() { + .flattenAsObservable((Function>) _ -> Arrays.asList(1, 2, 3)) + .subscribe(new Observer() /* NFI */ { QueueDisposable qd; @SuppressWarnings("unchecked") @Override diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFromPublisherTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFromPublisherTest.java index 9bab4868c4..7ed09ca301 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFromPublisherTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleFromPublisherTest.java @@ -83,7 +83,7 @@ public void badSource() { List errors = TestHelper.trackPluginErrors(); try { - Single.fromPublisher(new Flowable() { + Single.fromPublisher(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleLiftTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleLiftTest.java index ea9f25d4b7..01ac565d48 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleLiftTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleLiftTest.java @@ -23,7 +23,7 @@ public class SingleLiftTest extends RxJavaTest { @Test public void normal() { - Single.just(1).lift((SingleOperator) observer -> new SingleObserver() { + Single.just(1).lift((SingleOperator) observer -> new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleMiscTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleMiscTest.java index 27e9b3d446..b59c4bcc5d 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleMiscTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleMiscTest.java @@ -120,7 +120,7 @@ public void repeatUntil() { final AtomicBoolean flag = new AtomicBoolean(); Single.just(1) - .doOnSuccess(new Consumer() { + .doOnSuccess(new Consumer() /* NFI */ { int c; @Override public void accept(Integer v) throws Exception { @@ -137,7 +137,7 @@ public void accept(Integer v) throws Exception { @Test public void retry() { - Single.fromCallable(new Callable() { + Single.fromCallable(new Callable() /* NFI */ { int c; @Override public Object call() throws Exception { @@ -154,7 +154,7 @@ public Object call() throws Exception { @Test public void retryBiPredicate() { - Single.fromCallable(new Callable() { + Single.fromCallable(new Callable() /* NFI */ { int c; @Override public Object call() throws Exception { @@ -188,7 +188,7 @@ public void retryTimes() { @Test public void retryPredicate() { - Single.fromCallable(new Callable() { + Single.fromCallable(new Callable() /* NFI */ { int c; @Override public Object call() throws Exception { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleSafeSubscribeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleSafeSubscribeTest.java index 6c68c4f2d2..cd639456e4 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleSafeSubscribeTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleSafeSubscribeTest.java @@ -75,7 +75,7 @@ public void onSubscribeCrash() throws Throwable { Disposable d = Disposable.empty(); - new Single() { + new Single() /* NFI */ { @Override protected void subscribeActual(@NonNull SingleObserver observer) { observer.onSubscribe(d); @@ -104,7 +104,7 @@ public void onSuccessCrash() throws Throwable { SingleObserver consumer = mock(SingleObserver.class); doThrow(new TestException()).when(consumer).onSuccess(any()); - new Single() { + new Single() /* NFI */ { @Override protected void subscribeActual(@NonNull SingleObserver observer) { observer.onSubscribe(Disposable.empty()); @@ -129,7 +129,7 @@ public void onErrorCrash() throws Throwable { SingleObserver consumer = mock(SingleObserver.class); doThrow(new TestException()).when(consumer).onError(any()); - new Single() { + new Single() /* NFI */ { @Override protected void subscribeActual(@NonNull SingleObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleTakeUntilTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleTakeUntilTest.java index dd431e4164..dff4655693 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleTakeUntilTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleTakeUntilTest.java @@ -271,7 +271,7 @@ public void otherSignalsAndCompletes() { @Test public void flowableCancelDelayed() { Single.never() - .takeUntil(new Flowable() { + .takeUntil(new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleTimeoutTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleTimeoutTest.java index 1d03215cf2..e49cbbfeed 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleTimeoutTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleTimeoutTest.java @@ -211,7 +211,7 @@ public void mainTimeoutFallbackSuccess() { public void timeoutBeforeOnSubscribeFromMain() { Disposable d = Disposable.empty(); - new Single() { + new Single() /* NFI */ { @Override protected void subscribeActual(@NonNull SingleObserver observer) { try { diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUnsubscribeOnTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUnsubscribeOnTest.java index b30cbef184..975097b740 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUnsubscribeOnTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUnsubscribeOnTest.java @@ -92,7 +92,7 @@ public void disposeRace() { final Disposable[] ds = { null }; pp.single(-99).unsubscribeOn(Schedulers.computation()) - .subscribe(new SingleObserver() { + .subscribe(new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { ds[0] = d; diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUsingTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUsingTest.java index 3c104e7fbd..d1ce15fba5 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUsingTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleUsingTest.java @@ -214,7 +214,7 @@ public void doubleOnSubscribe() { List errors = TestHelper.trackPluginErrors(); try { - Single.using(Functions.justSupplier(1), (Function>) _ -> new Single() { + Single.using(Functions.justSupplier(1), (Function>) _ -> new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { observer.onSubscribe(Disposable.empty()); diff --git a/src/test/java/io/reactivex/rxjava4/internal/schedulers/AbstractDirectTaskTest.java b/src/test/java/io/reactivex/rxjava4/internal/schedulers/AbstractDirectTaskTest.java index be0bdeb616..cb8c16d87a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/schedulers/AbstractDirectTaskTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/schedulers/AbstractDirectTaskTest.java @@ -28,7 +28,7 @@ public class AbstractDirectTaskTest extends RxJavaTest { @Test public void cancelSetFuture() { @SuppressWarnings("resource") - AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) { + AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) /* NFI */ { private static final long serialVersionUID = 208585707945686116L; }; final Boolean[] interrupted = { null }; @@ -43,7 +43,7 @@ public void cancelSetFuture() { assertTrue(task.isDisposed()); - FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) { + FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) /* NFI */ { @Override public boolean cancel(boolean mayInterruptIfRunning) { interrupted[0] = mayInterruptIfRunning; @@ -60,7 +60,7 @@ public boolean cancel(boolean mayInterruptIfRunning) { @Test public void cancelSetFutureCurrentThread() { @SuppressWarnings("resource") - AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) { + var task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) /* NFI */ { private static final long serialVersionUID = 208585707945686116L; }; final Boolean[] interrupted = { null }; @@ -77,7 +77,7 @@ public void cancelSetFutureCurrentThread() { assertTrue(task.isDisposed()); - FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) { + var ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) /* NFI */ { @Override public boolean cancel(boolean mayInterruptIfRunning) { interrupted[0] = mayInterruptIfRunning; @@ -94,12 +94,12 @@ public boolean cancel(boolean mayInterruptIfRunning) { @Test public void setFutureCancel() { @SuppressWarnings("resource") - AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) { + var task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) /* NFI */ { private static final long serialVersionUID = 208585707945686116L; }; final Boolean[] interrupted = { null }; - FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) { + var ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) /* NFI */ { @Override public boolean cancel(boolean mayInterruptIfRunning) { interrupted[0] = mayInterruptIfRunning; @@ -123,12 +123,12 @@ public boolean cancel(boolean mayInterruptIfRunning) { @Test public void setFutureCancelSameThread() { @SuppressWarnings("resource") - AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) { + AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) /* NFI */ { private static final long serialVersionUID = 208585707945686116L; }; final Boolean[] interrupted = { null }; - FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) { + var ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) /* NFI */ { @Override public boolean cancel(boolean mayInterruptIfRunning) { interrupted[0] = mayInterruptIfRunning; @@ -153,11 +153,11 @@ public boolean cancel(boolean mayInterruptIfRunning) { @Test public void finished() { @SuppressWarnings("resource") - AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) { + AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) /* NFI */ { private static final long serialVersionUID = 208585707945686116L; }; final Boolean[] interrupted = { null }; - FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) { + FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) /* NFI */ { @Override public boolean cancel(boolean mayInterruptIfRunning) { interrupted[0] = mayInterruptIfRunning; @@ -183,11 +183,11 @@ public boolean cancel(boolean mayInterruptIfRunning) { @Test public void finishedCancel() { @SuppressWarnings("resource") - AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) { + AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) /* NFI */ { private static final long serialVersionUID = 208585707945686116L; }; final Boolean[] interrupted = { null }; - FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) { + FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) /* NFI */ { @Override public boolean cancel(boolean mayInterruptIfRunning) { interrupted[0] = mayInterruptIfRunning; @@ -218,12 +218,12 @@ public boolean cancel(boolean mayInterruptIfRunning) { public void disposeSetFutureRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { @SuppressWarnings("resource") - final AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) { + final AbstractDirectTask task = new AbstractDirectTask(Functions.EMPTY_RUNNABLE, true) /* NFI */ { private static final long serialVersionUID = 208585707945686116L; }; final Boolean[] interrupted = { null }; - final FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) { + final FutureTask ft = new FutureTask(Functions.EMPTY_RUNNABLE, null) /* NFI */ { @Override public boolean cancel(boolean mayInterruptIfRunning) { interrupted[0] = mayInterruptIfRunning; diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscribers/BasicFuseableConditionalSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscribers/BasicFuseableConditionalSubscriberTest.java index 4c5cdb92ee..10e14efe6a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscribers/BasicFuseableConditionalSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscribers/BasicFuseableConditionalSubscriberTest.java @@ -31,7 +31,7 @@ public class BasicFuseableConditionalSubscriberTest extends RxJavaTest { @Test public void offerThrows() { - ConditionalSubscriber cs = new ConditionalSubscriber() { + var cs = new ConditionalSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -55,7 +55,7 @@ public boolean tryOnNext(Integer t) { } }; - BasicFuseableConditionalSubscriber fcs = new BasicFuseableConditionalSubscriber(cs) { + var fcs = new BasicFuseableConditionalSubscriber(cs) /* NFI */ { @Override public boolean tryOnNext(Integer t) { @@ -92,7 +92,7 @@ public void implementationStopsOnSubscribe() { @SuppressWarnings("unchecked") ConditionalSubscriber ts = mock(ConditionalSubscriber.class); - BasicFuseableConditionalSubscriber bfs = new BasicFuseableConditionalSubscriber(ts) { + var bfs = new BasicFuseableConditionalSubscriber(ts) /* NFI */ { @Override protected boolean beforeDownstream() { @@ -140,7 +140,7 @@ public void transitiveBoundaryFusionNone() { @SuppressWarnings("unchecked") ConditionalSubscriber ts = mock(ConditionalSubscriber.class); - BasicFuseableConditionalSubscriber bfs = new BasicFuseableConditionalSubscriber(ts) { + var bfs = new BasicFuseableConditionalSubscriber(ts) /* NFI */ { @Override protected boolean beforeDownstream() { @@ -180,7 +180,7 @@ public void transitiveBoundaryFusionAsync() { @SuppressWarnings("unchecked") ConditionalSubscriber ts = mock(ConditionalSubscriber.class); - BasicFuseableConditionalSubscriber bfs = new BasicFuseableConditionalSubscriber(ts) { + var bfs = new BasicFuseableConditionalSubscriber(ts) /* NFI */ { @Override protected boolean beforeDownstream() { @@ -220,7 +220,7 @@ public void transitiveBoundaryFusionAsyncBoundary() { @SuppressWarnings("unchecked") ConditionalSubscriber ts = mock(ConditionalSubscriber.class); - BasicFuseableConditionalSubscriber bfs = new BasicFuseableConditionalSubscriber(ts) { + BasicFuseableConditionalSubscriber bfs = new BasicFuseableConditionalSubscriber(ts) /* NFI */ { @Override protected boolean beforeDownstream() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscribers/BasicFuseableSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscribers/BasicFuseableSubscriberTest.java index 710b96c6a9..dfa0884377 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscribers/BasicFuseableSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscribers/BasicFuseableSubscriberTest.java @@ -57,7 +57,7 @@ public Integer poll() throws Exception { @Test public void implementationStopsOnSubscribe() { TestSubscriber ts = new TestSubscriber<>(); - BasicFuseableSubscriber bfs = new BasicFuseableSubscriber(ts) { + var bfs = new BasicFuseableSubscriber(ts) /* NFI */ { @Override protected boolean beforeDownstream() { diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscribers/BlockingSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscribers/BlockingSubscriberTest.java index 3d962d5884..2874ebd3fa 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscribers/BlockingSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscribers/BlockingSubscriberTest.java @@ -89,7 +89,7 @@ public void cancelOnRequest() { final AtomicBoolean b = new AtomicBoolean(); - Subscription s = new Subscription() { + Subscription s = new Subscription() /* NFI */ { @Override public void request(long n) { bf.cancelled = true; @@ -115,7 +115,7 @@ public void cancelUpfront() { bf.cancelled = true; - Subscription s = new Subscription() { + Subscription s = new Subscription() /* NFI */ { @Override public void request(long n) { b.set(true); diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscribers/DeferredScalarSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscribers/DeferredScalarSubscriberTest.java index ad71914ba2..75e220078a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscribers/DeferredScalarSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscribers/DeferredScalarSubscriberTest.java @@ -172,7 +172,7 @@ public void rangeSource() { @Test public void completeAfterNext() { - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -194,7 +194,7 @@ public void onNext(Integer t) { @Test public void completeAfterNextViaRequest() { - TestSubscriber ts = new TestSubscriber(0L) { + TestSubscriber ts = new TestSubscriber(0L) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscribers/FlowableConsumersTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscribers/FlowableConsumersTest.java index 58b9a50cbf..5e5dd6b67c 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscribers/FlowableConsumersTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscribers/FlowableConsumersTest.java @@ -290,7 +290,7 @@ public void badSource() { List errors = TestHelper.trackPluginErrors(); try { subscribeAutoDispose( - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual( Subscriber s) { diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscribers/InnerQueuedSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscribers/InnerQueuedSubscriberTest.java index 73c0c388a2..3a53162e95 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscribers/InnerQueuedSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscribers/InnerQueuedSubscriberTest.java @@ -26,7 +26,7 @@ public class InnerQueuedSubscriberTest extends RxJavaTest { @Test public void requestInBatches() { - InnerQueuedSubscriberSupport support = new InnerQueuedSubscriberSupport() { + InnerQueuedSubscriberSupport support = new InnerQueuedSubscriberSupport() /* NFI */ { @Override public void innerNext(InnerQueuedSubscriber inner, Integer value) { } @@ -48,7 +48,7 @@ public void drain() { final List requests = new ArrayList<>(); - inner.onSubscribe(new Subscription() { + inner.onSubscribe(new Subscription() /* NFI */ { @Override public void request(long n) { requests.add(n); diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscribers/SinglePostCompleteSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscribers/SinglePostCompleteSubscriberTest.java index 277e95e987..1abfc2a2d3 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscribers/SinglePostCompleteSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscribers/SinglePostCompleteSubscriberTest.java @@ -27,7 +27,7 @@ public void requestCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final TestSubscriber ts = new TestSubscriber<>(0L); - final SinglePostCompleteSubscriber spc = new SinglePostCompleteSubscriber(ts) { + final SinglePostCompleteSubscriber spc = new SinglePostCompleteSubscriber(ts) /* NFI */ { private static final long serialVersionUID = -2848918821531562637L; @Override diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscribers/StrictSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscribers/StrictSubscriberTest.java index c13ba2e64e..77b765a42e 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscribers/StrictSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscribers/StrictSubscriberTest.java @@ -30,7 +30,7 @@ public class StrictSubscriberTest extends RxJavaTest { @Test public void strictMode() { final List list = new ArrayList<>(); - Subscriber sub = new Subscriber() { + Subscriber sub = new Subscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -53,7 +53,7 @@ public void onComplete() { } }; - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -132,7 +132,7 @@ public void normalOnError() { @Test public void deferredRequest() { final List list = new ArrayList<>(); - Subscriber sub = new Subscriber() { + Subscriber sub = new Subscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -164,7 +164,7 @@ public void onComplete() { @Test public void requestZero() { final List list = new ArrayList<>(); - Subscriber sub = new Subscriber() { + Subscriber sub = new Subscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -196,7 +196,7 @@ public void onComplete() { @Test public void requestNegative() { final List list = new ArrayList<>(); - Subscriber sub = new Subscriber() { + Subscriber sub = new Subscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -228,7 +228,7 @@ public void onComplete() { @Test public void cancelAfterOnComplete() { final List list = new ArrayList<>(); - Subscriber sub = new Subscriber() { + Subscriber sub = new Subscriber() /* NFI */ { Subscription upstream; @Override @@ -254,7 +254,7 @@ public void onComplete() { } }; - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { BooleanSubscription b = new BooleanSubscription(); @@ -270,7 +270,7 @@ protected void subscribeActual(Subscriber s) { @Test public void cancelAfterOnError() { final List list = new ArrayList<>(); - Subscriber sub = new Subscriber() { + Subscriber sub = new Subscriber() /* NFI */ { Subscription upstream; @Override @@ -296,7 +296,7 @@ public void onComplete() { } }; - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { BooleanSubscription b = new BooleanSubscription(); @@ -314,7 +314,7 @@ public void doubleOnSubscribe() { TestSubscriberEx ts = new TestSubscriberEx<>(); SubscriberWrapper wrapper = new SubscriberWrapper<>(ts); - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { BooleanSubscription b1 = new BooleanSubscription(); diff --git a/src/test/java/io/reactivex/rxjava4/internal/subscriptions/SubscriptionHelperTest.java b/src/test/java/io/reactivex/rxjava4/internal/subscriptions/SubscriptionHelperTest.java index 9dc1d662b4..0251c8d694 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/subscriptions/SubscriptionHelperTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/subscriptions/SubscriptionHelperTest.java @@ -176,7 +176,7 @@ public void deferredRace() { final AtomicLong q = new AtomicLong(); - final Subscription a = new Subscription() { + final Subscription a = new Subscription() /* NFI */ { @Override public void request(long n) { q.addAndGet(n); diff --git a/src/test/java/io/reactivex/rxjava4/internal/util/AtomicThrowableTest.java b/src/test/java/io/reactivex/rxjava4/internal/util/AtomicThrowableTest.java index 89a8b1c4f0..a06a07a6b8 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/util/AtomicThrowableTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/util/AtomicThrowableTest.java @@ -250,7 +250,7 @@ public void tryTerminateConsumerCompletableObserverTerminated() { } static Emitter wrapToEmitter(final Observer observer) { - return new Emitter() { + return new Emitter() /* NFI */ { @Override public void onNext(T value) { observer.onNext(value); diff --git a/src/test/java/io/reactivex/rxjava4/internal/util/EndConsumerHelperTest.java b/src/test/java/io/reactivex/rxjava4/internal/util/EndConsumerHelperTest.java index 7a27cd8d41..490c9549b9 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/util/EndConsumerHelperTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/util/EndConsumerHelperTest.java @@ -51,7 +51,7 @@ public void utilityClass() { @Test public void checkDoubleDefaultSubscriber() { - Subscriber consumer = new DefaultSubscriber() { + Subscriber consumer = new DefaultSubscriber() /* NFI */ { @Override public void onNext(Integer t) { } @@ -126,7 +126,7 @@ public void checkDoubleDefaultSubscriberNonAnonymous() { @Test public void checkDoubleDisposableSubscriber() { @SuppressWarnings("resource") - Subscriber consumer = new DisposableSubscriber() { + Subscriber consumer = new DisposableSubscriber() /* NFI */ { @Override public void onNext(Integer t) { } @@ -162,7 +162,7 @@ public void onComplete() { @Test public void checkDoubleResourceSubscriber() { @SuppressWarnings("resource") - Subscriber consumer = new ResourceSubscriber() { + Subscriber consumer = new ResourceSubscriber() /* NFI */ { @Override public void onNext(Integer t) { } @@ -197,7 +197,7 @@ public void onComplete() { @Test public void checkDoubleDefaultObserver() { - Observer consumer = new DefaultObserver() { + Observer consumer = new DefaultObserver() /* NFI */ { @Override public void onNext(Integer t) { } @@ -233,7 +233,7 @@ public void onComplete() { @Test public void checkDoubleDisposableObserver() { @SuppressWarnings("resource") - Observer consumer = new DisposableObserver() { + Observer consumer = new DisposableObserver() /* NFI */ { @Override public void onNext(Integer t) { } @@ -269,7 +269,7 @@ public void onComplete() { @Test public void checkDoubleResourceObserver() { @SuppressWarnings("resource") - Observer consumer = new ResourceObserver() { + Observer consumer = new ResourceObserver() /* NFI */ { @Override public void onNext(Integer t) { } @@ -305,7 +305,7 @@ public void onComplete() { @Test public void checkDoubleDisposableSingleObserver() { @SuppressWarnings("resource") - SingleObserver consumer = new DisposableSingleObserver() { + SingleObserver consumer = new DisposableSingleObserver() /* NFI */ { @Override public void onSuccess(Integer t) { } @@ -337,7 +337,7 @@ public void onError(Throwable t) { @Test public void checkDoubleResourceSingleObserver() { @SuppressWarnings("resource") - SingleObserver consumer = new ResourceSingleObserver() { + SingleObserver consumer = new ResourceSingleObserver() /* NFI */ { @Override public void onSuccess(Integer t) { } @@ -369,7 +369,7 @@ public void onError(Throwable t) { @Test public void checkDoubleDisposableMaybeObserver() { @SuppressWarnings("resource") - MaybeObserver consumer = new DisposableMaybeObserver() { + MaybeObserver consumer = new DisposableMaybeObserver() /* NFI */ { @Override public void onSuccess(Integer t) { } @@ -405,7 +405,7 @@ public void onComplete() { @Test public void checkDoubleResourceMaybeObserver() { @SuppressWarnings("resource") - MaybeObserver consumer = new ResourceMaybeObserver() { + MaybeObserver consumer = new ResourceMaybeObserver() /* NFI */ { @Override public void onSuccess(Integer t) { } @@ -441,7 +441,7 @@ public void onComplete() { @Test public void checkDoubleDisposableCompletableObserver() { @SuppressWarnings("resource") - CompletableObserver consumer = new DisposableCompletableObserver() { + CompletableObserver consumer = new DisposableCompletableObserver() /* NFI */ { @Override public void onError(Throwable t) { } @@ -473,7 +473,7 @@ public void onComplete() { @Test public void checkDoubleResourceCompletableObserver() { @SuppressWarnings("resource") - CompletableObserver consumer = new ResourceCompletableObserver() { + CompletableObserver consumer = new ResourceCompletableObserver() /* NFI */ { @Override public void onError(Throwable t) { } diff --git a/src/test/java/io/reactivex/rxjava4/internal/util/HalfSerializerObserverTest.java b/src/test/java/io/reactivex/rxjava4/internal/util/HalfSerializerObserverTest.java index 5ae73f6447..a7f39b0ca7 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/util/HalfSerializerObserverTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/util/HalfSerializerObserverTest.java @@ -38,7 +38,7 @@ public void reentrantOnNextOnNext() { final TestObserver to = new TestObserver(); - Observer observer = new Observer() { + Observer observer = new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { to.onSubscribe(d); @@ -82,7 +82,7 @@ public void reentrantOnNextOnError() { final TestObserver to = new TestObserver(); - Observer observer = new Observer() { + Observer observer = new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { to.onSubscribe(d); @@ -126,7 +126,7 @@ public void reentrantOnNextOnComplete() { final TestObserver to = new TestObserver(); - Observer observer = new Observer() { + Observer observer = new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { to.onSubscribe(d); @@ -171,7 +171,7 @@ public void reentrantErrorOnError() { final TestObserver to = new TestObserver(); - Observer observer = new Observer() { + Observer observer = new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { to.onSubscribe(d); diff --git a/src/test/java/io/reactivex/rxjava4/internal/util/HalfSerializerSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/internal/util/HalfSerializerSubscriberTest.java index df8250bd6b..af4572dbcc 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/util/HalfSerializerSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/util/HalfSerializerSubscriberTest.java @@ -44,7 +44,7 @@ public void reentrantOnNextOnNext() { final TestSubscriber ts = new TestSubscriber(); - FlowableSubscriber s = new FlowableSubscriber() { + FlowableSubscriber s = new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { ts.onSubscribe(s); @@ -88,7 +88,7 @@ public void reentrantOnNextOnError() { final TestSubscriber ts = new TestSubscriber(); - FlowableSubscriber s = new FlowableSubscriber() { + FlowableSubscriber s = new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { ts.onSubscribe(s); @@ -132,7 +132,7 @@ public void reentrantOnNextOnComplete() { final TestSubscriber ts = new TestSubscriber(); - FlowableSubscriber s = new FlowableSubscriber() { + FlowableSubscriber s = new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { ts.onSubscribe(s); @@ -177,7 +177,7 @@ public void reentrantErrorOnError() { final TestSubscriber ts = new TestSubscriber(); - FlowableSubscriber s = new FlowableSubscriber() { + FlowableSubscriber s = new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { ts.onSubscribe(s); diff --git a/src/test/java/io/reactivex/rxjava4/internal/util/MiscUtilTest.java b/src/test/java/io/reactivex/rxjava4/internal/util/MiscUtilTest.java index 8d44fdfc9c..2365d993ee 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/util/MiscUtilTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/util/MiscUtilTest.java @@ -248,7 +248,7 @@ public void appendOnlyLinkedArrayListForEachWhileBiFullChunkNoNext() throws Thro final List out = new ArrayList<>(); - list.forEachWhile(null, (state, value) -> { + list.forEachWhile(null, (_, value) -> { out.add(value); return false; // never terminate early }); diff --git a/src/test/java/io/reactivex/rxjava4/internal/util/QueueDrainHelperTest.java b/src/test/java/io/reactivex/rxjava4/internal/util/QueueDrainHelperTest.java index 076dcd5b2b..a17b95f519 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/util/QueueDrainHelperTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/util/QueueDrainHelperTest.java @@ -44,7 +44,7 @@ public void isCancelled() { @Test public void requestMaxInt() { - QueueDrainHelper.request(new Subscription() { + QueueDrainHelper.request(new Subscription() /* NFI */ { @Override public void request(long n) { assertEquals(Integer.MAX_VALUE, n); @@ -58,7 +58,7 @@ public void cancel() { @Test public void requestMinInt() { - QueueDrainHelper.request(new Subscription() { + QueueDrainHelper.request(new Subscription() /* NFI */ { @Override public void request(long n) { assertEquals(Long.MAX_VALUE, n); @@ -72,7 +72,7 @@ public void cancel() { @Test public void requestAlmostMaxInt() { - QueueDrainHelper.request(new Subscription() { + QueueDrainHelper.request(new Subscription() /* NFI */ { @Override public void request(long n) { assertEquals(Integer.MAX_VALUE - 1, n); @@ -154,7 +154,7 @@ public void postCompleteCancelled() { @Test public void postCompleteCancelledAfterOne() { - final TestSubscriber ts = new TestSubscriber() { + final TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -179,7 +179,7 @@ public void drainMaxLoopMissingBackpressure() { TestSubscriber ts = new TestSubscriber<>(); ts.onSubscribe(new BooleanSubscription()); - QueueDrain qd = new QueueDrain() { + QueueDrain qd = new QueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -234,7 +234,7 @@ public void drainMaxLoopMissingBackpressureWithResource() { TestSubscriber ts = new TestSubscriber<>(); ts.onSubscribe(new BooleanSubscription()); - QueueDrain qd = new QueueDrain() { + QueueDrain qd = new QueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -293,7 +293,7 @@ public void drainMaxLoopDontAccept() { TestSubscriber ts = new TestSubscriber<>(); ts.onSubscribe(new BooleanSubscription()); - QueueDrain qd = new QueueDrain() { + QueueDrain qd = new QueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -348,7 +348,7 @@ public void checkTerminatedDelayErrorEmpty() { TestSubscriber ts = new TestSubscriber<>(); ts.onSubscribe(new BooleanSubscription()); - QueueDrain qd = new QueueDrain() { + QueueDrain qd = new QueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -402,7 +402,7 @@ public void checkTerminatedDelayErrorNonEmpty() { TestSubscriber ts = new TestSubscriber<>(); ts.onSubscribe(new BooleanSubscription()); - QueueDrain qd = new QueueDrain() { + QueueDrain qd = new QueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -456,7 +456,7 @@ public void checkTerminatedDelayErrorEmptyError() { TestSubscriber ts = new TestSubscriber<>(); ts.onSubscribe(new BooleanSubscription()); - QueueDrain qd = new QueueDrain() { + QueueDrain qd = new QueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -510,7 +510,7 @@ public void checkTerminatedNonDelayErrorError() { TestSubscriber ts = new TestSubscriber<>(); ts.onSubscribe(new BooleanSubscription()); - QueueDrain qd = new QueueDrain() { + QueueDrain qd = new QueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -564,7 +564,7 @@ public void observerCheckTerminatedDelayErrorEmpty() { TestObserver to = new TestObserver<>(); to.onSubscribe(Disposable.empty()); - ObservableQueueDrain qd = new ObservableQueueDrain() { + ObservableQueueDrain qd = new ObservableQueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -607,7 +607,7 @@ public void observerCheckTerminatedDelayErrorEmptyResource() { TestObserver to = new TestObserver<>(); to.onSubscribe(Disposable.empty()); - ObservableQueueDrain qd = new ObservableQueueDrain() { + ObservableQueueDrain qd = new ObservableQueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -654,7 +654,7 @@ public void observerCheckTerminatedDelayErrorNonEmpty() { TestObserver to = new TestObserver<>(); to.onSubscribe(Disposable.empty()); - ObservableQueueDrain qd = new ObservableQueueDrain() { + ObservableQueueDrain qd = new ObservableQueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -697,7 +697,7 @@ public void observerCheckTerminatedDelayErrorEmptyError() { TestObserver to = new TestObserver<>(); to.onSubscribe(Disposable.empty()); - ObservableQueueDrain qd = new ObservableQueueDrain() { + ObservableQueueDrain qd = new ObservableQueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -740,7 +740,7 @@ public void observerCheckTerminatedNonDelayErrorError() { TestObserver to = new TestObserver<>(); to.onSubscribe(Disposable.empty()); - ObservableQueueDrain qd = new ObservableQueueDrain() { + ObservableQueueDrain qd = new ObservableQueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; @@ -783,7 +783,7 @@ public void observerCheckTerminatedNonDelayErrorErrorResource() { TestObserver to = new TestObserver<>(); to.onSubscribe(Disposable.empty()); - ObservableQueueDrain qd = new ObservableQueueDrain() { + ObservableQueueDrain qd = new ObservableQueueDrain() /* NFI */ { @Override public boolean cancelled() { return false; diff --git a/src/test/java/io/reactivex/rxjava4/maybe/MaybeTest.java b/src/test/java/io/reactivex/rxjava4/maybe/MaybeTest.java index 924b4aad41..746fbda786 100644 --- a/src/test/java/io/reactivex/rxjava4/maybe/MaybeTest.java +++ b/src/test/java/io/reactivex/rxjava4/maybe/MaybeTest.java @@ -270,7 +270,7 @@ public void deferReturnsNull() { @Test public void defer() { - Maybe source = Maybe.defer(new Supplier>() { + Maybe source = Maybe.defer(new Supplier>() /* NFI */ { int count; @Override public Maybe get() throws Exception { @@ -1926,7 +1926,7 @@ public void subscribeToOnComplete() { @Test public void subscribeWith() { - MaybeObserver mo = new MaybeObserver() { + MaybeObserver mo = new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -2570,7 +2570,7 @@ public void onTerminateDetach() throws Exception { long middle = usedMemoryNow(); - MaybeObserver observer = new MaybeObserver() { + MaybeObserver observer = new MaybeObserver() /* NFI */ { @SuppressWarnings("unused") Disposable u; diff --git a/src/test/java/io/reactivex/rxjava4/observable/ObservableErrorHandlingTests.java b/src/test/java/io/reactivex/rxjava4/observable/ObservableErrorHandlingTests.java index 4b70278fd9..d5804da245 100644 --- a/src/test/java/io/reactivex/rxjava4/observable/ObservableErrorHandlingTests.java +++ b/src/test/java/io/reactivex/rxjava4/observable/ObservableErrorHandlingTests.java @@ -35,7 +35,7 @@ public void onNextError() throws InterruptedException { final CountDownLatch latch = new CountDownLatch(1); final AtomicReference caughtError = new AtomicReference<>(); Observable o = Observable.interval(50, TimeUnit.MILLISECONDS); - Observer observer = new DefaultObserver() { + Observer observer = new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -71,7 +71,7 @@ public void onNextErrorAcrossThread() throws InterruptedException { final CountDownLatch latch = new CountDownLatch(1); final AtomicReference caughtError = new AtomicReference<>(); Observable o = Observable.interval(50, TimeUnit.MILLISECONDS); - Observer observer = new DefaultObserver() { + Observer observer = new DefaultObserver() /* NFI */ { @Override public void onComplete() { diff --git a/src/test/java/io/reactivex/rxjava4/observable/ObservableSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/observable/ObservableSubscriberTest.java index a8b34f0f0a..67a4f0184f 100644 --- a/src/test/java/io/reactivex/rxjava4/observable/ObservableSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/observable/ObservableSubscriberTest.java @@ -33,7 +33,8 @@ public class ObservableSubscriberTest extends RxJavaTest { @Test public void onStartCalledOnceViaSubscribe() { final AtomicInteger c = new AtomicInteger(); - Observable.just(1, 2, 3, 4).take(2).subscribe(new DefaultObserver() { + Observable.just(1, 2, 3, 4).take(2) + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onStart() { @@ -62,7 +63,8 @@ public void onNext(Integer t) { @Test public void onStartCalledOnceViaUnsafeSubscribe() { final AtomicInteger c = new AtomicInteger(); - Observable.just(1, 2, 3, 4).take(2).subscribe(new DefaultObserver() { + Observable.just(1, 2, 3, 4).take(2) + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onStart() { @@ -91,7 +93,8 @@ public void onNext(Integer t) { @Test public void onStartCalledOnceViaLift() { final AtomicInteger c = new AtomicInteger(); - Observable.just(1, 2, 3, 4).lift((ObservableOperator) child -> new DefaultObserver() { + Observable.just(1, 2, 3, 4) + .lift((ObservableOperator) child -> new DefaultObserver() /* NFI */ { @Override public void onStart() { diff --git a/src/test/java/io/reactivex/rxjava4/observable/ObservableTest.java b/src/test/java/io/reactivex/rxjava4/observable/ObservableTest.java index c77e50e5fe..f4af0a8e20 100644 --- a/src/test/java/io/reactivex/rxjava4/observable/ObservableTest.java +++ b/src/test/java/io/reactivex/rxjava4/observable/ObservableTest.java @@ -327,7 +327,7 @@ public void customObservableWithErrorInObserverAsynchronous() throws Interrupted // FIXME custom built??? Observable.just("1", "2", "three", "4") .subscribeOn(Schedulers.newThread()) - .safeSubscribe(new DefaultObserver() { + .safeSubscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { System.out.println("completed"); @@ -374,7 +374,7 @@ public void customObservableWithErrorInObserverSynchronous() { // FIXME custom built??? Observable.just("1", "2", "three", "4") - .safeSubscribe(new DefaultObserver() { + .safeSubscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -416,7 +416,7 @@ public void customObservableWithErrorInObservableSynchronous() { final AtomicReference error = new AtomicReference<>(); // FIXME custom built??? Observable.just("1", "2").concatWith(Observable.error(NumberFormatException::new)) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -584,7 +584,7 @@ public void takeWithErrorInObserver() { final AtomicInteger count = new AtomicInteger(); final AtomicReference error = new AtomicReference<>(); Observable.just("1", "2", "three", "4").take(3) - .safeSubscribe(new DefaultObserver() { + .safeSubscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -901,28 +901,6 @@ public void emptyIsEmpty() { verify(w, never()).onError(any(Throwable.class)); } -// FIXME this test doesn't make sense -// @Test // cf. https://github.com/ReactiveX/RxJava/issues/2599 -// public void testSubscribingSubscriberAsObserverMaintainsSubscriptionChain() { -// TestObserver observer = new TestObserver(); -// Subscription subscription = Observable.just("event").subscribe((Observer) observer); -// subscription.unsubscribe(); -// -// subscriber.assertUnsubscribed(); -// } - -// FIXME subscribers can't throw -// @Test(expected=OnErrorNotImplementedException.class) -// public void testForEachWithError() { -// Observable.error(new Exception("boo")) -// // -// .forEach(new Action1() { -// @Override -// public void call(Object t) { -// //do nothing -// }}); -// } - @Test public void extend() { final TestObserver to = new TestObserver<>(); diff --git a/src/test/java/io/reactivex/rxjava4/observers/SafeObserverTest.java b/src/test/java/io/reactivex/rxjava4/observers/SafeObserverTest.java index fe22a461ee..0844b2d72d 100644 --- a/src/test/java/io/reactivex/rxjava4/observers/SafeObserverTest.java +++ b/src/test/java/io/reactivex/rxjava4/observers/SafeObserverTest.java @@ -94,7 +94,7 @@ public void onNextOnErrorFailure() { } private static Observer OBSERVER_ONNEXT_FAIL(final AtomicReference onError) { - return new DefaultObserver() { + return new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -115,7 +115,7 @@ public void onNext(String args) { } private static Observer OBSERVER_ONNEXT_ONERROR_FAIL() { - return new DefaultObserver() { + return new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -136,7 +136,7 @@ public void onNext(String args) { } private static Observer OBSERVER_ONERROR_FAIL() { - return new DefaultObserver() { + return new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -157,7 +157,7 @@ public void onNext(String args) { } private static Observer OBSERVER_ONCOMPLETED_FAIL(final AtomicReference onError) { - return new DefaultObserver() { + return new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -186,7 +186,7 @@ static class SafeObserverTestException extends RuntimeException { @Test public void actual() { - Observer actual = new DefaultObserver() { + Observer actual = new DefaultObserver() /* NFI */ { @Override public void onNext(Integer t) { } diff --git a/src/test/java/io/reactivex/rxjava4/observers/SerializedObserverTest.java b/src/test/java/io/reactivex/rxjava4/observers/SerializedObserverTest.java index e5dfa80473..c10130c913 100644 --- a/src/test/java/io/reactivex/rxjava4/observers/SerializedObserverTest.java +++ b/src/test/java/io/reactivex/rxjava4/observers/SerializedObserverTest.java @@ -277,7 +277,7 @@ public void notificationDelay() throws InterruptedException { final CountDownLatch latch = new CountDownLatch(1); final CountDownLatch running = new CountDownLatch(2); - TestObserverEx to = new TestObserverEx<>(new DefaultObserver() { + TestObserverEx to = new TestObserverEx<>(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -358,7 +358,7 @@ public void onNext(String t) { @Test public void threadStarvation() throws InterruptedException { - TestObserver to = new TestObserver<>(new DefaultObserver() { + TestObserver to = new TestObserver<>(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -386,7 +386,7 @@ public void onNext(String t) { AtomicInteger p2 = new AtomicInteger(); o.onSubscribe(Disposable.empty()); - DisposableObserver as1 = new DisposableObserver() { + DisposableObserver as1 = new DisposableObserver() /* NFI */ { @Override public void onNext(String t) { o.onNext(t); @@ -403,7 +403,7 @@ public void onComplete() { } }; - DisposableObserver as2 = new DisposableObserver() { + DisposableObserver as2 = new DisposableObserver() /* NFI */ { @Override public void onNext(String t) { o.onNext(t); @@ -834,7 +834,7 @@ public void errorReentry() { try { final AtomicReference> serial = new AtomicReference<>(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer v) { serial.get().onError(new TestException()); @@ -861,7 +861,7 @@ public void onNext(Integer v) { public void completeReentry() { final AtomicReference> serial = new AtomicReference<>(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer v) { serial.get().onComplete(); @@ -1094,7 +1094,7 @@ public void nullOnNext() { @SuppressUndeliverable public void onErrorQueuedUp() { AtomicReference> soRef = new AtomicReference<>(); - TestObserverEx to = new TestObserverEx() { + TestObserverEx to = new TestObserverEx() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/observers/TestObserverTest.java b/src/test/java/io/reactivex/rxjava4/observers/TestObserverTest.java index eb51e6b01c..cf9603dcc0 100644 --- a/src/test/java/io/reactivex/rxjava4/observers/TestObserverTest.java +++ b/src/test/java/io/reactivex/rxjava4/observers/TestObserverTest.java @@ -752,7 +752,7 @@ public void completeWithoutOnSubscribe() { @Test public void completeDelegateThrows() { - TestObserver to = new TestObserver<>(new Observer() { + TestObserver to = new TestObserver<>(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -788,7 +788,7 @@ public void onComplete() { @Test public void errorDelegateThrows() { - TestObserver to = new TestObserver<>(new Observer() { + TestObserver to = new TestObserver<>(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/operators/SimpleQueueTest.java b/src/test/java/io/reactivex/rxjava4/operators/SimpleQueueTest.java index d57d83bb73..a113b76c93 100644 --- a/src/test/java/io/reactivex/rxjava4/operators/SimpleQueueTest.java +++ b/src/test/java/io/reactivex/rxjava4/operators/SimpleQueueTest.java @@ -112,7 +112,7 @@ public void mpscOfferPollRace() throws Exception { final AtomicInteger c = new AtomicInteger(3); - Thread t1 = new Thread(new Runnable() { + Thread t1 = new Thread(new Runnable() /* NFI */ { int i; @Override public void run() { @@ -126,7 +126,7 @@ public void run() { }); t1.start(); - Thread t2 = new Thread(new Runnable() { + Thread t2 = new Thread(new Runnable() /* NFI */ { int i = 10000; @Override public void run() { @@ -140,7 +140,7 @@ public void run() { }); t2.start(); - Runnable r3 = new Runnable() { + Runnable r3 = new Runnable() /* NFI */ { int i = 20000; @Override public void run() { diff --git a/src/test/java/io/reactivex/rxjava4/parallel/ParallelDoOnNextTryTest.java b/src/test/java/io/reactivex/rxjava4/parallel/ParallelDoOnNextTryTest.java index 3720a7e3bd..789a0b09f6 100644 --- a/src/test/java/io/reactivex/rxjava4/parallel/ParallelDoOnNextTryTest.java +++ b/src/test/java/io/reactivex/rxjava4/parallel/ParallelDoOnNextTryTest.java @@ -127,7 +127,7 @@ public void doOnNextFailWithStop() { public void doOnNextFailWithRetry() { Flowable.range(0, 2) .parallel(1) - .doOnNext(new Consumer() { + .doOnNext(new Consumer() /* NFI */ { int count; @Override public void accept(Integer v) throws Exception { @@ -247,7 +247,7 @@ public void doOnNextFailWithStopConditional() { public void doOnNextFailWithRetryConditional() { Flowable.range(0, 2) .parallel(1) - .doOnNext(new Consumer() { + .doOnNext(new Consumer() /* NFI */ { int count; @Override public void accept(Integer v) throws Exception { diff --git a/src/test/java/io/reactivex/rxjava4/parallel/ParallelFilterTryTest.java b/src/test/java/io/reactivex/rxjava4/parallel/ParallelFilterTryTest.java index f3e0b9e402..778caddfc5 100644 --- a/src/test/java/io/reactivex/rxjava4/parallel/ParallelFilterTryTest.java +++ b/src/test/java/io/reactivex/rxjava4/parallel/ParallelFilterTryTest.java @@ -132,7 +132,7 @@ public void filterFailWithStop() { public void filterFailWithRetry() { Flowable.range(0, 2) .parallel(1) - .filter(new Predicate() { + .filter(new Predicate() /* NFI */ { int count; @Override public boolean test(Integer v) throws Exception { @@ -230,7 +230,7 @@ public void filterFailWithStopConditional() { public void filterFailWithRetryConditional() { Flowable.range(0, 2) .parallel(1) - .filter(new Predicate() { + .filter(new Predicate() /* NFI */ { int count; @Override public boolean test(Integer v) throws Exception { diff --git a/src/test/java/io/reactivex/rxjava4/parallel/ParallelFromPublisherTest.java b/src/test/java/io/reactivex/rxjava4/parallel/ParallelFromPublisherTest.java index 07a2349246..cbdc84e8b7 100644 --- a/src/test/java/io/reactivex/rxjava4/parallel/ParallelFromPublisherTest.java +++ b/src/test/java/io/reactivex/rxjava4/parallel/ParallelFromPublisherTest.java @@ -38,7 +38,7 @@ public class ParallelFromPublisherTest extends RxJavaTest { @Test public void sourceOverflow() { - new Flowable() { + new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -216,7 +216,7 @@ public void doubleOnSubscribe() { @SuppressWarnings("unchecked") @Test public void requestUnboundedRace() { - FlowableSubscriber fs = new FlowableSubscriber() { + FlowableSubscriber fs = new FlowableSubscriber() /* NFI */ { @Override public void onNext(@NonNull Integer t) { @@ -249,7 +249,7 @@ public void onSubscribe(@NonNull Subscription s) { @SuppressWarnings("unchecked") @Test public void requestRace() { - FlowableSubscriber fs = new FlowableSubscriber() { + FlowableSubscriber fs = new FlowableSubscriber() /* NFI */ { @Override public void onNext(@NonNull Integer t) { diff --git a/src/test/java/io/reactivex/rxjava4/parallel/ParallelJoinTest.java b/src/test/java/io/reactivex/rxjava4/parallel/ParallelJoinTest.java index 16ff2e38d3..15f480696e 100644 --- a/src/test/java/io/reactivex/rxjava4/parallel/ParallelJoinTest.java +++ b/src/test/java/io/reactivex/rxjava4/parallel/ParallelJoinTest.java @@ -32,7 +32,7 @@ public class ParallelJoinTest extends RxJavaTest { @Test public void overflowFastpath() { - new ParallelFlowable() { + new ParallelFlowable() /* NFI */ { @Override public void subscribe(Subscriber[] subscribers) { subscribers[0].onSubscribe(new BooleanSubscription()); @@ -56,7 +56,7 @@ public void overflowSlowpath() { @SuppressWarnings("unchecked") final Subscriber[] subs = new Subscriber[1]; - TestSubscriber ts = new TestSubscriber(1) { + TestSubscriber ts = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -65,7 +65,7 @@ public void onNext(Integer t) { } }; - new ParallelFlowable() { + new ParallelFlowable() /* NFI */ { @Override public void subscribe(Subscriber[] subscribers) { subs[0] = subscribers[0]; @@ -95,7 +95,7 @@ public void emptyBackpressured() { @Test public void overflowFastpathDelayError() { - new ParallelFlowable() { + new ParallelFlowable() /* NFI */ { @Override public void subscribe(Subscriber[] subscribers) { subscribers[0].onSubscribe(new BooleanSubscription()); @@ -119,7 +119,7 @@ public void overflowSlowpathDelayError() { @SuppressWarnings("unchecked") final Subscriber[] subs = new Subscriber[1]; - TestSubscriber ts = new TestSubscriber(1) { + TestSubscriber ts = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -130,7 +130,7 @@ public void onNext(Integer t) { } }; - new ParallelFlowable() { + new ParallelFlowable() /* NFI */ { @Override public void subscribe(Subscriber[] subscribers) { subs[0] = subscribers[0]; @@ -241,7 +241,7 @@ public void delayErrorCancelBackpressured2() { @Test public void consumerCancelsAfterOne() { - TestSubscriber ts = new TestSubscriber(1) { + TestSubscriber ts = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -260,7 +260,7 @@ public void onNext(Integer t) { @Test public void delayErrorConsumerCancelsAfterOne() { - TestSubscriber ts = new TestSubscriber(1) { + TestSubscriber ts = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -375,7 +375,7 @@ public void delayErrorOneItemNext() { public void onNextWhileProcessingSlowPath() { PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(@NonNull Integer t) { super.onNext(t); @@ -399,7 +399,7 @@ public void onNext(@NonNull Integer t) { public void delayErrorOnNextWhileProcessingSlowPath() { PublishProcessor pp = PublishProcessor.create(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(@NonNull Integer t) { super.onNext(t); @@ -435,14 +435,14 @@ public void onNextMissingBackpressureRace() throws Throwable { AtomicReference> ref1 = new AtomicReference<>(); AtomicReference> ref2 = new AtomicReference<>(); - Flowable f1 = new Flowable() { + Flowable f1 = new Flowable() /* NFI */ { @Override public void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); ref1.set(s); } }; - Flowable f2 = new Flowable() { + Flowable f2 = new Flowable() /* NFI */ { @Override public void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -479,14 +479,14 @@ public void onNextMissingBackpressureDelayErrorRace() throws Throwable { AtomicReference> ref1 = new AtomicReference<>(); AtomicReference> ref2 = new AtomicReference<>(); - Flowable f1 = new Flowable() { + Flowable f1 = new Flowable() /* NFI */ { @Override public void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); ref1.set(s); } }; - Flowable f2 = new Flowable() { + Flowable f2 = new Flowable() /* NFI */ { @Override public void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); diff --git a/src/test/java/io/reactivex/rxjava4/parallel/ParallelMapTest.java b/src/test/java/io/reactivex/rxjava4/parallel/ParallelMapTest.java index ff2a257cf1..46f9f26313 100644 --- a/src/test/java/io/reactivex/rxjava4/parallel/ParallelMapTest.java +++ b/src/test/java/io/reactivex/rxjava4/parallel/ParallelMapTest.java @@ -176,7 +176,7 @@ public void doubleOnSubscribe() { @Test public void conditionalCancelIgnored() { - Flowable f = new Flowable() { + Flowable f = new Flowable() /* NFI */ { @Override protected void subscribeActual(@NonNull Subscriber<@NonNull ? super @NonNull Integer> s) { @SuppressWarnings("unchecked") diff --git a/src/test/java/io/reactivex/rxjava4/parallel/ParallelMapTryTest.java b/src/test/java/io/reactivex/rxjava4/parallel/ParallelMapTryTest.java index a343a106ad..3d811f1f0a 100644 --- a/src/test/java/io/reactivex/rxjava4/parallel/ParallelMapTryTest.java +++ b/src/test/java/io/reactivex/rxjava4/parallel/ParallelMapTryTest.java @@ -107,7 +107,7 @@ public void mapFailWithStop() { public void mapFailWithRetry() { Flowable.range(0, 2) .parallel(1) - .map(new Function() { + .map(new Function() /* NFI */ { int count; @Override public Integer apply(Integer v) throws Exception { @@ -205,7 +205,7 @@ public void mapFailWithStopConditional() { public void mapFailWithRetryConditional() { Flowable.range(0, 2) .parallel(1) - .map(new Function() { + .map(new Function() /* NFI */ { int count; @Override public Integer apply(Integer v) throws Exception { diff --git a/src/test/java/io/reactivex/rxjava4/parallel/ParallelRunOnTest.java b/src/test/java/io/reactivex/rxjava4/parallel/ParallelRunOnTest.java index d75846ef20..164907ef93 100644 --- a/src/test/java/io/reactivex/rxjava4/parallel/ParallelRunOnTest.java +++ b/src/test/java/io/reactivex/rxjava4/parallel/ParallelRunOnTest.java @@ -75,7 +75,7 @@ public void conditionalPath() { @Test public void missingBackpressure() { - new ParallelFlowable() { + new ParallelFlowable() /* NFI */ { @Override public int parallelism() { return 1; @@ -238,7 +238,7 @@ public void nextCancelRaceBackpressuredConditional() { @Test public void normalCancelAfterRequest1() { - TestSubscriber ts = new TestSubscriber(1) { + TestSubscriber ts = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -259,7 +259,7 @@ public void onNext(Integer t) { @Test public void conditionalCancelAfterRequest1() { - TestSubscriber ts = new TestSubscriber(1) { + TestSubscriber ts = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/plugins/RxJavaPluginsTest.java b/src/test/java/io/reactivex/rxjava4/plugins/RxJavaPluginsTest.java index a80aff6690..050c7787db 100644 --- a/src/test/java/io/reactivex/rxjava4/plugins/RxJavaPluginsTest.java +++ b/src/test/java/io/reactivex/rxjava4/plugins/RxJavaPluginsTest.java @@ -475,7 +475,7 @@ public void flowableCreate() { @Test public void observableStart() { try { - RxJavaPlugins.setOnObservableSubscribe((_, t) -> new Observer() { + RxJavaPlugins.setOnObservableSubscribe((_, t) -> new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -520,7 +520,7 @@ public void onComplete() { @Test public void flowableStart() { try { - RxJavaPlugins.setOnFlowableSubscribe((_, t) -> new Subscriber() { + RxJavaPlugins.setOnFlowableSubscribe((_, t) -> new Subscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -566,7 +566,7 @@ public void parallelFlowableStart() { try { RxJavaPlugins.setOnParallelSubscribe((_, t) -> { var result = new Subscriber[] { - new Subscriber() { + new Subscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -639,7 +639,7 @@ public void singleCreate() { @Test public void singleStart() { try { - RxJavaPlugins.setOnSingleSubscribe((_, t) -> new SingleObserver() { + RxJavaPlugins.setOnSingleSubscribe((_, t) -> new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -699,7 +699,7 @@ public void completableCreate() { @Test public void completableStart() { try { - RxJavaPlugins.setOnCompletableSubscribe((_, t) -> new CompletableObserver() { + RxJavaPlugins.setOnCompletableSubscribe((_, t) -> new CompletableObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { t.onSubscribe(d); @@ -968,14 +968,14 @@ public void clearIsPassthrough() { assertNull(RxJavaPlugins.onAssembly((ConnectableFlowable)null)); - Observable oos = new Observable() { + Observable oos = new Observable( /* NFI */) /* NFI */ { @Override public void subscribeActual(Observer t) { } }; - Flowable fos = new Flowable() { + Flowable fos = new Flowable() /* NFI */ { @Override public void subscribeActual(Subscriber t) { @@ -988,7 +988,7 @@ public void subscribeActual(Subscriber t) { assertNull(RxJavaPlugins.onAssembly((Single)null)); - Single sos = new Single() { + Single sos = new Single() /* NFI */ { @Override public void subscribeActual(SingleObserver t) { @@ -999,7 +999,7 @@ public void subscribeActual(SingleObserver t) { assertNull(RxJavaPlugins.onAssembly((Completable)null)); - Completable cos = new Completable() { + Completable cos = new Completable() /* NFI */ { @Override public void subscribeActual(CompletableObserver t) { @@ -1010,7 +1010,7 @@ public void subscribeActual(CompletableObserver t) { assertNull(RxJavaPlugins.onAssembly((Maybe)null)); - Maybe myb = new Maybe() { + Maybe myb = new Maybe() /* NFI */ { @Override public void subscribeActual(MaybeObserver t) { @@ -1128,7 +1128,7 @@ static void assertNPE(List list, int index) { @Test public void overrideConnectableObservable() { try { - RxJavaPlugins.setOnConnectableObservableAssembly(_ -> new ConnectableObservable() { + RxJavaPlugins.setOnConnectableObservableAssembly(_ -> new ConnectableObservable() /* NFI */ { @Override public void connect(Consumer connection) { @@ -1172,7 +1172,7 @@ protected void subscribeActual(Observer observer) { @Test public void overrideConnectableFlowable() { try { - RxJavaPlugins.setOnConnectableFlowableAssembly(_ -> new ConnectableFlowable() { + RxJavaPlugins.setOnConnectableFlowableAssembly(_ -> new ConnectableFlowable() /* NFI */ { @Override public void connect(Consumer connection) { @@ -1325,7 +1325,7 @@ public void maybeCreate() { @SuppressWarnings("rawtypes") public void maybeStart() { try { - RxJavaPlugins.setOnMaybeSubscribe((_, t) -> new MaybeObserver() { + RxJavaPlugins.setOnMaybeSubscribe((_, t) -> new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { t.onSubscribe(d); diff --git a/src/test/java/io/reactivex/rxjava4/processors/AsyncProcessorTest.java b/src/test/java/io/reactivex/rxjava4/processors/AsyncProcessorTest.java index fcc2c83872..1df123f121 100644 --- a/src/test/java/io/reactivex/rxjava4/processors/AsyncProcessorTest.java +++ b/src/test/java/io/reactivex/rxjava4/processors/AsyncProcessorTest.java @@ -434,7 +434,7 @@ public void onNextCrossCancel() { AsyncProcessor p = AsyncProcessor.create(); final TestSubscriber ts2 = new TestSubscriber<>(); - TestSubscriber ts1 = new TestSubscriber() { + TestSubscriber ts1 = new TestSubscriber() /* NFI */ { @Override public void onNext(Object t) { ts2.cancel(); @@ -458,7 +458,7 @@ public void onErrorCrossCancel() { AsyncProcessor p = AsyncProcessor.create(); final TestSubscriber ts2 = new TestSubscriber<>(); - TestSubscriber ts1 = new TestSubscriber() { + TestSubscriber ts1 = new TestSubscriber() /* NFI */ { @Override public void onError(Throwable t) { ts2.cancel(); @@ -480,7 +480,7 @@ public void onCompleteCrossCancel() { AsyncProcessor p = AsyncProcessor.create(); final TestSubscriber ts2 = new TestSubscriber<>(); - TestSubscriber ts1 = new TestSubscriber() { + TestSubscriber ts1 = new TestSubscriber() /* NFI */ { @Override public void onComplete() { ts2.cancel(); diff --git a/src/test/java/io/reactivex/rxjava4/processors/BehaviorProcessorTest.java b/src/test/java/io/reactivex/rxjava4/processors/BehaviorProcessorTest.java index 0824baed65..aaf79bb9b5 100644 --- a/src/test/java/io/reactivex/rxjava4/processors/BehaviorProcessorTest.java +++ b/src/test/java/io/reactivex/rxjava4/processors/BehaviorProcessorTest.java @@ -256,7 +256,7 @@ public void unsubscriptionCase() { System.out.printf("Turn: %d%n", i); src.firstElement().toFlowable() .flatMap((Function>) t1 -> Flowable.just(t1 + ", " + t1)) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onNext(String t) { subscriber.onNext(t); @@ -383,7 +383,7 @@ public void emissionSubscriptionRace() throws Exception { final AtomicReference o = new AtomicReference<>(); rs.subscribeOn(s).observeOn(Schedulers.cached()) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { diff --git a/src/test/java/io/reactivex/rxjava4/processors/MulticastProcessorTest.java b/src/test/java/io/reactivex/rxjava4/processors/MulticastProcessorTest.java index db0889a098..cf6a7d5a38 100644 --- a/src/test/java/io/reactivex/rxjava4/processors/MulticastProcessorTest.java +++ b/src/test/java/io/reactivex/rxjava4/processors/MulticastProcessorTest.java @@ -231,7 +231,7 @@ public void crossCancel() { final TestSubscriber ts1 = new TestSubscriber<>(); - TestSubscriber ts2 = new TestSubscriber() { + TestSubscriber ts2 = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -259,7 +259,7 @@ public void crossCancelError() { final TestSubscriber ts1 = new TestSubscriber<>(); - TestSubscriber ts2 = new TestSubscriber() { + TestSubscriber ts2 = new TestSubscriber() /* NFI */ { @Override public void onError(Throwable t) { super.onError(t); @@ -287,7 +287,7 @@ public void crossCancelComplete() { final TestSubscriber ts1 = new TestSubscriber<>(); - TestSubscriber ts2 = new TestSubscriber() { + TestSubscriber ts2 = new TestSubscriber() /* NFI */ { @Override public void onComplete() { super.onComplete(); @@ -316,7 +316,7 @@ public void crossCancel1() { final TestSubscriber ts1 = new TestSubscriber<>(1); - TestSubscriber ts2 = new TestSubscriber(1) { + TestSubscriber ts2 = new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -345,7 +345,7 @@ public void requestCancel() { try { MulticastProcessor mp = MulticastProcessor.create(false); - mp.subscribe(new FlowableSubscriber() { + mp.subscribe(new FlowableSubscriber() /* NFI */ { @Override public void onNext(Integer t) { diff --git a/src/test/java/io/reactivex/rxjava4/processors/PublishProcessorTest.java b/src/test/java/io/reactivex/rxjava4/processors/PublishProcessorTest.java index 8a01a27194..00aa4da51d 100644 --- a/src/test/java/io/reactivex/rxjava4/processors/PublishProcessorTest.java +++ b/src/test/java/io/reactivex/rxjava4/processors/PublishProcessorTest.java @@ -296,7 +296,7 @@ public void unsubscriptionCase() { System.out.printf("Turn: %d%n", i); src.firstElement().toFlowable() .flatMap((Function>) t1 -> Flowable.just(t1 + ", " + t1)) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onNext(String t) { subscriber.onNext(t); @@ -394,7 +394,7 @@ public void requestValidation() { @Test public void crossCancel() { final TestSubscriber ts1 = new TestSubscriber<>(); - TestSubscriber ts2 = new TestSubscriber() { + TestSubscriber ts2 = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -418,7 +418,7 @@ public void onNext(Integer t) { @SuppressUndeliverable public void crossCancelOnError() { final TestSubscriber ts1 = new TestSubscriber<>(); - TestSubscriber ts2 = new TestSubscriber() { + TestSubscriber ts2 = new TestSubscriber() /* NFI */ { @Override public void onError(Throwable t) { super.onError(t); @@ -441,7 +441,7 @@ public void onError(Throwable t) { @Test public void crossCancelOnComplete() { final TestSubscriber ts1 = new TestSubscriber<>(); - TestSubscriber ts2 = new TestSubscriber() { + TestSubscriber ts2 = new TestSubscriber() /* NFI */ { @Override public void onComplete() { super.onComplete(); @@ -482,7 +482,7 @@ public void onSubscribeCancelsImmediately() { TestSubscriber ts = pp.test(); - pp.subscribe(new FlowableSubscriber() { + pp.subscribe(new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { diff --git a/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorBoundedConcurrencyTest.java b/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorBoundedConcurrencyTest.java index fd67cbb4f7..a3add06992 100644 --- a/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorBoundedConcurrencyTest.java +++ b/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorBoundedConcurrencyTest.java @@ -48,7 +48,7 @@ public void replaySubjectConcurrentSubscribersDoingReplayDontBlockEachOther() th // it's been played through once so now it will all be replays final CountDownLatch slowLatch = new CountDownLatch(1); Thread slowThread = new Thread(() -> { - Subscriber slow = new DefaultSubscriber() { + Subscriber slow = new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -85,7 +85,7 @@ public void onNext(Long args) { Thread fastThread = new Thread(() -> { final CountDownLatch fastLatch = new CountDownLatch(1); - Subscriber fast = new DefaultSubscriber() { + Subscriber fast = new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -313,7 +313,7 @@ public void replaySubjectEmissionSubscriptionRace() throws Exception { .subscribeOn(s) .observeOn(Schedulers.cached()) // .doOnNext(e -> System.out.println(">>> " + j)) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override protected void onStart() { diff --git a/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorConcurrencyTest.java b/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorConcurrencyTest.java index 88bdcc8f7e..4073db98da 100644 --- a/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorConcurrencyTest.java +++ b/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorConcurrencyTest.java @@ -48,7 +48,7 @@ public void replaySubjectConcurrentSubscribersDoingReplayDontBlockEachOther() th // it's been played through once so now it will all be replays final CountDownLatch slowLatch = new CountDownLatch(1); Thread slowThread = new Thread(() -> { - Subscriber slow = new DefaultSubscriber() { + Subscriber slow = new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -85,7 +85,7 @@ public void onNext(Long args) { Thread fastThread = new Thread(() -> { final CountDownLatch fastLatch = new CountDownLatch(1); - Subscriber fast = new DefaultSubscriber() { + Subscriber fast = new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -305,7 +305,7 @@ public void replaySubjectEmissionSubscriptionRace() throws Exception { final AtomicReference o = new AtomicReference<>(); rs.subscribeOn(s).observeOn(Schedulers.cached()) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { diff --git a/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorTest.java b/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorTest.java index f7843cc718..3492e9faba 100644 --- a/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorTest.java +++ b/src/test/java/io/reactivex/rxjava4/processors/ReplayProcessorTest.java @@ -264,7 +264,7 @@ private void assertObservedUntilTwo(Subscriber subscriber) { public void newSubscriberDoesntBlockExisting() throws InterruptedException { final AtomicReference lastValueForSubscriber1 = new AtomicReference<>(); - Subscriber subscriber1 = new DefaultSubscriber() { + Subscriber subscriber1 = new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -288,7 +288,7 @@ public void onNext(String v) { final CountDownLatch oneReceived = new CountDownLatch(1); final CountDownLatch makeSlow = new CountDownLatch(1); final CountDownLatch completed = new CountDownLatch(1); - Subscriber subscriber2 = new DefaultSubscriber() { + Subscriber subscriber2 = new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -383,7 +383,7 @@ public void unsubscriptionCase() { System.out.printf("Turn: %d%n", i); src.firstElement().toFlowable() .flatMap((Function>) t1 -> Flowable.just(t1 + ", " + t1)) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onNext(String t) { System.out.println(t); @@ -415,7 +415,7 @@ public void terminateOnce() { final Subscriber subscriber = TestHelper.mockSubscriber(); - source.subscribe(new DefaultSubscriber() { + source.subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onNext(Integer t) { @@ -1173,7 +1173,7 @@ public void takeSizeAndTime2() { rp.onNext(2); rp.onNext(3); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(@NonNull Integer t) { super.onNext(t); @@ -1209,7 +1209,7 @@ public void takeSize2() { rp.onNext(2); rp.onNext(3); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(@NonNull Integer t) { super.onNext(t); @@ -1229,7 +1229,7 @@ public void reentrantDrain() { final ReplayProcessor rp = ReplayProcessor.createWithTimeAndSize(1, TimeUnit.SECONDS, scheduler, 2); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1253,7 +1253,7 @@ public void reentrantDrainBackpressured() { final ReplayProcessor rp = ReplayProcessor.createWithTimeAndSize(1, TimeUnit.SECONDS, scheduler, 2); - TestSubscriber ts = new TestSubscriber(1L) { + TestSubscriber ts = new TestSubscriber(1L) /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { @@ -1431,7 +1431,7 @@ public void timeAndSizeBoundZeroRequestError() { } TestSubscriber take1AndCancel() { - return new TestSubscriber(1) { + return new TestSubscriber(1) /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/processors/SerializedProcessorTest.java b/src/test/java/io/reactivex/rxjava4/processors/SerializedProcessorTest.java index 09177ff664..26182e3597 100644 --- a/src/test/java/io/reactivex/rxjava4/processors/SerializedProcessorTest.java +++ b/src/test/java/io/reactivex/rxjava4/processors/SerializedProcessorTest.java @@ -590,7 +590,7 @@ public void onSubscribeOnSubscribeRace() { public void onErrorQueued() { FlowableProcessor sp = PublishProcessor.create().toSerialized(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(@NonNull Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java b/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java index b0349c66ad..d2c99bf76d 100644 --- a/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java +++ b/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java @@ -52,7 +52,7 @@ public final void unSubscribeForScheduler() throws InterruptedException { }) .subscribeOn(getScheduler()) .observeOn(getScheduler()) - .subscribe(new DefaultSubscriber() { + .subscribe(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { System.out.println("--- completed"); @@ -93,37 +93,30 @@ public void unsubscribeRecursiveScheduleFromOutside() throws InterruptedExceptio final AtomicInteger counter = new AtomicInteger(); final Worker inner = getScheduler().createWorker(); try { - inner.schedule(new Runnable() { + inner.schedule(() -> inner.schedule(new Runnable() /* NFI */ { + + int i; @Override public void run() { - inner.schedule(new Runnable() { - - int i; - - @Override - public void run() { - System.out.println("Run: " + i++); - if (i == 10) { - latch.countDown(); - try { - // wait for unsubscribe to finish so we are not racing it - unsubscribeLatch.await(); - } catch (InterruptedException e) { - // we expect the countDown if unsubscribe is not working - // or to be interrupted if unsubscribe is successful since - // unsubscribe will interrupt it as it is calling Future.cancel(true) - // so we will ignore the stacktrace - } - } - - counter.incrementAndGet(); - inner.schedule(this); + System.out.println("Run: " + i++); + if (i == 10) { + latch.countDown(); + try { + // wait for unsubscribe to finish so we are not racing it + unsubscribeLatch.await(); + } catch (InterruptedException e) { + // we expect the countDown if unsubscribe is not working + // or to be interrupted if unsubscribe is successful since + // unsubscribe will interrupt it as it is calling Future.cancel(true) + // so we will ignore the stacktrace } - }); - } + } - }); + counter.incrementAndGet(); + inner.schedule(this); + } + })); latch.await(); inner.dispose(); @@ -141,28 +134,21 @@ public void unsubscribeRecursiveScheduleFromInside() throws InterruptedException final AtomicInteger counter = new AtomicInteger(); final Worker inner = getScheduler().createWorker(); try { - inner.schedule(new Runnable() { + inner.schedule(() -> inner.schedule(new Runnable() /* NFI */ { + + int i; @Override public void run() { - inner.schedule(new Runnable() { - - int i; - - @Override - public void run() { - System.out.println("Run: " + i++); - if (i == 10) { - inner.dispose(); - } + System.out.println("Run: " + i++); + if (i == 10) { + inner.dispose(); + } - counter.incrementAndGet(); - inner.schedule(this); - } - }); + counter.incrementAndGet(); + inner.schedule(this); } - - }); + })); unsubscribeLatch.countDown(); Thread.sleep(200); // let time pass to see if the scheduler is still doing work @@ -180,35 +166,29 @@ public void unsubscribeRecursiveScheduleWithDelay() throws InterruptedException final Worker inner = getScheduler().createWorker(); try { - inner.schedule(new Runnable() { + inner.schedule(() -> inner.schedule(new Runnable() /* NFI */ { + + long i = 1L; @Override public void run() { - inner.schedule(new Runnable() { - - long i = 1L; - - @Override - public void run() { - if (i++ == 10) { - latch.countDown(); - try { - // wait for unsubscribe to finish so we are not racing it - unsubscribeLatch.await(); - } catch (InterruptedException e) { - // we expect the countDown if unsubscribe is not working - // or to be interrupted if unsubscribe is successful since - // unsubscribe will interrupt it as it is calling Future.cancel(true) - // so we will ignore the stacktrace - } - } - - counter.incrementAndGet(); - inner.schedule(this, 10, TimeUnit.MILLISECONDS); + if (i++ == 10) { + latch.countDown(); + try { + // wait for unsubscribe to finish so we are not racing it + unsubscribeLatch.await(); + } catch (InterruptedException e) { + // we expect the countDown if unsubscribe is not working + // or to be interrupted if unsubscribe is successful since + // unsubscribe will interrupt it as it is calling Future.cancel(true) + // so we will ignore the stacktrace } - }, 10, TimeUnit.MILLISECONDS); + } + + counter.incrementAndGet(); + inner.schedule(this, 10, TimeUnit.MILLISECONDS); } - }); + }, 10, TimeUnit.MILLISECONDS)); latch.await(); inner.dispose(); @@ -225,7 +205,7 @@ public void recursionFromOuterActionAndUnsubscribeInside() throws InterruptedExc final CountDownLatch latch = new CountDownLatch(1); final Worker inner = getScheduler().createWorker(); try { - inner.schedule(new Runnable() { + inner.schedule(new Runnable() /* NFI */ { int i; @@ -254,7 +234,7 @@ public void recursion() throws InterruptedException { final CountDownLatch latch = new CountDownLatch(1); final Worker inner = getScheduler().createWorker(); try { - inner.schedule(new Runnable() { + inner.schedule(new Runnable() /* NFI */ { private long i; @@ -285,10 +265,10 @@ public void recursionAndOuterUnsubscribe() throws InterruptedException { final CountDownLatch completionLatch = new CountDownLatch(1); final Worker inner = getScheduler().createWorker(); try { - Flowable obs = Flowable.unsafeCreate(new Publisher() { + Flowable obs = Flowable.unsafeCreate(new Publisher() /* NFI */ { @Override public void subscribe(final Subscriber subscriber) { - inner.schedule(new Runnable() { + inner.schedule(new Runnable() /* NFI */ { @Override public void run() { subscriber.onNext(42); @@ -299,7 +279,7 @@ public void run() { } }); - subscriber.onSubscribe(new Subscription() { + subscriber.onSubscribe(new Subscription() /* NFI */ { @Override public void cancel() { @@ -319,7 +299,7 @@ public void request(long n) { final AtomicInteger count = new AtomicInteger(); final AtomicBoolean completed = new AtomicBoolean(false); - ResourceSubscriber s = new ResourceSubscriber() { + ResourceSubscriber s = new ResourceSubscriber() /* NFI */ { @Override public void onComplete() { System.out.println("Completed"); diff --git a/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerTests.java b/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerTests.java index e4574be0e9..57b97f6b49 100644 --- a/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerTests.java +++ b/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerTests.java @@ -224,7 +224,7 @@ public final void recursiveExecution() throws InterruptedException { final AtomicInteger i = new AtomicInteger(); final CountDownLatch latch = new CountDownLatch(1); - inner.schedule(new Runnable() { + inner.schedule(new Runnable() /* NFI */ { @Override public void run() { @@ -252,7 +252,7 @@ public final void recursiveExecutionWithDelayTime() throws InterruptedException final AtomicInteger i = new AtomicInteger(); final CountDownLatch latch = new CountDownLatch(1); - inner.schedule(new Runnable() { + inner.schedule(new Runnable() /* NFI */ { int state; @@ -277,35 +277,32 @@ public void run() { @Test public final void recursiveSchedulerInObservable() { - Flowable obs = Flowable.unsafeCreate(new Publisher() { - @Override - public void subscribe(final Subscriber subscriber) { - final Scheduler.Worker inner = getScheduler().createWorker(); + Flowable obs = Flowable.unsafeCreate(subscriber -> { + final Scheduler.Worker inner = getScheduler().createWorker(); - AsyncSubscription as = new AsyncSubscription(); - subscriber.onSubscribe(as); - as.setResource(inner); + AsyncSubscription as = new AsyncSubscription(); + subscriber.onSubscribe(as); + as.setResource(inner); - inner.schedule(new Runnable() { - int i; + inner.schedule(new Runnable() /* NFI */ { + int i; - @Override - public void run() { - if (i > 42) { - try { - subscriber.onComplete(); - } finally { - inner.dispose(); - } - return; + @Override + public void run() { + if (i > 42) { + try { + subscriber.onComplete(); + } finally { + inner.dispose(); } + return; + } - subscriber.onNext(i++); + subscriber.onNext(i++); - inner.schedule(this); - } - }); - } + inner.schedule(this); + } + }); }); final AtomicInteger lastValue = new AtomicInteger(); @@ -491,7 +488,7 @@ public void schedulePeriodicallyDirectZeroPeriod() throws Exception { final SequentialDisposable sd = new SequentialDisposable(); try { - sd.replace(s.schedulePeriodicallyDirect(new Runnable() { + sd.replace(s.schedulePeriodicallyDirect(new Runnable() /* NFI */ { int count; @Override @@ -527,7 +524,7 @@ public void schedulePeriodicallyZeroPeriod() throws Exception { Scheduler.Worker w = s.createWorker(); try { - sd.replace(w.schedulePeriodically(new Runnable() { + sd.replace(w.schedulePeriodically(new Runnable() /* NFI */ { int count; @Override diff --git a/src/test/java/io/reactivex/rxjava4/schedulers/ComputationSchedulerTests.java b/src/test/java/io/reactivex/rxjava4/schedulers/ComputationSchedulerTests.java index b343ffdec9..3c1df3b5aa 100644 --- a/src/test/java/io/reactivex/rxjava4/schedulers/ComputationSchedulerTests.java +++ b/src/test/java/io/reactivex/rxjava4/schedulers/ComputationSchedulerTests.java @@ -46,7 +46,7 @@ public void threadSafetyWhenSchedulerIsHoppingBetweenThreads() { final Scheduler.Worker inner = Schedulers.computation().createWorker(); try { - inner.schedule(new Runnable() { + inner.schedule(new Runnable() /* NFI */ { private HashMap statefulMap = map; int nonThreadSafeCounter; diff --git a/src/test/java/io/reactivex/rxjava4/schedulers/SchedulerTest.java b/src/test/java/io/reactivex/rxjava4/schedulers/SchedulerTest.java index a6676dbeae..7bc4a0d4c1 100644 --- a/src/test/java/io/reactivex/rxjava4/schedulers/SchedulerTest.java +++ b/src/test/java/io/reactivex/rxjava4/schedulers/SchedulerTest.java @@ -223,11 +223,11 @@ public void schedulersUtility() { @Test public void defaultSchedulePeriodicallyDirectRejects() { - Scheduler s = new Scheduler() { + Scheduler s = new Scheduler() /* NFI */ { @NonNull @Override public Worker createWorker() { - return new Worker() { + return new Worker() /* NFI */ { @NonNull @Override public Disposable schedule(@NonNull Runnable run, long delay, @NonNull TimeUnit unit) { @@ -309,10 +309,10 @@ public void unwrapWorkerPeriodicTask() { final Runnable runnable = () -> { }; - Scheduler scheduler = new Scheduler() { + Scheduler scheduler = new Scheduler() /* NFI */ { @Override public Worker createWorker() { - return new Worker() { + return new Worker() /* NFI */ { @Override public Disposable schedule(Runnable run, long delay, TimeUnit unit) { SchedulerRunnableIntrospection outerWrapper = (SchedulerRunnableIntrospection) run; diff --git a/src/test/java/io/reactivex/rxjava4/schedulers/SchedulerWorkerTest.java b/src/test/java/io/reactivex/rxjava4/schedulers/SchedulerWorkerTest.java index 0472b4f9ef..f002de55cc 100644 --- a/src/test/java/io/reactivex/rxjava4/schedulers/SchedulerWorkerTest.java +++ b/src/test/java/io/reactivex/rxjava4/schedulers/SchedulerWorkerTest.java @@ -32,7 +32,7 @@ static final class CustomDriftScheduler extends Scheduler { @Override public Worker createWorker() { final Worker w = Schedulers.computation().createWorker(); - return new Worker() { + return new Worker() /* NFI */ { @Override public void dispose() { diff --git a/src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java b/src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java index 460286c735..18430707bd 100644 --- a/src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java +++ b/src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java @@ -136,7 +136,7 @@ public final void immediateUnsubscribes() { final AtomicInteger counter = new AtomicInteger(0); try { - inner.schedule(new Runnable() { + inner.schedule(new Runnable() /* NFI */ { @Override public void run() { @@ -160,7 +160,7 @@ public final void immediateUnsubscribes2() { try { final AtomicInteger counter = new AtomicInteger(0); - final Disposable subscription = inner.schedule(new Runnable() { + final Disposable subscription = inner.schedule(new Runnable() /* NFI */ { @Override public void run() { @@ -186,21 +186,18 @@ public final void nestedSchedule() { final Runnable calledOp = mock(Runnable.class); Flowable poller; - poller = Flowable.unsafeCreate(new Publisher() { - @Override - public void subscribe(final Subscriber aSubscriber) { - final BooleanSubscription bs = new BooleanSubscription(); - aSubscriber.onSubscribe(bs); - inner.schedule(new Runnable() { - @Override - public void run() { - if (!bs.isCancelled()) { - calledOp.run(); - inner.schedule(this, 5, TimeUnit.SECONDS); - } + poller = Flowable.unsafeCreate(aSubscriber -> { + final BooleanSubscription bs = new BooleanSubscription(); + aSubscriber.onSubscribe(bs); + inner.schedule(new Runnable() /* NFI */ { + @Override + public void run() { + if (!bs.isCancelled()) { + calledOp.run(); + inner.schedule(this, 5, TimeUnit.SECONDS); } - }); - } + } + }); }); InOrder inOrder = Mockito.inOrder(calledOp); @@ -225,7 +222,7 @@ public void run() { @Test public void timedRunnableToString() { - TimedRunnable r = new TimedRunnable((TestWorker) new TestScheduler().createWorker(), 5, new Runnable() { + TimedRunnable r = new TimedRunnable((TestWorker) new TestScheduler().createWorker(), 5, new Runnable() /* NFI */ { @Override public void run() { // deliberately no-op diff --git a/src/test/java/io/reactivex/rxjava4/single/SingleCacheTest.java b/src/test/java/io/reactivex/rxjava4/single/SingleCacheMainTest.java similarity index 93% rename from src/test/java/io/reactivex/rxjava4/single/SingleCacheTest.java rename to src/test/java/io/reactivex/rxjava4/single/SingleCacheMainTest.java index 6c241b465f..8919bad24c 100644 --- a/src/test/java/io/reactivex/rxjava4/single/SingleCacheTest.java +++ b/src/test/java/io/reactivex/rxjava4/single/SingleCacheMainTest.java @@ -21,7 +21,7 @@ import io.reactivex.rxjava4.subjects.PublishSubject; import io.reactivex.rxjava4.subscribers.TestSubscriber; -public class SingleCacheTest extends RxJavaTest { +public class SingleCacheMainTest extends RxJavaTest { @Test public void normal() { @@ -91,7 +91,7 @@ public void crossCancel() { final TestSubscriber ts1 = new TestSubscriber<>(); - TestSubscriber ts2 = new TestSubscriber() { + var ts2 = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -114,9 +114,9 @@ public void crossCancelOnError() { PublishSubject ps = PublishSubject.create(); Single cache = ps.single(-99).cache(); - final TestSubscriber ts1 = new TestSubscriber<>(); + final var ts1 = new TestSubscriber<>(); - TestSubscriber ts2 = new TestSubscriber() { + var ts2 = new TestSubscriber() /* NFI */ { @Override public void onError(Throwable t) { super.onError(t); diff --git a/src/test/java/io/reactivex/rxjava4/single/SingleSubscribeTest.java b/src/test/java/io/reactivex/rxjava4/single/SingleSubscribeTest.java index bcc0969b9d..f1edba73b6 100644 --- a/src/test/java/io/reactivex/rxjava4/single/SingleSubscribeTest.java +++ b/src/test/java/io/reactivex/rxjava4/single/SingleSubscribeTest.java @@ -71,7 +71,7 @@ public void biconsumerError() { @Test public void subscribeThrows() { try { - new Single() { + new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { throw new IllegalArgumentException(); diff --git a/src/test/java/io/reactivex/rxjava4/single/SingleTest.java b/src/test/java/io/reactivex/rxjava4/single/SingleTest.java index 9c70432638..ea5e3b5317 100644 --- a/src/test/java/io/reactivex/rxjava4/single/SingleTest.java +++ b/src/test/java/io/reactivex/rxjava4/single/SingleTest.java @@ -43,7 +43,8 @@ public void helloWorld() { @Test public void helloWorld2() { final AtomicReference v = new AtomicReference<>(); - Single.just("Hello World!").subscribe(new SingleObserver() { + Single.just("Hello World!") + .subscribe(new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -254,7 +255,7 @@ public void unsubscribe() throws InterruptedException { public void unsubscribe2() throws InterruptedException { @SuppressWarnings("resource") final SerialDisposable sd = new SerialDisposable(); - SingleObserver ts = new SingleObserver() { + var ts = new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -494,7 +495,7 @@ public void fromObservableError() { @Test(expected = NullPointerException.class) public void implementationThrows() { - new Single() { + new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { throw new NullPointerException(); diff --git a/src/test/java/io/reactivex/rxjava4/subjects/AsyncSubjectTest.java b/src/test/java/io/reactivex/rxjava4/subjects/AsyncSubjectTest.java index efb8786d2f..3c2ff78778 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/AsyncSubjectTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/AsyncSubjectTest.java @@ -428,7 +428,7 @@ public void onNextCrossCancel() { AsyncSubject p = AsyncSubject.create(); final TestObserver to2 = new TestObserver<>(); - TestObserver to1 = new TestObserver() { + TestObserver to1 = new TestObserver() /* NFI */ { @Override public void onNext(Object t) { to2.dispose(); @@ -452,7 +452,7 @@ public void onErrorCrossCancel() { AsyncSubject p = AsyncSubject.create(); final TestObserver to2 = new TestObserver<>(); - TestObserver to1 = new TestObserver() { + TestObserver to1 = new TestObserver() /* NFI */ { @Override public void onError(Throwable t) { to2.dispose(); @@ -474,7 +474,7 @@ public void onCompleteCrossCancel() { AsyncSubject p = AsyncSubject.create(); final TestObserver to2 = new TestObserver<>(); - TestObserver to1 = new TestObserver() { + TestObserver to1 = new TestObserver() /* NFI */ { @Override public void onComplete() { to2.dispose(); diff --git a/src/test/java/io/reactivex/rxjava4/subjects/BehaviorSubjectTest.java b/src/test/java/io/reactivex/rxjava4/subjects/BehaviorSubjectTest.java index 4ab06b8f9d..8d270b4ea1 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/BehaviorSubjectTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/BehaviorSubjectTest.java @@ -256,7 +256,7 @@ public void unsubscriptionCase() { src.firstElement() .toObservable() .flatMap((Function>) t1 -> Observable.just(t1 + ", " + t1)) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onNext(String t) { o.onNext(t); @@ -383,7 +383,7 @@ public void emissionSubscriptionRace() throws Exception { final AtomicReference o = new AtomicReference<>(); rs.subscribeOn(s).observeOn(Schedulers.cached()) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -613,7 +613,7 @@ public void subscribeOnNextRace() { @Test public void innerDisposed() { BehaviorSubject.create() - .subscribe(new Observer() { + .subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { assertFalse(d.isDisposed()); diff --git a/src/test/java/io/reactivex/rxjava4/subjects/CompletableSubjectTest.java b/src/test/java/io/reactivex/rxjava4/subjects/CompletableSubjectTest.java index 5db5a1d075..e05ad2168e 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/CompletableSubjectTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/CompletableSubjectTest.java @@ -162,7 +162,7 @@ public void dispose() { @Test public void disposeTwice() { CompletableSubject.create() - .subscribe(new CompletableObserver() { + .subscribe(new CompletableObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { assertFalse(d.isDisposed()); diff --git a/src/test/java/io/reactivex/rxjava4/subjects/MaybeSubjectTest.java b/src/test/java/io/reactivex/rxjava4/subjects/MaybeSubjectTest.java index dde2636f09..2197e95c1b 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/MaybeSubjectTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/MaybeSubjectTest.java @@ -202,7 +202,7 @@ public void dispose() { @Test public void disposeTwice() { MaybeSubject.create() - .subscribe(new MaybeObserver() { + .subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { assertFalse(d.isDisposed()); diff --git a/src/test/java/io/reactivex/rxjava4/subjects/PublishSubjectTest.java b/src/test/java/io/reactivex/rxjava4/subjects/PublishSubjectTest.java index 3bd4ef40ac..db063ff29f 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/PublishSubjectTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/PublishSubjectTest.java @@ -296,7 +296,7 @@ public void unsubscriptionCase() { src.firstElement() .toObservable() .flatMap((Function>) t1 -> Observable.just(t1 + ", " + t1)) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onNext(String t) { o.onNext(t); @@ -374,7 +374,7 @@ public void currentStateMethodsError() { @Test public void crossCancel() { final TestObserver to1 = new TestObserver<>(); - TestObserver to2 = new TestObserver() { + var to2 = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); @@ -398,7 +398,7 @@ public void onNext(Integer t) { @SuppressUndeliverable public void crossCancelOnError() { final TestObserver to1 = new TestObserver<>(); - TestObserver to2 = new TestObserver() { + TestObserver to2 = new TestObserver() /* NFI */ { @Override public void onError(Throwable t) { super.onError(t); @@ -421,7 +421,7 @@ public void onError(Throwable t) { @Test public void crossCancelOnComplete() { final TestObserver to1 = new TestObserver<>(); - TestObserver to2 = new TestObserver() { + TestObserver to2 = new TestObserver() /* NFI */ { @Override public void onComplete() { super.onComplete(); @@ -447,7 +447,7 @@ public void onSubscribeCancelsImmediately() { TestObserver to = ps.test(); - ps.subscribe(new Observer() { + ps.subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectBoundedConcurrencyTest.java b/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectBoundedConcurrencyTest.java index 54f0c0131b..4f7a391e55 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectBoundedConcurrencyTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectBoundedConcurrencyTest.java @@ -51,7 +51,7 @@ public void replaySubjectConcurrentSubscribersDoingReplayDontBlockEachOther() th // it's been played through once so now it will all be replays final CountDownLatch slowLatch = new CountDownLatch(1); Thread slowThread = new Thread(() -> { - Observer slow = new DefaultObserver() { + Observer slow = new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -88,7 +88,7 @@ public void onNext(Long args) { Thread fastThread = new Thread(() -> { final CountDownLatch fastLatch = new CountDownLatch(1); - Observer fast = new DefaultObserver() { + Observer fast = new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -317,7 +317,7 @@ public void replaySubjectEmissionSubscriptionRace() throws Exception { .subscribeOn(s) .observeOn(Schedulers.cached()) // .doOnNext(e -> System.out.println(">>> " + j)) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override protected void onStart() { diff --git a/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectConcurrencyTest.java b/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectConcurrencyTest.java index bc48f3f193..8836a15fcd 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectConcurrencyTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectConcurrencyTest.java @@ -51,7 +51,7 @@ public void replaySubjectConcurrentSubscribersDoingReplayDontBlockEachOther() th // it's been played through once so now it will all be replays final CountDownLatch slowLatch = new CountDownLatch(1); Thread slowThread = new Thread(() -> { - Observer slow = new DefaultObserver() { + Observer slow = new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -88,7 +88,7 @@ public void onNext(Long args) { Thread fastThread = new Thread(() -> { final CountDownLatch fastLatch = new CountDownLatch(1); - Observer fast = new DefaultObserver() { + Observer fast = new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -309,7 +309,7 @@ public void replaySubjectEmissionSubscriptionRace() throws Exception { final AtomicReference o = new AtomicReference<>(); rs.subscribeOn(s).observeOn(Schedulers.cached()) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onComplete() { diff --git a/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectTest.java b/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectTest.java index b1ee8708fd..201eb0f650 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/ReplaySubjectTest.java @@ -261,7 +261,7 @@ private void assertObservedUntilTwo(Observer observer) { public void newSubscriberDoesntBlockExisting() throws InterruptedException { final AtomicReference lastValueForSubscriber1 = new AtomicReference<>(); - Observer observer1 = new DefaultObserver() { + Observer observer1 = new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -285,7 +285,7 @@ public void onNext(String v) { final CountDownLatch oneReceived = new CountDownLatch(1); final CountDownLatch makeSlow = new CountDownLatch(1); final CountDownLatch completed = new CountDownLatch(1); - Observer observer2 = new DefaultObserver() { + Observer observer2 = new DefaultObserver() /* NFI */ { @Override public void onComplete() { @@ -381,7 +381,7 @@ public void unsubscriptionCase() { src.firstElement() .toObservable() .flatMap((Function>) t1 -> Observable.just(t1 + ", " + t1)) - .subscribe(new DefaultObserver() { + .subscribe(new DefaultObserver() /* NFI */ { @Override public void onNext(String t) { System.out.println(t); @@ -413,7 +413,7 @@ public void terminateOnce() { final Observer o = TestHelper.mockObserver(); - source.subscribe(new DefaultObserver() { + source.subscribe(new DefaultObserver() /* NFI */ { @Override public void onNext(Integer t) { @@ -1082,7 +1082,7 @@ public void reentrantDrain() { final ReplaySubject rp = ReplaySubject.createWithTimeAndSize(1, TimeUnit.SECONDS, scheduler, 2); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(Integer t) { if (t == 1) { diff --git a/src/test/java/io/reactivex/rxjava4/subjects/SerializedSubjectTest.java b/src/test/java/io/reactivex/rxjava4/subjects/SerializedSubjectTest.java index 5dc3663392..d799d4f054 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/SerializedSubjectTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/SerializedSubjectTest.java @@ -591,7 +591,7 @@ public void onSubscribeOnSubscribeRace() { public void onErrorQueued() { Subject sp = PublishSubject.create().toSerialized(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(@NonNull Integer t) { super.onNext(t); @@ -615,7 +615,7 @@ public void onNext(@NonNull Integer t) { public void onCompleteQueued() { Subject sp = PublishSubject.create().toSerialized(); - TestObserver to = new TestObserver() { + TestObserver to = new TestObserver() /* NFI */ { @Override public void onNext(@NonNull Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/subjects/SingleSubjectTest.java b/src/test/java/io/reactivex/rxjava4/subjects/SingleSubjectTest.java index 13c5f0a2fa..85c7003fad 100644 --- a/src/test/java/io/reactivex/rxjava4/subjects/SingleSubjectTest.java +++ b/src/test/java/io/reactivex/rxjava4/subjects/SingleSubjectTest.java @@ -182,7 +182,7 @@ public void dispose() { @Test public void disposeTwice() { SingleSubject.create() - .subscribe(new SingleObserver() { + .subscribe(new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { assertFalse(d.isDisposed()); diff --git a/src/test/java/io/reactivex/rxjava4/subscribers/ResourceSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/subscribers/ResourceSubscriberTest.java index b2a0f319ab..3d567e0a09 100644 --- a/src/test/java/io/reactivex/rxjava4/subscribers/ResourceSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/subscribers/ResourceSubscriberTest.java @@ -201,7 +201,7 @@ public void dispose() { @Test public void request() { - TestResourceSubscriber tc = new TestResourceSubscriber() { + var tc = new TestResourceSubscriber() /* NFI */ { @Override protected void onStart() { start++; diff --git a/src/test/java/io/reactivex/rxjava4/subscribers/SafeSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/subscribers/SafeSubscriberTest.java index a12ce1700b..6e6fe286a8 100644 --- a/src/test/java/io/reactivex/rxjava4/subscribers/SafeSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/subscribers/SafeSubscriberTest.java @@ -140,7 +140,7 @@ public void sendOnError(Throwable e) { @Override public void subscribe(Subscriber subscriber) { this.subscriber = subscriber; - subscriber.onSubscribe(new Subscription() { + subscriber.onSubscribe(new Subscription() /* NFI */ { @Override public void cancel() { @@ -222,7 +222,7 @@ public void onNextOnErrorFailure() { } } - static final Subscription THROWING_DISPOSABLE = new Subscription() { + static final Subscription THROWING_DISPOSABLE = new Subscription() /* NFI */ { @Override public void cancel() { @@ -237,7 +237,7 @@ public void request(long n) { }; private static Subscriber OBSERVER_ONNEXT_FAIL(final AtomicReference onError) { - return new DefaultSubscriber() { + return new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -258,7 +258,7 @@ public void onNext(String args) { } private static Subscriber OBSERVER_ONNEXT_ONERROR_FAIL() { - return new DefaultSubscriber() { + return new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -279,7 +279,7 @@ public void onNext(String args) { } private static Subscriber subscriberOnErrorFail() { - return new DefaultSubscriber() { + return new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -300,7 +300,7 @@ public void onNext(String args) { } private static Subscriber OBSERVER_ONCOMPLETED_FAIL(final AtomicReference onError) { - return new DefaultSubscriber() { + return new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -329,7 +329,7 @@ private static class SafeSubscriberTestException extends RuntimeException { @Test public void actual() { - Subscriber actual = new DefaultSubscriber() { + Subscriber actual = new DefaultSubscriber() /* NFI */ { @Override public void onNext(Integer t) { } diff --git a/src/test/java/io/reactivex/rxjava4/subscribers/SerializedSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/subscribers/SerializedSubscriberTest.java index f7db0aa5d1..d8ebb4c716 100644 --- a/src/test/java/io/reactivex/rxjava4/subscribers/SerializedSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/subscribers/SerializedSubscriberTest.java @@ -278,7 +278,7 @@ public void notificationDelay() throws InterruptedException { final CountDownLatch latch = new CountDownLatch(1); final CountDownLatch running = new CountDownLatch(2); - TestSubscriberEx ts = new TestSubscriberEx<>(new DefaultSubscriber() { + var ts = new TestSubscriberEx<>(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -359,7 +359,7 @@ public void onNext(String t) { @Test public void threadStarvation() throws InterruptedException { - TestSubscriber ts = new TestSubscriber<>(new DefaultSubscriber() { + TestSubscriber ts = new TestSubscriber<>(new DefaultSubscriber() /* NFI */ { @Override public void onComplete() { @@ -387,7 +387,7 @@ public void onNext(String t) { AtomicInteger p2 = new AtomicInteger(); subscriber.onSubscribe(new BooleanSubscription()); - ResourceSubscriber as1 = new ResourceSubscriber() { + ResourceSubscriber as1 = new ResourceSubscriber() /* NFI */ { @Override public void onNext(String t) { subscriber.onNext(t); @@ -404,7 +404,7 @@ public void onComplete() { } }; - ResourceSubscriber as2 = new ResourceSubscriber() { + ResourceSubscriber as2 = new ResourceSubscriber() /* NFI */ { @Override public void onNext(String t) { subscriber.onNext(t); @@ -835,7 +835,7 @@ public void errorReentry() { try { final AtomicReference> serial = new AtomicReference<>(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer v) { serial.get().onError(new TestException()); @@ -862,7 +862,7 @@ public void onNext(Integer v) { public void completeReentry() { final AtomicReference> serial = new AtomicReference<>(); - TestSubscriber ts = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() /* NFI */ { @Override public void onNext(Integer v) { serial.get().onComplete(); @@ -1078,7 +1078,7 @@ public void nullOnNext() { @SuppressUndeliverable public void onErrorQueuedUp() { AtomicReference> ssRef = new AtomicReference<>(); - TestSubscriberEx ts = new TestSubscriberEx() { + TestSubscriberEx ts = new TestSubscriberEx() /* NFI */ { @Override public void onNext(Integer t) { super.onNext(t); diff --git a/src/test/java/io/reactivex/rxjava4/subscribers/TestSubscriberTest.java b/src/test/java/io/reactivex/rxjava4/subscribers/TestSubscriberTest.java index e35a436a50..fde2ae186b 100644 --- a/src/test/java/io/reactivex/rxjava4/subscribers/TestSubscriberTest.java +++ b/src/test/java/io/reactivex/rxjava4/subscribers/TestSubscriberTest.java @@ -629,13 +629,13 @@ public void valueCount() { @Test public void onCompletedCrashCountsDownLatch() { - TestSubscriber ts0 = new TestSubscriber() { + var ts0 = new TestSubscriber() /* NFI */ { @Override public void onComplete() { throw new TestException(); } }; - TestSubscriber ts = new TestSubscriber<>(ts0); + var ts = new TestSubscriber<>(ts0); try { ts.onComplete(); @@ -648,7 +648,7 @@ public void onComplete() { @Test public void onErrorCrashCountsDownLatch() { - TestSubscriber ts0 = new TestSubscriber() { + TestSubscriber ts0 = new TestSubscriber() /* NFI */ { @Override public void onError(Throwable e) { throw new TestException(); @@ -1260,7 +1260,7 @@ public void completeWithoutOnSubscribe() { @Test public void completeDelegateThrows() throws Exception { - TestSubscriber ts = new TestSubscriber<>(new FlowableSubscriber() { + TestSubscriber ts = new TestSubscriber<>(new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -1296,7 +1296,7 @@ public void onComplete() { @Test public void errorDelegateThrows() throws Exception { - TestSubscriber ts = new TestSubscriber<>(new FlowableSubscriber() { + TestSubscriber ts = new TestSubscriber<>(new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { diff --git a/src/test/java/io/reactivex/rxjava4/testsupport/TestHelper.java b/src/test/java/io/reactivex/rxjava4/testsupport/TestHelper.java index 6eff23dc36..8e7d151579 100644 --- a/src/test/java/io/reactivex/rxjava4/testsupport/TestHelper.java +++ b/src/test/java/io/reactivex/rxjava4/testsupport/TestHelper.java @@ -310,7 +310,7 @@ public static void assertBadRequestReported(Publisher source) { try { final CountDownLatch cdl = new CountDownLatch(1); - source.subscribe(new FlowableSubscriber() { + source.subscribe(new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -363,7 +363,7 @@ public static void assertBadRequestReported(ParallelFlowable source) { try { final CountDownLatch cdl = new CountDownLatch(1); - FlowableSubscriber bad = new FlowableSubscriber() { + var bad = new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -691,7 +691,7 @@ public static void checkDisposed(Disposable d) { */ public static void checkDisposed(Flowable source) { final TestSubscriber ts = new TestSubscriber<>(0L); - source.subscribe(new FlowableSubscriber() { + source.subscribe(new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { ts.onSubscribe(new BooleanSubscription()); @@ -726,7 +726,7 @@ public void onComplete() { public static void checkDisposed(Maybe source) { final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - source.subscribe(new MaybeObserver() { + source.subscribe(new MaybeObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -777,7 +777,7 @@ public void onComplete() { public static void checkDisposed(Observable source) { final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - source.subscribe(new Observer() { + source.subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -828,7 +828,7 @@ public void onComplete() { public static void checkDisposed(Single source) { final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - source.subscribe(new SingleObserver() { + source.subscribe(new SingleObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -874,7 +874,7 @@ public void onError(Throwable e) { public static void checkDisposed(Completable source) { final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - source.subscribe(new CompletableObserver() { + source.subscribe(new CompletableObserver() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -962,7 +962,7 @@ public static void checkDoubleOnSubscribeMaybe(Function, ? exten final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - Maybe source = new Maybe() { + Maybe source = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { try { @@ -1016,7 +1016,7 @@ public static void checkDoubleOnSubscribeMaybeToSingle(Function, final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - Maybe source = new Maybe() { + Maybe source = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { try { @@ -1070,7 +1070,7 @@ public static void checkDoubleOnSubscribeMaybeToObservable(Function source = new Maybe() { + Maybe source = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { try { @@ -1124,7 +1124,7 @@ public static void checkDoubleOnSubscribeMaybeToFlowable(Function source = new Maybe() { + Maybe source = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { try { @@ -1178,7 +1178,7 @@ public static void checkDoubleOnSubscribeSingleToMaybe(Function final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - Single source = new Single() { + Single source = new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { try { @@ -1232,7 +1232,7 @@ public static void checkDoubleOnSubscribeSingleToObservable(Function source = new Single() { + Single source = new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { try { @@ -1286,7 +1286,7 @@ public static void checkDoubleOnSubscribeSingleToFlowable(Function source = new Single() { + Single source = new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { try { @@ -1339,7 +1339,7 @@ public static void checkDoubleOnSubscribeMaybeToCompletable(Function source = new Maybe() { + Maybe source = new Maybe() /* NFI */ { @Override protected void subscribeActual(MaybeObserver observer) { try { @@ -1393,7 +1393,7 @@ public static void checkDoubleOnSubscribeSingle(Function, ? ext final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - Single source = new Single() { + Single source = new Single() /* NFI */ { @Override protected void subscribeActual(SingleObserver observer) { try { @@ -1447,7 +1447,7 @@ public static void checkDoubleOnSubscribeFlowable(Function, ? final Boolean[] b = { null, null }; final CountDownLatch cdl = new CountDownLatch(1); - Flowable source = new Flowable() { + Flowable source = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { try { @@ -1501,7 +1501,7 @@ public static void checkDoubleOnSubscribeParallel(Function source = new ParallelFlowable() { + ParallelFlowable source = new ParallelFlowable() /* NFI */ { @Override public void subscribe(Subscriber[] subscribers) { for (int i = 0; i < subscribers.length; i++) { @@ -1564,7 +1564,7 @@ public static void checkDoubleOnSubscribeParallelToFlowable(Function source = new ParallelFlowable() { + ParallelFlowable source = new ParallelFlowable() /* NFI */ { @Override public void subscribe(Subscriber[] subscribers) { for (int i = 0; i < subscribers.length; i++) { @@ -1629,7 +1629,7 @@ public static void checkDoubleOnSubscribeObservable(Function source = new Observable() { + Observable source = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { try { @@ -1683,7 +1683,7 @@ public static void checkDoubleOnSubscribeObservableToSingle(Function source = new Observable() { + Observable source = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { try { @@ -1737,7 +1737,7 @@ public static void checkDoubleOnSubscribeObservableToMaybe(Function source = new Observable() { + Observable source = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { try { @@ -1790,7 +1790,7 @@ public static void checkDoubleOnSubscribeObservableToCompletable(Function source = new Observable() { + Observable source = new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { try { @@ -1844,7 +1844,7 @@ public static void checkDoubleOnSubscribeFlowableToObservable(Function source = new Flowable() { + Flowable source = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { try { @@ -1898,7 +1898,7 @@ public static void checkDoubleOnSubscribeFlowableToSingle(Function source = new Flowable() { + Flowable source = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { try { @@ -1952,7 +1952,7 @@ public static void checkDoubleOnSubscribeFlowableToMaybe(Function source = new Flowable() { + Flowable source = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { try { @@ -2005,7 +2005,7 @@ public static void checkDoubleOnSubscribeFlowableToCompletable(Function source = new Flowable() { + Flowable source = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { try { @@ -2057,7 +2057,7 @@ public static void checkDoubleOnSubscribeCompletable(Function void checkDoubleOnSubscribeCompletableToMaybe(Function void checkDoubleOnSubscribeCompletableToSingle(Function void checkFusedIsEmptyClear(Observable source) { final Boolean[] state = { null, null, null, null }; - source.subscribe(new Observer() { + source.subscribe(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { try { @@ -2593,7 +2593,7 @@ public static void checkFusedIsEmptyClear(Flowable source) { final Boolean[] state = { null, null, null, null }; - source.subscribe(new FlowableSubscriber() { + source.subscribe(new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { try { @@ -2681,7 +2681,7 @@ public static void checkBadSourceObservable(Function, Object> final boolean error, final T goodValue, final T badValue, final Object... expected) { List errors = trackPluginErrors(); try { - Observable bad = new Observable() { + Observable bad = new Observable() /* NFI */ { boolean once; @Override protected void subscribeActual(Observer observer) { @@ -2846,7 +2846,7 @@ public static void checkBadSourceFlowable(Function, Object> mapp final boolean error, final T goodValue, final T badValue, final Object... expected) { List errors = trackPluginErrors(); try { - Flowable bad = new Flowable() { + Flowable bad = new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); @@ -3014,10 +3014,10 @@ public static void checkInvalidParallelSubscribers(ParallelFlowable sourc * @return the new Observable */ public static Observable rejectObservableFusion() { - return new Observable() { + return new Observable() /* NFI */ { @Override protected void subscribeActual(Observer observer) { - observer.onSubscribe(new QueueDisposable() { + observer.onSubscribe(new QueueDisposable() /* NFI */ { @Override public int requestFusion(int mode) { @@ -3068,10 +3068,10 @@ public boolean isDisposed() { * @return the new Observable */ public static Flowable rejectFlowableFusion() { - return new Flowable() { + return new Flowable() /* NFI */ { @Override protected void subscribeActual(Subscriber subscriber) { - subscriber.onSubscribe(new QueueSubscription() { + subscriber.onSubscribe(new QueueSubscription() /* NFI */ { @Override public int requestFusion(int mode) { @@ -3753,7 +3753,7 @@ public static void raceOther(Runnable run, CountDownLatch resume) { * @return the new FlowableTransformer instance */ public static FlowableTransformer conditional() { - return f -> new Flowable() { + return f -> new Flowable() /* NFI */ { @Override protected void subscribeActual(@NonNull Subscriber<@NonNull ? super T> subscriber) { f.subscribe(new ForwardingConditionalSubscriber<>(subscriber)); diff --git a/src/test/java/io/reactivex/rxjava4/testsupport/TestObserverExTest.java b/src/test/java/io/reactivex/rxjava4/testsupport/TestObserverExTest.java index 32eeb34870..e43a554b6f 100644 --- a/src/test/java/io/reactivex/rxjava4/testsupport/TestObserverExTest.java +++ b/src/test/java/io/reactivex/rxjava4/testsupport/TestObserverExTest.java @@ -967,7 +967,7 @@ public void completeWithoutOnSubscribe() { @Test public void completeDelegateThrows() { - TestObserverEx to = new TestObserverEx<>(new Observer() { + var to = new TestObserverEx<>(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { @@ -1003,7 +1003,7 @@ public void onComplete() { @Test public void errorDelegateThrows() { - TestObserverEx to = new TestObserverEx<>(new Observer() { + TestObserverEx to = new TestObserverEx<>(new Observer() /* NFI */ { @Override public void onSubscribe(Disposable d) { diff --git a/src/test/java/io/reactivex/rxjava4/testsupport/TestSubscriberExTest.java b/src/test/java/io/reactivex/rxjava4/testsupport/TestSubscriberExTest.java index f9d835e110..690dfd2d47 100644 --- a/src/test/java/io/reactivex/rxjava4/testsupport/TestSubscriberExTest.java +++ b/src/test/java/io/reactivex/rxjava4/testsupport/TestSubscriberExTest.java @@ -656,7 +656,7 @@ public void valueCount() { @Test public void onCompletedCrashCountsDownLatch() { - TestSubscriberEx ts0 = new TestSubscriberEx() { + TestSubscriberEx ts0 = new TestSubscriberEx() /* NFI */ { @Override public void onComplete() { throw new TestException(); @@ -675,13 +675,13 @@ public void onComplete() { @Test public void onErrorCrashCountsDownLatch() { - TestSubscriberEx ts0 = new TestSubscriberEx() { + var ts0 = new TestSubscriberEx() /* NFI */ { @Override public void onError(Throwable e) { throw new TestException(); } }; - TestSubscriberEx ts = new TestSubscriberEx<>(ts0); + var ts = new TestSubscriberEx<>(ts0); try { ts.onError(new RuntimeException()); @@ -694,7 +694,7 @@ public void onError(Throwable e) { @Test public void createDelegate() { - TestSubscriberEx ts1 = new TestSubscriberEx<>(); + var ts1 = new TestSubscriberEx<>(); TestSubscriberEx ts = new TestSubscriberEx<>(ts1); @@ -1427,7 +1427,7 @@ public void completeWithoutOnSubscribe() { @Test public void completeDelegateThrows() { - TestSubscriberEx ts = new TestSubscriberEx<>(new FlowableSubscriber() { + TestSubscriberEx ts = new TestSubscriberEx<>(new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { @@ -1463,7 +1463,7 @@ public void onComplete() { @Test public void errorDelegateThrows() { - TestSubscriberEx ts = new TestSubscriberEx<>(new FlowableSubscriber() { + TestSubscriberEx ts = new TestSubscriberEx<>(new FlowableSubscriber() /* NFI */ { @Override public void onSubscribe(Subscription s) { diff --git a/src/test/java/io/reactivex/rxjava4/validators/CheckAnonymousClassForLambda.java b/src/test/java/io/reactivex/rxjava4/validators/CheckAnonymousClassForLambda.java new file mode 100644 index 0000000000..2bfe037714 --- /dev/null +++ b/src/test/java/io/reactivex/rxjava4/validators/CheckAnonymousClassForLambda.java @@ -0,0 +1,110 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is + * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See + * the License for the specific language governing permissions and limitations under the License. + */ + +package io.reactivex.rxjava4.validators; + +import java.io.*; +import java.nio.file.Files; +import java.util.*; +import java.util.regex.Pattern; + +import org.junit.Test; + +import io.reactivex.rxjava4.testsupport.TestHelper; + +/** + * Adds license header to java files. + */ +public class CheckAnonymousClassForLambda { + + String[] header = { + "/*", + " * Copyright (c) 2016-present, RxJava Contributors.", + " *", + " * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in", + " * compliance with the License. You may obtain a copy of the License at", + " *", + " * http://www.apache.org/licenses/LICENSE-2.0", + " *", + " * Unless required by applicable law or agreed to in writing, software distributed under the License is", + " * distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See", + " * the License for the specific language governing permissions and limitations under the License.", + " */", + "" + }; + + @Test + public void checkAndUpdateLicenses() throws Exception { + if (System.getenv("CI") != null) { + // no point in changing the files in CI + return; + } + File f = TestHelper.findSource("Flowable"); + if (f == null) { + return; + } + + Queue dirs = new ArrayDeque<>(); + + File parent = f.getParentFile().getParentFile(); + dirs.offer(parent); + dirs.offer(new File(parent.getAbsolutePath().replace('\\', '/').replace("src/main/java", "src/perf/java"))); + dirs.offer(new File(parent.getAbsolutePath().replace('\\', '/').replace("src/main/java", "src/test/java"))); + + var fail = new StringBuilder(); + var regex = Pattern.compile("new\\s+\\w+(?:\\s*<(?:[\\s\\w<>(\\[\\])?,.?]|\\s*<[\\s\\w<>(\\[\\])?,.?]*>)*>)?\\s*\\([^)]*\\)\\s*\\{"); + int total = 0; + + while (!dirs.isEmpty()) { + f = dirs.poll(); + + File[] list = f.listFiles(); + if (list != null && list.length != 0) { + + for (File u : list) { + if (u.isDirectory()) { + dirs.offer(u); + } else { + if (u.getName().endsWith(".java")) { + + List lines = Files.readAllLines(u.toPath()); + + for (int i = 0; i < lines.size(); i++) { + + String input = lines.get(i); + if (input.trim().startsWith("*")) { + continue; + } + if (regex.matcher(input).find()) { + if (fail.isEmpty()) { + fail.append("java.lang.RuntimeException lambda possibility\r\n"); + } + fail.append(" at ").append(u.getName()) + .append("(").append(u.getName()).append(":").append(i + 1) + .append(")\r\n"); + total++; + } + } + } + } + } + } + } + + if (fail.length() != 0) { + System.out.println(fail); + System.out.println(total); + throw new AssertionError(fail.toString()); + } + } +} From d58230c28d22c79c6af3debfb40cdaa222ec0333 Mon Sep 17 00:00:00 2001 From: akarnokd Date: Thu, 25 Jun 2026 21:24:34 +0200 Subject: [PATCH 2/2] Fix merge main error --- .../AbstractSchedulerConcurrencyTests.java | 31 ++++++++++--------- .../rxjava4/schedulers/TestSchedulerTest.java | 1 - 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java b/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java index 2786643904..d2c99bf76d 100644 --- a/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java +++ b/src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java @@ -274,26 +274,27 @@ public void run() { subscriber.onNext(42); latch.countDown(); - // this will recursively schedule this task for execution again - inner.schedule(this); - } - }); + // this will recursively schedule this task for execution again + inner.schedule(this); + } + }); - subscriber.onSubscribe(new Subscription() /* NFI */ { + subscriber.onSubscribe(new Subscription() /* NFI */ { - @Override - public void cancel() { - inner.dispose(); - subscriber.onComplete(); - completionLatch.countDown(); - } + @Override + public void cancel() { + inner.dispose(); + subscriber.onComplete(); + completionLatch.countDown(); + } - @Override - public void request(long n) { + @Override + public void request(long n) { - } - }); + } + }); + } }); final AtomicInteger count = new AtomicInteger(); diff --git a/src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java b/src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java index 18430707bd..b3f1959e80 100644 --- a/src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java +++ b/src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java @@ -22,7 +22,6 @@ import org.junit.Test; import org.mockito.*; -import static java.util.concurrent.Flow.*; import io.reactivex.rxjava4.core.*; import io.reactivex.rxjava4.core.Scheduler.Worker;