Skip to content

Commit 86cd3b7

Browse files
fix(makefile): exclude web install for dbt 1.6 to fix test (#5964)
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 7bd09ef commit 86cd3b7

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

.github/workflows/pr.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,12 @@ jobs:
514514
echo "DBT version is ${{ matrix.dbt-version }} (>= 1.6.0), keeping semantic_models and metrics sections"
515515
fi
516516
517-
make dbt-fast-test
517+
# dbt 1.6 installs without web/lsp (pydantic conflict); skip collecting those tests
518+
if [[ "${{ matrix.dbt-version }}" == "1.6" ]]; then
519+
pytest -n auto -m "dbt and fast" --reruns 3 --ignore=tests/lsp --ignore=tests/web
520+
else
521+
make dbt-fast-test
522+
fi
518523
- name: Test SQLMesh info in sushi_dbt
519524
working-directory: ./examples/sushi_dbt
520525
run: |

Makefile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,12 @@ install-dev-dbt-%:
4646
echo "Applying numpy<2 constraint for dbt $$version"; \
4747
$(SED_INPLACE) 's/"numpy"/"numpy<2"/g' pyproject.toml; \
4848
fi; \
49-
$(MAKE) install-dev; \
49+
if [ "$$version" = "1.6.0" ]; then \
50+
echo "Installing without web/lsp for dbt 1.6.0 (fastapi>=0.136 needs pydantic v2; dbt 1.6 needs pydantic v1)"; \
51+
$(PIP) install -e ".[dev,slack,dlt]" ./examples/custom_materializations; \
52+
else \
53+
$(MAKE) install-dev; \
54+
fi; \
5055
if [ "$$version" = "1.6.0" ]; then \
5156
echo "Applying overrides for dbt 1.6.0"; \
5257
$(PIP) install 'pydantic>=2.0.0' 'google-cloud-bigquery==3.30.0' 'databricks-sdk==0.28.0' \

0 commit comments

Comments
 (0)