|
44 | 44 | path, so attribution files generated from a branch pipeline are complete rather |
45 | 45 | than empty. |
46 | 46 |
|
| 47 | +### Changed: `@SocketSecurity ignore` requires write access |
| 48 | + |
| 49 | +- An ignore command suppresses a security alert, but the CLI honored one from any |
| 50 | + commenter, including a drive-by comment from someone with no access to the |
| 51 | + repository. Commands are now accepted only from an author with write access. |
| 52 | +- On GitHub this is read from the `author_association` GitHub already returns with |
| 53 | + each comment, so it costs no extra request: `OWNER`, `MEMBER` and `COLLABORATOR` |
| 54 | + are honored, and `CONTRIBUTOR`, `FIRST_TIME_CONTRIBUTOR`, `MANNEQUIN` and `NONE` |
| 55 | + are not. |
| 56 | +- GitLab notes carry no equivalent field, so project membership is read once per |
| 57 | + run (only when an ignore command is present) and Developer or above is required. |
| 58 | + If that lookup cannot be answered — a `CI_JOB_TOKEN` generally cannot read the |
| 59 | + members API — the command is still honored and a warning names the author, so |
| 60 | + enabling this does not silently break pipelines that relied on ignore commands. |
| 61 | + Use a `GITLAB_TOKEN` with API read access to get enforcement. |
| 62 | +- A rejected command is logged and is also absent from the ignore telemetry, which |
| 63 | + records what was acted on. |
| 64 | + |
47 | 65 | ### Fixed: pull request and merge request comment accuracy |
48 | 66 |
|
49 | 67 | - Per-alert ignore instructions now use ecosystem-qualified package names and |
|
56 | 74 | published badge, use a text label. |
57 | 75 | - Shared security comment copy no longer describes GitLab merge request output |
58 | 76 | as Socket for GitHub. |
| 77 | +- Updating a security comment in the legacy table format no longer raises on a |
| 78 | + scoped package name. That path split the package cell on every `@`, so a name |
| 79 | + carrying its own `@` unpacked into three values; it now splits from the right, |
| 80 | + matching the current comment format. Ignore commands for a scoped package are |
| 81 | + accepted there in both the ecosystem-qualified and bare forms. |
| 82 | +- Server URLs read from `GITHUB_SERVER_URL` and `CI_SERVER_URL` are validated as |
| 83 | + http(s) URLs before being composed into a diff scan's external link, matching |
| 84 | + the check already applied to the other repository URLs read from CI. |
59 | 85 |
|
60 | 86 | ## 2.8.1 |
61 | 87 |
|
|
0 commit comments