Skip to content

ESC menu can remain disabled after a save game fails to load #3053

Description

@bobtista

Prerequisites

  • I have searched for similar issues and confirmed this is not a duplicate

Game Version

  • Command & Conquer Generals
  • Command & Conquer Generals: Zero Hour
  • Other (please specify below)

Bug Description

If a save game fails while loading the map-state block, the error message appears and the game returns to the main menu as expected. However, the ESC menu no longer opens in any single-player game started afterward. Saving, loading, changing options, and returning to the main menu are unavailable until the game is restarted.

Expected: a failed load should not affect the ESC menu in subsequently started games.

Actual: pressing ESC does nothing for the rest of the process. Restarting the game restores normal behavior.

Reproduction Steps

  1. Start a single-player game, save it, and return to the main menu.
  2. Corrupt the save so loading fails while reading CHUNK_GameStateMap.
  3. Select the save from Load Game.
  4. Dismiss the “There was an error loading the game” message.
  5. Start a skirmish or campaign mission.
  6. Press ESC. The quit menu does not open.
  7. Restart the game and start another match. ESC works again.

Additional Context

GameStateMap::xfer sets TheGameLogic->setLoadingSave(TRUE) before transferring the map-state data and clears it only at the end of the successful load path. An exception skips that clear. The subsequent engine resets do not reset the flag, and canOpenQuitMenu() refuses to open the menu while isLoadingSave() remains true.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions