Skip to content

Export: Apply author and date filters to custom post types in export_wp()#12106

Open
shrivastavanolo wants to merge 1 commit into
WordPress:trunkfrom
shrivastavanolo:fix/export-wp-cpt-author-date-filters
Open

Export: Apply author and date filters to custom post types in export_wp()#12106
shrivastavanolo wants to merge 1 commit into
WordPress:trunkfrom
shrivastavanolo:fix/export-wp-cpt-author-date-filters

Conversation

@shrivastavanolo

Copy link
Copy Markdown

Previously, the author, start_date, and end_date arguments passed to export_wp() were silently ignored when exporting a custom post type. Only the built-in post types (post, page, attachment) respected these filters due to an in_array() guard that excluded CPTs.

Remove the in_array() restriction and replace it with a simpler 'all' !== $args['content'] check. By this point in the function, any invalid CPT has already fallen back to 'post' and any CPT with can_export disabled has also fallen back to 'post', so all remaining non-'all' values are guaranteed to be valid exportable post types.

Update the docblock for the author, start_date, and end_date params to reflect that these arguments now apply to all post types except when content is 'all'.

Note: the export UI does not yet show author, date, or status filter controls when a CPT is selected — that is a separate follow-up.

Trac ticket: https://core.trac.wordpress.org/ticket/36340

Use of AI Tools

AI assistance: Yes
Tool(s): Claude
Model(s): Opus 4.6
Used for: Initial code skeleton; final implementation was reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shreya0shrivastava.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant