Skip to content

Build/Test Tools: Replace the first-time contributor welcome action#12120

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:ticket/65432-github-actions-node24
Open

Build/Test Tools: Replace the first-time contributor welcome action#12120
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:ticket/65432-github-actions-node24

Conversation

@itzmekhokan

Copy link
Copy Markdown

Summary

  • wow-actions/welcome@v1.3.1 was the only GitHub Action still running on the deprecated Node.js 20 runtime, and no Node.js 24 release exists for it.
  • All other actions already resolve to the node24 runtime (or are composite / docker actions), so this was the last source of node20 deprecation warnings in CI.
  • Reimplements the first-time-contributor welcome comment as an actions/github-script step, matching the other jobs in the same workflow. Removes the final node20 dependency and a third-party action while keeping the welcome behavior intact.

Audit results

Every action in .github/workflows/ was checked against its runs.using runtime. After this change, none run on node20:

Action Pinned version Runtime
actions/checkout v6.0.2 ✅ node24
actions/setup-node v6.4.0 ✅ node24
actions/cache v5.0.5 ✅ node24
actions/upload-artifact v7.0.1 ✅ node24
actions/download-artifact v8.0.1 ✅ node24
actions/github-script v8.0.0 ✅ node24
shivammathur/setup-php 2.37.1 ✅ node24
slackapi/slack-github-action v3.0.3 ✅ node24
astral-sh/setup-uv v7.6.0 ✅ node24
github/codeql-action/upload-sarif v4.35.4 ✅ node24
WordPress/props-bot-action @trunk ✅ node24
ramsey/composer-install 4.0.0 ✅ composite
codecov/codecov-action v5.5.3 ✅ composite
docker://rhysd/actionlint v1.7.11 ✅ docker
wow-actions/welcome v1.3.1 ❌ node20 → removed in this PR

Result: wow-actions/welcome@v1.3.1 was the sole node20 holdout (no node24 release exists). Replacing it with an actions/github-script step eliminates the last source of node20 deprecation warnings in CI.

Trac ticket: https://core.trac.wordpress.org/ticket/65432

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 4.8
Used for: Code analysis, test implementation, and workflow management.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like side effect of AI changes 🤔

`wow-actions/welcome` is the only GitHub Action still running on the
deprecated Node.js 20 runtime, and it has no release targeting Node.js 24.

Switch to GitHub's official `actions/first-interaction` action, which runs
on Node.js 24 and posts a comment on a contributor's first pull request.
This removes the final node20 dependency from CI while keeping the welcome
message intact.

Fixes #65432.
@itzmekhokan itzmekhokan force-pushed the ticket/65432-github-actions-node24 branch from 807389c to 8cd8dad Compare June 9, 2026 06:32
@itzmekhokan

Copy link
Copy Markdown
Author

Seems like side effect of AI changes 🤔

@mukeshpanchal27 — you're right, the first pass was over-built. I've reverted it.

The only actual node20 holdout in .github/workflows/ is wow-actions/welcome, which is unmaintained and has no node24 release (even its default branch still targets node20). So rather than a version bump, I've swapped it for GitHub's official actions/first-interaction@v3.1.0 (node24), SHA-pinned per our convention. The welcome message itself is unchanged.

Two minor behavioral notes with the official action:

  • It posts a static message (no templating), so the greeting drops the @author mention → Hi there!.
  • It has no reaction feature, so the 🎉 reaction is gone.

If preserving the @mention/reaction is preferred, I'm happy to go with a small actions/github-script step instead — just let me know which you'd rather have in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants