From 34d0705c3673cf6dc51440202a828d4c274ca9d3 Mon Sep 17 00:00:00 2001 From: d3rv1sh Date: Mon, 8 Jun 2026 16:17:19 +0400 Subject: [PATCH] Code Modernization: Use str_contains() in wp-includes/blocks/cover.php Replace `strpos() !== false` with `str_contains()` in the Cover block's video provider detection logic. `str_contains()` was introduced in PHP 8.0 and WordPress includes a polyfill since version 5.9. This makes the code more readable and aligns with the ongoing modernization effort. Follow-up to [r60269], [r60939]. Trac ticket: https://core.trac.wordpress.org/ticket/65408 Props Dervish12. Co-Authored-By: Claude Opus 4.6 (1M context) --- src/wp-includes/blocks/cover.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wp-includes/blocks/cover.php b/src/wp-includes/blocks/cover.php index 8da5db23ddc3f..16533acacd764 100644 --- a/src/wp-includes/blocks/cover.php +++ b/src/wp-includes/blocks/cover.php @@ -39,13 +39,13 @@ function render_block_core_cover( $attributes, $content ) { $lower_src = strtolower( $iframe_src ); $provider = null; - if ( strpos( $lower_src, 'youtube.com' ) !== false || strpos( $lower_src, 'youtu.be' ) !== false ) { + if ( str_contains( $lower_src, 'youtube.com' ) || str_contains( $lower_src, 'youtu.be' ) ) { $provider = 'youtube'; - } elseif ( strpos( $lower_src, 'vimeo.com' ) !== false ) { + } elseif ( str_contains( $lower_src, 'vimeo.com' ) ) { $provider = 'vimeo'; - } elseif ( strpos( $lower_src, 'videopress.com' ) !== false ) { + } elseif ( str_contains( $lower_src, 'videopress.com' ) ) { $provider = 'videopress'; - } elseif ( strpos( $lower_src, 'wordpress.tv' ) !== false ) { + } elseif ( str_contains( $lower_src, 'wordpress.tv' ) ) { $provider = 'wordpress-tv'; }