Skip to content

Editor: Fix link color CSS cascade conflict for duplicate blocks with identical markup#12126

Open
USERSATOSHI wants to merge 2 commits into
WordPress:trunkfrom
USERSATOSHI:fix/elements-class-name-collision
Open

Editor: Fix link color CSS cascade conflict for duplicate blocks with identical markup#12126
USERSATOSHI wants to merge 2 commits into
WordPress:trunkfrom
USERSATOSHI:fix/elements-class-name-collision

Conversation

@USERSATOSHI

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/65435

Description

This fixes a CSS cascade bug where identical block content produces duplicate wp-elements-* class names, causing parent block element styles (e.g. link colors) to incorrectly override child block styles.

Root cause

wp_get_elements_class_name() generates CSS class names via md5( serialize( $block ) ).
When two blocks have identical parsed data (e.g. two Paragraph blocks with the same text, one standalone and one inside a Group), they produce the same class.
The Style Engine deduplicates the rule, and since the parent Group's rule renders later in DOM order, it overrides the child Paragraph's style.

A contributing factor: elements.php is required before layout.php in wp-settings.php, so wp_render_elements_support_styles() runs before wp_add_parent_layout_to_parsed_block().
If layout ran first, nested blocks would have a parentLayout key, producing different hashes.

Fix

Introduces a collision tracker via static $seen_hashes in wp_get_elements_class_name(). When a hash collision is detected, an incrementing counter is appended before re-hashing, producing a unique class name per duplicate instance. This ensures the Style Engine outputs distinct CSS rules for each block instance, preserving correct cascade order.

Testing

Added Test cases for these cases.

  • tests/phpunit/tests/block-supports/wpRenderElementsSupportStyles.php::test_elements_block_support_styles_with_duplicate_blocks
  • tests/phpunit/tests/block-supports/wpRenderElementsSupport.php::test_elements_block_support_class_with_duplicate_blocks

Screenshots

Before After
image image

Credits

  • @dpmehta: Initial investigation, root cause analysis, and Gutenberg fix prototype.

References

Use of AI Tools

AI assistance: Yes
Tool(s): OpenCode
Model(s): deepseek-v4-flash-free
Used for: I used AI only for creating the test scaffolding. Code is reviewed and written by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@USERSATOSHI USERSATOSHI marked this pull request as ready for review June 8, 2026 14:30
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props tusharbharti.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant