Add requirement for test files for each license rule

[armijnhemel]

Short Description

There should be a requirement that there should be a test file for each license rule that is added to the licensedb.

Possible Labels

• new feature

Select Category

• Enhancement
• Add License/Copyright
• Scan Feature
• Packaging
• Documentation
• Expand Support
• Other

Describe the Update

There are currently some tests for existing rules, but not every rule has a test file:

$ find src/licensedcode/data/rules/ | wc -l
36483

$ find tests/licensedcode/data/datadriven/ -type f| grep yml | wc -l
4368

How This Feature will help you/your organization

It will help catch regressions whenever new rules are added.

Possible Solution/Implementation Details

Every addition to the licensedb should get a corresponding test file.

Example/Links if Any

Can you help with this Feature

[armijnhemel]

Alternatively, as discussed with @pombredanne , we could also include a reference in PURL notation in the YAML frontmatter for each rule, something like:

test_file: pkg:sid/busybox.net/busybox@1.35.0/busybox-1.35.0/e2fsprogs/fsck.c

[armijnhemel]

Another option would be to add SWHID ( https://www.softwareheritage.org/software-hash-identifier-swhid/ ), or to use both a PURL reference, as well as SWHID

[pombredanne]

SWHID would limit this to only resolve through SWH, which would be quite limiting IMHO and too brittle as dependent on a bit-for-bit identical file or file tree.

A PURL could work, or just a plain URL too or both, or a systematic download and cache of the file. The PURL use a subpath I think: pkg:sid/busybox.net/busybox@1.35.0#busybox-1.35.0/e2fsprogs/fsck.c