GH-50257: [CI][Docs] Fix doxygen failing due to double backticks#50259
Conversation
|
|
|
@AntoinePrv FYI |
pitrou
left a comment
There was a problem hiding this comment.
If it fixes the CI then good 🤷
|
@pitrou let's not merge yet, this fixed doxygen but I think the docs job still fail due to the last PR merged also breaking docs: I can see some doctest failures locally now that the job has run to completion: |
|
It seems to be passing on CI and not related to the issue I pointed. It might be a stale local environment from my side. As I can't reproduce on CI, I think we can ignore my local failure. |
|
I've just confirmed locally that replacing double backticks with single backtics indeed allowed doxygen to complete, docs got built and Just a note on that local doctest failure @raulcd
It's because of pandas version pre 3.0 (which still allows python 3.10 ... but doctest CI job got updated from
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ad31a1c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
apache#50259) ### Rationale for this change Doxygen is currently failing on main ### What changes are included in this PR? Remove double backticks because they trip doxygen. ### Are these changes tested? I have tested them locally with: `archery docker run conda-python-docs` Without the change I could reproduce the CI issue. With the change the job is successful. ### Are there any user-facing changes? No * GitHub Issue: apache#50257 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Rok Mihevc <rok@mihevc.org>
Rationale for this change
Doxygen is currently failing on main
What changes are included in this PR?
Remove double backticks because they trip doxygen.
Are these changes tested?
I have tested them locally with:
archery docker run conda-python-docsWithout the change I could reproduce the CI issue. With the change the job is successful.
Are there any user-facing changes?
No