[datafusion-spark] Add physical implementations for functions that only have simplify() #22012
coderfender
started this conversation in
General
Replies: 2 comments 1 reply
-
|
Tagging folks who might have an opinion here : @andygrove , @mbutrovich , @comphead , @parthchandra , @shehabgamin , @Jefffrey |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
I'm finding it a little confusing where the discussion is meant to be had; I originally raised the query in the Discord, before also mentioning it in the epic: Then a separate issue was created: But now a discussion is created. Could we align where exactly the discussion is meant to be had. As for my thoughts, I already put them here: |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Several functions in
datafusion-sparkcurrently only implement simplify() and throw errors in invoke_with_args(). This causes issues for downstream projects like Comet that convert physical plans directly without going through DataFusion's logical optimizerThis discussion is to see if we could get consensus on the approach since the functions should both support direct datafusion use cases while also providing easy access to downstream projects like comet / lakesail etc
Some open questions worth discussion
Related issue: #21959
Beta Was this translation helpful? Give feedback.
All reactions