From f13b780e359bf7b762abc85c767ae1965a510e35 Mon Sep 17 00:00:00 2001 From: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com> Date: Mon, 7 Sep 2026 12:12:30 -0500 Subject: [PATCH] fix(benchmarks): validate predicate_eval results The predicate_eval benchmark template had no `result` directive, so `benchmark_runner predicate_eval --result-mode validate` silently verified nothing: it reported success without comparing any query output. Add a `result` directive pointing at a per-query CSV keyed by `${NAME}`, mirroring the convention used by clickbench and h2o. Co-Authored-By: Claude Opus 5 --- .../predicate_eval/predicate_eval.benchmark.template | 2 ++ 1 file changed, 2 insertions(+) diff --git a/benchmarks/sql_benchmarks/predicate_eval/predicate_eval.benchmark.template b/benchmarks/sql_benchmarks/predicate_eval/predicate_eval.benchmark.template index 0030a7e946eca..e2e3d6175e8d7 100644 --- a/benchmarks/sql_benchmarks/predicate_eval/predicate_eval.benchmark.template +++ b/benchmarks/sql_benchmarks/predicate_eval/predicate_eval.benchmark.template @@ -31,4 +31,6 @@ true run sql_benchmarks/predicate_eval/queries/${SUBGROUP}/q${QPAD}.sql +result sql_benchmarks/predicate_eval/results/${NAME}.csv + cleanup sql_benchmarks/predicate_eval/init/cleanup.sql