Repository navigation
fix(py_console_script_binary): only create _script_gen for the exec cfg - #4219
Open
robinlinden wants to merge 1 commit into
Open
robinlinden wants to merge 1 commit into
robinlinden wants to merge 1 commit into
Conversation
Without this, `py_console_script_gen` exists for both the target and exec config which causes issues when cross-compiling.
Contributor
Author
|
|
robinlinden
marked this pull request as ready for review
October 5, 2026 19:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this,
py_console_script_genexists for both the target and exec config which causes issues when cross-compiling.I use py_console_script_binary for glad2 which I pass as a tool to a genrule, but starting with rules_python 2.0.0 I get the following error when e.g. cross-compiling to wasm:
With this change, Bazel seems happy to only run the
py_console_script_genbits for the exec config and my cross-compilation works again.