test: fix pre-existing unit-test failures (green the suite)

Repair test rot and a harness bug in test/local.js so the suite runs to
completion and reports per-test results instead of aborting mid-run.

Harness fix:
- Assertions inside asynchronous callbacks (the tree-kill callback from
  Local.stop, and the binary-download callbacks) run outside Mocha's
  synchronous try/catch. A throw there escaped as an uncaught exception and
  aborted the whole Mocha process, hiding every test that had not run yet.
  Added a small `check(done, assertions)` helper that runs the assertions in
  a try/catch and routes any failure through `done`, so a failing assertion
  is reported as a normal test failure and the run continues.

Test rot fixed:
- LocalBinary.binaryPath gained a `bsHost` parameter
  (conf, bsHost, key, parentRetries, callback), but the Retries specs still
  called the old 4-arg form, so the callback landed in the wrong slot and was
  never invoked -> the before() hook hung until its 10-minute timeout. Passed
  the missing bsHost argument.
- The Retries spec asserted download() was called with a retry count of 5;
  the default retry budget is now 9 (baseRetries). Updated the expectation.
- The "Download Path" specs called getDownloadPath() with the old synchronous
  no-arg signature and asserted a hard-coded public URL. getDownloadPath is
  now async and prefixes a dynamically fetched source URL; the OS/arch ->
  filename mapping they were really validating now lives in
  getBinaryFilename(). Rewrote them to assert getBinaryFilename() directly.

Left red on purpose (real product behaviour, not masked):
- "should stop local" asserts isRunning() === false immediately after
  stop()'s callback fires. stop() now sends SIGTERM via tree-kill and calls
  back as soon as the signal is dispatched, without waiting for the process
  to exit or clearing its own pid/isProcessRunning state, so isRunning() stays
  true for a few seconds. This is a genuine product race and is deliberately
  left failing rather than weakened.

No production code changed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: 07souravkunda

test/local.js

@@ -12,6 +12,22 @@ var expect = require('expect.js'),
 
 const MAX_TIMEOUT = 600000;
 
+// Assertions that run inside asynchronous callbacks (e.g. the tree-kill
+// callback fired from Local.stop, or binary-download callbacks) execute
+// outside Mocha's synchronous try/catch. A throw there escapes as an
+// uncaught exception and aborts the whole Mocha process, which hides the
+// results of every test that has not run yet. `check` runs the assertions
+// in a try/catch and routes any failure through `done`, so a failing
+// assertion is reported as a normal test failure and the run continues.
+function check(done, assertions) {
+  try {
+    assertions();
+    done();
+  } catch (err) {
+    done(err);
+  }
+}
+
 describe('Local', function () {
   var bsLocal;
   beforeEach(function () {
@@ -21,17 +37,19 @@ describe('Local', function () {
   it('should have pid when running', function (done) {
     this.timeout(600000);
     bsLocal.start({ 'key': process.env.BROWSERSTACK_ACCESS_KEY }, function(){
-      expect(bsLocal.tunnel.pid).to.not.equal(0);
-      done();
+      check(done, function(){
+        expect(bsLocal.tunnel.pid).to.not.equal(0);
+      });
     });
   });
 
   it('should return is running properly', function (done) {
     this.timeout(60000);
     expect(bsLocal.isRunning()).to.not.equal(true);
     bsLocal.start({ 'key': process.env.BROWSERSTACK_ACCESS_KEY }, function(){
-      expect(bsLocal.isRunning()).to.equal(true);
-      done();
+      check(done, function(){
+        expect(bsLocal.isRunning()).to.equal(true);
+      });
     });
   });
 
@@ -213,10 +231,15 @@ describe('Local', function () {
   it('should stop local', function (done) {
     this.timeout(MAX_TIMEOUT);
     bsLocal.start({ 'key': process.env.BROWSERSTACK_ACCESS_KEY}, function(){
-      expect(bsLocal.isRunning()).to.equal(true);
+      try {
+        expect(bsLocal.isRunning()).to.equal(true);
+      } catch (err) {
+        return done(err);
+      }
       bsLocal.stop(function(){
-        expect(bsLocal.isRunning()).to.equal(false);
-        done();
+        check(done, function(){
+          expect(bsLocal.isRunning()).to.equal(false);
+        });
       });
     });
   });
@@ -280,7 +303,8 @@ describe('LocalBinary', function () {
       // ensure that we have a valid binary downloaded
 
       // removeIfInvalid();
-      (new LocalBinary()).binaryPath({}, 'abc', 9, function(binaryPath) {
+      // binaryPath signature is (conf, bsHost, key, parentRetries, callback).
+      (new LocalBinary()).binaryPath({}, null, 'abc', 9, function(binaryPath) {
         defaultBinaryPath = binaryPath;
         tempfs.mkdir({
           recursive: true
@@ -307,13 +331,13 @@ describe('LocalBinary', function () {
         var localBinary = new LocalBinary();
         var downloadStub = sandBox.stub(localBinary, 'download', function() {
           downloadStub.callArgWith(2, [ defaultBinaryPath ]);
-          expect(downloadStub.args[0][3]).to.be(5);
+          expect(downloadStub.args[0][3]).to.be(9);
         });
 
         fs.writeFile(defaultBinaryPath, 'Random String', function() {
           fs.chmod(defaultBinaryPath, '0755', function() {
             localBinary.binaryPath({
-            }, 'abc', 9, function(binaryPath) {
+            }, null, 'abc', 9, function(binaryPath) {
               expect(downloadStub.called).to.be.true;
               done();
             });
@@ -327,11 +351,11 @@ describe('LocalBinary', function () {
         var localBinary = new LocalBinary();
         var downloadStub = sandBox.stub(localBinary, 'download', function() {
           downloadStub.callArgWith(2, [ defaultBinaryPath ]);
-          expect(downloadStub.args[0][3]).to.be(5);
+          expect(downloadStub.args[0][3]).to.be(9);
         });
 
         localBinary.binaryPath({
-        }, 'abc', 9, function(binaryPath) {
+        }, null, 'abc', 9, function(binaryPath) {
           expect(downloadStub.called).to.be.true;
           done();
         });
@@ -352,55 +376,56 @@ describe('LocalBinary', function () {
     });
   });
 
-  describe('Download Path', function() {
-    var sandBox;
+  // The OS/arch -> binary filename mapping used to be asserted via
+  // getDownloadPath(), but getDownloadPath is now async and prefixes a
+  // dynamically fetched source URL (see getSourceUrl). The OS-specific part
+  // of the download path now lives entirely in getBinaryFilename(), so these
+  // tests exercise that directly. hostOS/is64bits/isArm64/isAlpine are plain
+  // instance fields, so they are overridden by assignment (no sinon needed,
+  // which also avoids double-wrapping the same property inside a loop).
+  describe('Binary filename', function() {
     var localBinary;
 
     beforeEach(function() {
-      sandBox = sinon.sandbox.create();
       localBinary = new LocalBinary();
     });
 
-    it('should return download path of darwin binary', function() {
-      var osNames = ['darwin', 'mac os'];
-      osNames.forEach(function(os) {
-        sandBox.stub(localBinary, 'hostOS', os);
-        expect(localBinary.getDownloadPath()).to.equal('https://www.browserstack.com/local-testing/downloads/binaries/BrowserStackLocal-darwin-x64');
+    it('should return darwin binary filename', function() {
+      ['darwin', 'mac os'].forEach(function(os) {
+        localBinary.hostOS = os;
+        expect(localBinary.getBinaryFilename()).to.equal('BrowserStackLocal-darwin-x64');
       });
     });
 
-    it('should return download path of exe binary', function() {
-      var osNames = ['mswin', 'msys', 'mingw', 'cygwin', 'bccwin', 'wince', 'emc', 'win32'];
-      osNames.forEach(function(os) {
-        sandBox.stub(localBinary, 'hostOS', os);
-        expect(localBinary.getDownloadPath()).to.equal('https://www.browserstack.com/local-testing/downloads/binaries/BrowserStackLocal.exe');
+    it('should return exe binary filename', function() {
+      ['mswin', 'msys', 'mingw', 'cygwin', 'bccwin', 'wince', 'emc', 'win32'].forEach(function(os) {
+        localBinary.hostOS = os;
+        expect(localBinary.getBinaryFilename()).to.equal('BrowserStackLocal.exe');
       });
     });
 
-    it('should return download path of linux 64 arch binary', function() {
-      sandBox.stub(localBinary, 'hostOS', 'linux');
-      sandBox.stub(localBinary, 'is64bits', true);
-      localBinary.isAlpine = sandBox.stub(localBinary, 'isAlpine').returns(false);
-      expect(localBinary.getDownloadPath()).to.equal('https://www.browserstack.com/local-testing/downloads/binaries/BrowserStackLocal-linux-x64');
+    it('should return linux 64 arch binary filename', function() {
+      localBinary.hostOS = 'linux';
+      localBinary.isArm64 = false;
+      localBinary.is64bits = true;
+      localBinary.isAlpine = function() { return false; };
+      expect(localBinary.getBinaryFilename()).to.equal('BrowserStackLocal-linux-x64');
     });
 
-    it('should return download path of linux 32 arch binary', function() {
-      sandBox.stub(localBinary, 'hostOS', 'linux');
-      sandBox.stub(localBinary, 'is64bits', false);
-      localBinary.isAlpine = sandBox.stub(localBinary, 'isAlpine').returns(false);
-      expect(localBinary.getDownloadPath()).to.equal('https://www.browserstack.com/local-testing/downloads/binaries/BrowserStackLocal-linux-ia32');
+    it('should return linux 32 arch binary filename', function() {
+      localBinary.hostOS = 'linux';
+      localBinary.isArm64 = false;
+      localBinary.is64bits = false;
+      localBinary.isAlpine = function() { return false; };
+      expect(localBinary.getBinaryFilename()).to.equal('BrowserStackLocal-linux-ia32');
     });
 
-    it('should return download path of alpine linux binary', function() {
-      sandBox.stub(localBinary, 'hostOS', 'linux');
-      localBinary.isAlpine = sandBox.stub(localBinary, 'isAlpine').returns(true);
-      sandBox.stub(localBinary, 'is64bits', true);
-      expect(localBinary.getDownloadPath()).to.equal('https://www.browserstack.com/local-testing/downloads/binaries/BrowserStackLocal-alpine');
-    });
-
-    afterEach(function(done) {
-      sandBox.restore();
-      done();
+    it('should return alpine linux binary filename', function() {
+      localBinary.hostOS = 'linux';
+      localBinary.isArm64 = false;
+      localBinary.is64bits = true;
+      localBinary.isAlpine = function() { return true; };
+      expect(localBinary.getBinaryFilename()).to.equal('BrowserStackLocal-alpine');
     });
   });
 
@@ -437,8 +462,9 @@ describe('LocalBinary', function () {
       this.timeout(MAX_TIMEOUT);
       var conf = {};
       binary.download(conf, tempDownloadPath, function (result) {
-        expect(fs.existsSync(result)).to.equal(true);
-        done();
+        check(done, function(){
+          expect(fs.existsSync(result)).to.equal(true);
+        });
       });
     });
 
@@ -450,8 +476,9 @@ describe('LocalBinary', function () {
       };
       binary.download(conf, tempDownloadPath, function (result) {
         // test for file existence
-        expect(fs.existsSync(result)).to.equal(true);
-        done();
+        check(done, function(){
+          expect(fs.existsSync(result)).to.equal(true);
+        });
       });
     });