Skip to content

Commit 24cbafc

Browse files
ai: apply changes for #866 (1 review thread)
Addresses: - #3599651153 at .github/workflows/engineer-bot.yml:89 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent 6d1e842 commit 24cbafc

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

.github/workflows/engineer-bot-followup.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,12 @@ jobs:
101101
# check) would sweep up these bot-untouched dirty files. Keep ONLY the
102102
# agent's edits in the tree.
103103
- name: Revert poetry lock/pyproject churn (keep only the agent's edits)
104-
run: git checkout -- poetry.lock pyproject.toml || true
104+
# No `|| true`: `git checkout -- <tracked-file>` exits 0 for both the
105+
# clean and the reverted-churn cases, so a non-zero exit means the revert
106+
# genuinely failed (e.g. the files went untracked/missing) and the dirty
107+
# tree would otherwise be swept into the followup's fixup commit. Fail
108+
# loudly here instead of masking it.
109+
run: git checkout -- poetry.lock pyproject.toml
105110

106111
# Shared prelude: mint the engineer-bot token (pushes fixup commits, posts
107112
# replies) + the engine-scoped token, set up Node, install the engine.

.github/workflows/engineer-bot.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,12 @@ jobs:
8888
# bot-untouched dirty files and refuses to open the PR (they aren't in the
8989
# agent's touched_files). Keep ONLY the agent's edits in the tree.
9090
- name: Revert poetry lock/pyproject churn (keep only the agent's edits)
91-
run: git checkout -- poetry.lock pyproject.toml || true
91+
# No `|| true`: `git checkout -- <tracked-file>` exits 0 for both the
92+
# clean and the reverted-churn cases, so a non-zero exit means the revert
93+
# genuinely failed (e.g. the files went untracked/missing) and the dirty
94+
# tree would otherwise resurface as a confusing publish-time error. Fail
95+
# loudly here instead of masking it.
96+
run: git checkout -- poetry.lock pyproject.toml
9297

9398
# Shared prelude: mint the engineer-bot token (pushes the fix branch,
9499
# comments) + the engine-scoped token, set up Node, install the pinned

0 commit comments

Comments
 (0)