Skip to content

Commit da9a056

Browse files
ai: apply changes for #862 (3 review threads)
Addresses: - #3592446970 at .github/workflows/reviewer-bot.yml:85 - #3598366324 at .bot/config.yaml:66 - #3598678252 at docs/superpowers/specs/2026-07-14-onboard-bot-engine-design.md:197
1 parent 0afa116 commit da9a056

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

.bot/config.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,11 @@ pr_body_template: |-
5151
# for when the active interpreter already has the deps.
5252
# - `git diff` is pinned to HEAD-relative / index forms. A bare (git,diff)
5353
# prefix would allow `git diff --no-index /etc/passwd /dev/null`, reading
54-
# arbitrary ABSOLUTE paths and bypassing safe_path.
54+
# arbitrary ABSOLUTE paths and bypassing safe_path. Pinning to `HEAD` also
55+
# defeats the `git diff HEAD --no-index <abs> <abs>` prefix-match variant:
56+
# with a revision (HEAD) present git is in tree-diff mode and rejects paths
57+
# outside the repo (`fatal: '<path>' is outside repository`), so --no-index
58+
# cannot escape the worktree — verified on the runner.
5559
# - `cat`, `ls`, `find` are deliberately ABSENT — they read arbitrary absolute
5660
# paths (the bash tool validates only the argv PREFIX, not path args). The
5761
# agent has read_file / glob / grep for repo-relative reads, all safe_path-

docs/superpowers/specs/2026-07-14-onboard-bot-engine-design.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ is in scope, matching what the repo runs today.
3030

3131
## Engine pin
3232

33-
- **Engine SHA:** `d780b2da60bb1ac68bb5cd1acb7cabf495b3ff2d` (current
34-
`databricks-bot-engine` `main` HEAD).
33+
- **Engine SHA:** `d780b2da60bb1ac68bb5cd1acb7cabf495b3ff2d` (this section
34+
reflects the original reusable-workflow draft; the SHA actually installed by
35+
the shipped local-composite workflows is tracked in the Reviewer update below).
3536
- The SHA is used in BOTH the `uses:` ref AND the `engine-ref:` input of each
3637
caller, so the workflow definition and the installed engine match. Never
3738
`@main` (force-pushable; the job carries secrets).
@@ -194,9 +195,10 @@ databricks-bot-engine, adopting **both** bots and used to surface onboarding
194195
friction back to the engine.
195196

196197
### Reviewer — flipped to PAT-free App-auth
197-
Pinned to engine SHA `d24ca2171d191a652a67f4f43995f0959c9a5791` (post-#107, which
198-
selects the engineer author flow from the issue **Type** — Bug ⇒ bug-fix, Feature
199-
⇒ enhancement; earlier drafts pinned `b6205fb`, post-#100). Both reviewer
198+
Pinned to engine SHA `d9cb1e63dc31eed550194a29d1cfd7de9c9c793b` (post-#107, which
199+
selects the engineer author flow from the issue **Type** — Bug ⇒ bug-fix,
200+
Task/Feature ⇒ task (the engine renamed the old `enhancement` flow to `task`);
201+
earlier drafts pinned `d24ca217`, then `b6205fb`, post-#100). Both reviewer
200202
workflows pass `engine-auth: app` and **drop `engine-pat`**: the reusable mints a
201203
short-lived, engine-scoped GitHub App installation token from the review-bot App
202204
creds it already receives. No `BOT_ENGINE_PAT` secret. The same SHA is pinned in

0 commit comments

Comments
 (0)