Multi gpu ptycho#234
Merged
arthurmccray merged 12 commits intoJun 2, 2026
Merged
Conversation
…lti GPU compatibility
Closed
arthurmccray
merged commit 7b7566d
into
electronmicroscopy:diffractive_imaging
4 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this PR addressees
Adding multi-gpu support to iterative ptycho. Example notebook here.
Actually I added new constraint stuff in that version I think, so the version at this commit should work for the code here, though I don't think it talks about the effective batch size rescaling.
This also enables easier streaming of larger-than-VRAM datasets.
I am also making constraints easier to use with a dataclass, tbd if that get's wrapped up in this PR but it doesn't have to.
Also this PR is waiting on #213 to be merged. We should make sure that doesn't conflict with any of this.
What should the reviewer(s) do
This isn't a PR into dev so whatever you think is necessary..