Crash in wasm-emscripten-finalize with -g -fwasm-exceptions

[paradust7]

Version of emscripten/emsdk:
emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 6.0.4 (fe5be6a)
clang version 24.0.0git (https:/github.com/llvm/llvm-project c050c487e9edb97ef44f53cb29fe1d8bcddb8f76)
Target: wasm32-unknown-emscripten
Thread model: posix

Compile with

$ em++ -O0 -g -fwasm-exceptions -sSTACK_OVERFLOW_CHECK=2 repro.cpp -o out.js
wasm-emscripten-finalize: /b/s/w/ir/cache/builder/emscripten-releases/binaryen/src/wasm/wasm-debug.cpp:439: void wasm::Debug::AddrExprMap::add(Expression *, const BinaryLocations::Span): Assertion `!endMap.contains(span.end)' failed.
em++: error: '/emsdk/upstream/bin/wasm-emscripten-finalize -g --bigint --no-dyncalls --no-legalize-javascript-ffi --check-stack-overflow --dwarf out.wasm -o out.wasm --detect-features' failed (received SIGABRT (-6))

Reproducer

int main() {
  try {
    throw 1;
  } catch (int e) {
    return e;
  }
}

[sbc100]

I was able to bisect this to a binaryen change WebAssembly/binaryen#8862.

[tlively]

It looks like this was fixed by that change. @sbc100, can you confirm?

[sbc100]

No the crash is caused by #8862.

[sbc100]

Proposes solution from AI WebAssembly/binaryen#8960

[tlively]

Well I must be doing something wrong then. I've checked out 6.0.4 and updated my .emscripten to point to LLVM from emsdk's 6.0.4 and my own binaryen checkout. With tot binaryen, I can't reproduce the crash. When I revert WebAssembly/binaryen#8862 locally, it starts crashing.

Can you send me the .wasm file you're using to reproduce crashes on tot binaryen?

[sbc100]

Oh, yes sorry this is fixed on main for binaryen, but the roller is currently blocked on test_dwarf failing.

[sbc100]

I think the current roll is going to fix this: https://chromium-review.git.corp.google.com/c/emscripten-releases/+/8175193

[hoodmane]

Presumably this is the same as this issue:
WebAssembly/binaryen#8940

[sbc100]

Yup closing as dup of that, and also because its fixed upstream