From e3f95d6764793aeb0721bc4351042ed950087d7d Mon Sep 17 00:00:00 2001 From: stuartmorgan-g Date: Wed, 24 Jun 2026 14:27:38 -0400 Subject: [PATCH 1/2] [ci] Pass correct flags to `validate` The `validate` repo tool command should be passed [extra flags](https://github.com/flutter/packages/blob/main/.ci/scripts/validate.sh) in CI to check for missing changes. This adds a GitHub actions version of the flutter/packages calls which pass flags including the PR's labels. --- .github/workflows/validate_repo.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/validate_repo.yaml b/.github/workflows/validate_repo.yaml index b18dda2f..f9c632a1 100644 --- a/.github/workflows/validate_repo.yaml +++ b/.github/workflows/validate_repo.yaml @@ -32,10 +32,19 @@ jobs: with: dart-sdk: main + # For pre-submit, check for missing or breaking changes that don't have a + # corresponding override label. + # For post-submit, ignore platform interface breaking version changes and + # missing version/CHANGELOG detection since PR-level overrides aren't available + # in post-submit. - name: Run 'validate' for general repo best practices if: ${{ !cancelled() && steps.setup.outcome == 'success' }} run: | - dart pub global run flutter_plugin_tools validate + if [ "${{ github.event_name }}" == "push" ]; then + dart pub global run flutter_plugin_tools validate --ignore-platform-interface-breaks + else + dart pub global run flutter_plugin_tools validate --check-for-missing-changes --pr-labels="$(gh api --jq '.labels.[].name' /repos/flutter/core-packages/pulls/${{ github.event.number }} | paste -sd ',' -)" + fi - name: Run 'format' to check for formatting violations if: ${{ !cancelled() && steps.setup.outcome == 'success' }} From fe82aa6e0e93f6f71346d775067396d8116b4165 Mon Sep 17 00:00:00 2001 From: stuartmorgan-g Date: Wed, 24 Jun 2026 14:31:57 -0400 Subject: [PATCH 2/2] Add token for gh --- .github/workflows/validate_repo.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/validate_repo.yaml b/.github/workflows/validate_repo.yaml index f9c632a1..9b5d0a32 100644 --- a/.github/workflows/validate_repo.yaml +++ b/.github/workflows/validate_repo.yaml @@ -45,6 +45,8 @@ jobs: else dart pub global run flutter_plugin_tools validate --check-for-missing-changes --pr-labels="$(gh api --jq '.labels.[].name' /repos/flutter/core-packages/pulls/${{ github.event.number }} | paste -sd ',' -)" fi + env: + GH_TOKEN: ${{ github.token }} - name: Run 'format' to check for formatting violations if: ${{ !cancelled() && steps.setup.outcome == 'success' }}