Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for detecting VS Code based editors using the new 'dashTool' query parameter in addition to the legacy 'ide' parameter. It updates query parameter parsing, survey environment matching, preference checks, and documentation links to use the new 'isVsCode' helper, and adds corresponding unit tests. Feedback on the changes suggests a fix in 'meetsEnvironmentRequirement' to check the resolved environment from '_currentDevEnvironment()' instead of 'ga.ideLaunched.isEmpty' to prevent bypassing the environment check when 'ga.ideLaunched' is empty but VS Code is detected.
|
Ah. Yes. I think that corresponds w/ the work tracked by https://github.com/flutter/dash-devexp-internal/issues/94. Maybe? If you want to take this bit too (tracked in https://github.com/flutter/dash-devexp-internal/issues/95), good by me! And, thanks! |
Part of #9811. (I'm pretty unfamiliar with this codebase so I leaned hard on Claude. I spent some time thinking it through but do let me know if I'm headed in the wrong direction!)
Ok, so... this, adds
DevToolsQueryParams.isVsCode(dashTool == 'vscode-plugins' || ide == 'VSCode') and uses it in place ofide == 'VSCode'checks for:This keeps VS Code–based editors that pass
dashTool(and notide) from being treated as CLI or Android Studio.Follow-ups (tracked in #9811): IntelliJ survey mapping via
dashTooland analytics support fordashTool/dashIdeName.There are no user-visible changes so I applied
release-notes-not-required. (Yell if this is incorrect!)(Fixes: https://github.com/flutter/dash-devexp-internal/issues/95)
Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed.Tests checklist
AI-tooling checklist
Feature-change checklist
release-notes-not-requiredlabel or left a comment requesting the label be added.packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.If you need help, consider asking for help on Discord.