Skip to content

fix(website): match recreation generator's param name to amplitude - #498

Open
EtienneLescot wants to merge 1 commit into
mainfrom
fix-website-recreation-amplitude
Open

fix(website): match recreation generator's param name to amplitude#498
EtienneLescot wants to merge 1 commit into
mainfrom
fix-website-recreation-amplitude

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The v1.10.0 release build's docs-refresh step failed: `check:recreation` crashed with `ReferenceError: amplitude is not defined`.
  • `gen-recreation.mjs` lifts `ClipWaveform`'s height/opacity expressions verbatim out of `V4Timeline.tsx` and re-evaluates them as a `new Function(...)`, but hardcoded the parameter name as `h`. The component had renamed that variable to `amplitude`, so the lifted body referenced an undeclared name.
  • Renamed the `Function` parameters to `amplitude` and regenerated `generated.ts` (also picks up an unrelated locale drift: `effects.title` "Video Effects" → "Composition").

Test plan

  • `node scripts/gen-recreation.mjs --check` passes locally
  • `node scripts/gen-recreation.mjs` regenerates cleanly with no further diff

Summary by CodeRabbit

  • Updates
    • Renamed the Video Effects panel to Composition for clearer terminology across the recreation interface.
    • Preserved existing waveform behavior while improving consistency in the underlying configuration, with no change to the visible output.

…form's amplitude rename

waveBarHeightPct/waveBarOpacity re-evaluate expressions lifted verbatim out of
V4Timeline.tsx, but declared their own Function parameter as the old name h.
The component renamed h to amplitude, so the lifted body threw
ReferenceError: amplitude is not defined and the docs build's
check:recreation step failed on every run since.
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: add5bede-bc13-4ee3-bef1-e94af8b0b089

📥 Commits

Reviewing files that changed from the base of the PR and between 26ee275 and c105e95.

📒 Files selected for processing (2)
  • website/scripts/gen-recreation.mjs
  • website/src/components/Recreation/generated.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The PR renames local waveform evaluator parameters to amplitude and changes the generated effects panel title from Video Effects to Composition.

Changes

Waveform evaluator naming

Layer / File(s) Summary
Waveform evaluator parameter rename
website/scripts/gen-recreation.mjs
The bar-height and opacity evaluators use amplitude instead of h. Their expressions and outputs remain unchanged.

Effects panel title

Layer / File(s) Summary
Generated panel title update
website/src/components/Recreation/generated.ts
The effects panel title and its provenance entry change from Video Effects to Composition.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to c105e

This localized change aligns the recreation generator with the component’s parameter name and refreshes the generated output; the documented checks pass, so no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the bug and testing, but it omits the required issue, change type, release impact, desktop impact, screenshots, and Testing sections. Add the missing template sections, select applicable options, replace the blank issue reference with an applicable value, and rename Test plan to Testing.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the generator parameter-name fix and matches the main change in the pull request.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-website-recreation-amplitude

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant