fix(website): match recreation generator's param name to amplitude - #498
fix(website): match recreation generator's param name to amplitude#498EtienneLescot wants to merge 1 commit into
Conversation
…form's amplitude rename waveBarHeightPct/waveBarOpacity re-evaluate expressions lifted verbatim out of V4Timeline.tsx, but declared their own Function parameter as the old name h. The component renamed h to amplitude, so the lifted body threw ReferenceError: amplitude is not defined and the docs build's check:recreation step failed on every run since.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe PR renames local waveform evaluator parameters to ChangesWaveform evaluator naming
Effects panel title
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change aligns the recreation generator with the component’s parameter name and refreshes the generated output; the documented checks pass, so no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Test plan
Summary by CodeRabbit