fix(ci): don't let the docs refresh block Microsoft Store publishing - #499
fix(ci): don't let the docs refresh block Microsoft Store publishing#499EtienneLescot wants to merge 1 commit into
Conversation
publish-msstore needs publish-release to succeed. The docs-refresh step lived in that same job with no continue-on-error, so its failure (unrelated to whether the release itself published) marked the whole job failed and silently skipped the Store submission via the needs graph. That's what happened to v1.10.0.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe stable-release workflow now allows documentation deployment failures without failing ChangesRelease publishing
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The workflow change makes post-publish documentation refresh failures non-blocking so they cannot prevent the Microsoft Store publishing job from proceeding; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same fix as PR #499 on main, applied here so a rebuild dispatched against this frozen release branch actually reaches publish-msstore.
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Test plan
Summary by CodeRabbit