Skip to content

fix(ci): don't let the docs refresh block Microsoft Store publishing - #499

Open
EtienneLescot wants to merge 1 commit into
mainfrom
fix-msstore-gating
Open

fix(ci): don't let the docs refresh block Microsoft Store publishing#499
EtienneLescot wants to merge 1 commit into
mainfrom
fix-msstore-gating

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • v1.10.0's Microsoft Store submission was silently skipped: `publish-msstore` requires `publish-release` to succeed via `needs`, and the docs-refresh step inside `publish-release` (bookkeeping that runs after the actual release assets are already published) failed with no `continue-on-error`, marking the whole job failed even though the release itself published fine.
  • Added `continue-on-error: true` to the docs-refresh step, matching the same pattern already used for promote.yml's main-sync step: publishing is done by the time it runs, so its own failure shouldn't cascade to unrelated downstream jobs.

Test plan

  • N/A — workflow-only change, exercised on the next release build.

Summary by CodeRabbit

  • Chores
    • Improved release reliability by allowing documentation deployment issues to avoid blocking Microsoft Store publishing.

publish-msstore needs publish-release to succeed. The docs-refresh step lived
in that same job with no continue-on-error, so its failure (unrelated to
whether the release itself published) marked the whole job failed and
silently skipped the Store submission via the needs graph. That's what
happened to v1.10.0.
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d7189da5-c7be-41a6-8d4d-ebe4296c5712

📥 Commits

Reviewing files that changed from the base of the PR and between 26ee275 and aca5887.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The stable-release workflow now allows documentation deployment failures without failing publish-release or blocking dependent Microsoft Store publishing.

Changes

Release publishing

Layer / File(s) Summary
Documentation deployment tolerance
.github/workflows/build.yml
The stable-release documentation deployment step retains its timeout and now uses continue-on-error: true. Downstream Store publishing can proceed when documentation deployment fails.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to aca58

The workflow change makes post-publish documentation refresh failures non-blocking so they cannot prevent the Microsoft Store publishing job from proceeding; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: siddharthvaddem

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description clearly explains the workflow change and testing status, but it omits most required template sections and leaves the related issue field incomplete. Add the related issue, type of change, release impact, desktop impact, and screenshots sections, and state why screenshots are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the CI change that prevents docs refresh failures from blocking Microsoft Store publishing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-msstore-gating

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

EtienneLescot added a commit that referenced this pull request Aug 24, 2026
Same fix as PR #499 on main, applied here so a rebuild dispatched against
this frozen release branch actually reaches publish-msstore.
@EtienneLescot

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant