release v8.4.1 (or v8.5.0)

[atsju]

EDIT: i removed original message an just keep track of ongoing actions

Proposed changes for v8.4.1

-Fix profile plot temporarily not updating after subtracting or averaging wavefronts (#343 done in Februrary)
-Fix build issue with Clang compiler (#347)
-Fix outline helper dialog not closing when the application exits (#352)
-Fix minor UI issue on the 16 diameters profile plot (#355)
-Fix potential dip in profile plot when using Gaussian blur + minor display issues (#359)
-Fix very minor gui issue - save file dialog says foucault instead of ronchi when saving ronchi (#359)
-Fix scroll did not update min/max values in countour plot (#359)
-Fix some of the dialog not closing on app close (#360)
-Fix Gaussian blur checkbox not displaying actually applied settings (#361)
-Fix central hole and regions were not cleaned from previous OLN file (#362)
-Fix elliptical flat configuration bug and ensure minor axis is always smaller (#364)
-Fix import wft config yes button was not working at all (#371)

Ready for review

-Build pipeline now publishes a .dmg package for macOS users (#348 )
-Build pipeline now publishes an .AppImage package for Linux users (#365)
-Fix ignore edge region. Center edge had wrong size and could have wrong coordinates (#375)
-(8.5.0) IMPROVE Zernike enable table is saved for each wft. Display diff (#369)

In progress

-[NOT READY] fix wrong zernike fit in case of (annular obstruction AND aperture reduction) (#372)
-[not ready for review] fix mirror settings modified in registry before user press accept button (#370)
-Reviewed wavefront code (#356)

[gr5]

Fix profile plot showing the wrong plot after subtraction
Change to:
Fix profile plot temporarily not updating after subtracting or averaging wavefronts

Get rid of quote after the 16. You can just say 16 diameters. Or diameters at 16 angles.

[gr5]

Your proposal is fine with me but I don't think there is a rush. I'll be back home with more free time in 8 days. I'm actually testing PR #359 at the moment.

I agree with the basic sentiment that we don't need a ton of QA before we create a release. It's just that maybe it's better to do one release than 2 releases a week apart.

[Lucassifoni]

Hi,
I am happy to finish the two PRs but my availability is spotty at best right now since I am on holiday. My next moment of contiguous availability looks to be similar to gr5's in ~7-8 days.

[atsju]

Sorry I din't want to insist on the fact it needs to be done fast. We can do the release later, even if it's in a month or two I'm fine with it.

I was just thinking we can do a release for the Linux/Mac first as this might be very valuable for some users.

And then have a ton of bug fix and features before next release. With all the fixes it will probably be some time before we are ready to release again. I hope this clarifies.

[gr5]

All the PRs that you think are ready will be tested by me within 10 days or so.

[gr5]

pr #359 is particularly difficult as it has the potential to cause difficult to notice bugs with subtraction and averaging features. Perhaps something else as well - oh yeah - ronchi and foucault feature could be affected as well.

[atsju]

I will let you manage the merge and order. I'm fine with not doing the intermediate release if you prefer to have one larger release.

[githubdoe]

I'm surprised by these. They work on what I'm using.

Fix profile plot temporarily not updating after subtracting or averaging wavefronts

Fix minor UI issue on the 16 diameters profile plot

There is no longer a 16 diameters profile plot. It is just one of the right pop up menus on the profile. When selected it displays with any other profile plot also selected.

[githubdoe]

The current profile plot should look like this. Does the one your using? I'm currently using DFTFringe and do not want to risk loosing my work to start up that latest release. I thought the latest release looked like this.

[gr5]

Dale if you want to see the issue, it's described here from a guy named Zack Steinburg who I've coincidentally met in person.

#345

There's a 17 second video showing the bug. It's extremely minor. Anyway @atsju fixed it. Or you can just read the text how to duplicate the issue.

[gr5]

Fix profile plot temporarily not updating after subtracting or averaging wavefronts

Maybe you fixed this one but didn't check it in. The other 2 plots update immediately but the profile plot doesn't update instantly. You have to do one of a few dozen things to get it to reload. For example, click on the wavefront. Or click recalculate. Or change the gaussian blur. Or one of many other ways to get it to reload (e.g. right click on it and change the settings).

[gr5]

With this big flurry of activity it may seem like there are major changes but there are not. Most of the activity are not even code changes but changes in the build process for mac and linux. Most of the PRs are only a few lines of code.

[gr5]

Oh. And yes, that's what the popup menu looks like.

[githubdoe]

I hope the profile also looks like that. There are less buttons on the top than older versions.

[githubdoe]

When I get some time I will diff what I have against the master. Currently Qt says I'm on a project called master. But at one time I had a branch called master on my machine I think that was not really the remote master. I get so confused by github as you all know.