Skip to content

fix: apply shell options to status - #3060

Open
kris70lesgo wants to merge 1 commit into
go-task:mainfrom
kris70lesgo:fix/status-shell-options
Open

kris70lesgo wants to merge 1 commit into
go-task:mainfrom
kris70lesgo:fix/status-shell-options

Conversation

@kris70lesgo

@kris70lesgo kris70lesgo commented Sep 30, 2026 •

Copy link
Copy Markdown

Description

Fixes #2469.

Status commands did not inherit global or task-level set and shopt
options. As a result, a status pipeline could succeed even when
pipefail was configured and an earlier command failed.
This applies the effective task shell options when evaluating status
commands. It also adds coverage for pipefail, nullglob, successful
pipelines, and command-level option scope.

Checklist

  • I have read and followed the Contribution Guide.
  • I have disclosed the use of any AI-generated content in this pull request per the AI Usage Policy.
  • I fully understand the changes and have hand-written the description (No AI) of this pull request.

@kris70lesgo

kris70lesgo commented Oct 10, 2026 •

Copy link
Copy Markdown
Author

@trulede @andreynering can u review the pr ?

@vmaerten

Copy link
Copy Markdown
Member

Hi @kris70lesgo,
Thanks for your PR!
Just a few things:

  • @andreynering isn't the only maintainer. Also, pinging maintainers won't speed up the review process. We're all volunteers doing our best to review contributions in our spare time.
  • Your PR description raises some suspicions about AI usage:
    • The hard wrapping at around 80 characters, which is sometimes seen in AI-generated Markdown.
    • The very structured and impersonal writing style, following a problem -> consequence -> solution -> tests pattern.
    • Some generic phrasing, such as "This applies the effective task shell options when evaluating status commands."
    • The final sentence reads like an automated summary of the code changes and tests.

None of these are proof of AI usage on their own, but taken together, they raise some doubts, especially since you explicitly checked the box stating that the description was written without AI assistance.

Please make sure your PR descriptions follow our contribution guidelines. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seems like pipefail is not applied to status commands

2 participants