Extend "Go to Definition" to cover class member definitions.#405
Extend "Go to Definition" to cover class member definitions.#405isc-klu wants to merge 1 commit into
Conversation
|
@isc-klu Can you explain how this addresses the issue? The code looks fine but I am not sure how the automatic symbol reference chat feature definition gets to this code. |
|
It’s not clear from the VSCode documentation what is required for automatic symbol references to work. However, @hsyhhssyy’s comments in #397 suggest that the lack of automatic symbol references for members is related to the following issues:
As noted by @hsyhhssyy, automatic symbol references do work for class symbols. Since we currently don’t support workspace symbols (including for class symbols), the second issue is likely unrelated. With that in mind, I focused on addressing the first issue. Fixing Go to Definition for member definitions also resolves the automatic symbol references problem. Given this, it would be more accurate to position this PR as a fix for Go to Definition, with improved automatic symbol references as a side effect. I’ll update the PR description shortly. |
Fix #397
Go to Definition wasn't working for class member definition. For example, when users presses F12 on
Foobarof the following code, they see "No definition found.” Fixing this issue also extends automatic symbol references to class members.