Item 18: course SVG corpus → O2 flat-vector (mobile legibility floor 74/80 → 0) + blocking gate - #445
Closed
pftg wants to merge 32 commits into
Closed
Item 18: course SVG corpus → O2 flat-vector (mobile legibility floor 74/80 → 0) + blocking gate#445pftg wants to merge 32 commits into
pftg wants to merge 32 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… (SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…(SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…(SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ctor (SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…Gs → O2 flat-vector (SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… (SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…or (SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ector (SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…r (SW-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…W-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… (SW-3) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…2 flat-vector (SW-3) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… flat-vector (SW-3) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…W-3) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… (SW-4) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…t-vector (SW-4) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-vector (SW-4) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…> O2 flat-vector (SW-4) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…r (SW-4) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…(SW-4) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
item18 cleared the whole course SVG corpus to O2 flat-vector (74/80 under the 9px@390 mobile floor → 0 across SW-1..SW-4). bin/hugo-build now runs check-svg-floor with SVG_FLOOR_BLOCK=1 and fails the build if any exhibit SVG regresses below the floor. 'fix the gate, not the instance' - the report-only net that enumerated the backlog is now the guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
Next review available in: 58 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (46)
📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Closing unmerged. Paul's review: the original hand-drawn exhibits look better than the O2 conversions AND better than careful style-preserving re-fits. Root cause: forcing 46 wide/dense hand-drawn reference exhibits into a 720-wide, >=17px mobile-legible box inherently degrades them (elegant single-row strips become grids, horizontal flows become tall stacks) - no 'preserve the style' survives the re-layout. The 9px mobile floor is not worth degrading good desktop-first exhibits. Master already carries the originals (never merged), so the live site is unaffected. check-svg-floor stays as a REPORT-ONLY advisory of the known mobile-legibility tech-debt; it must NOT be a blocking gate that forces redesign. Branch kept in history if any single exhibit is ever worth a bespoke redraw. |
pftg
added a commit
that referenced
this pull request
Aug 13, 2026
…closed) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 18 — Course SVG corpus → O2 flat-vector (mobile legibility floor: 74/80 → 0)
Clears the course-wide exhibit-SVG legibility defect: every hand-drawn SVG was drawn at viewBox 900-1000 with 10-18px fonts, rendering 4.5-8px at 390px — below the 9px mobile floor. All are redrawn to the O2 flat-vector spec (viewBox W=720, min font ≥17px → ≥9.21px@390) with meaning preserved.
Burn-down (4 sub-waves)
bin/check-svg-floornow reports: all 80 SVGs clear the 9px@390 floor.The gate flip (fix the gate, not the instance)
The report-only net that enumerated this backlog is now the guard:
bin/hugo-buildrunscheck-svg-floorwithSVG_FLOOR_BLOCK=1and fails the build if any exhibit SVG regresses below the floor. Same pattern as the course-path/validator gates.O2 discipline (per
.okf/design/house-visual-spec.md)White cards on #faf7f2, Space Grotesk titles, ruby = the one action/anti-pattern, green = money/success only, amber = warning, purple = alt-artifact/categorical, labels-inside-shapes, dash-not-em-dash. Two spec-endorsed "fewer nodes at W=720" simplifications (kit-sample-row 8→4 col, pre-launch-gates dropped illegible sub-bullets) — meaning kept, alt/aria rewritten.
Gates
bin/hugo-build: green (8/8 validators + the new blocking svg-floor gate).qtest --changedreports "no visual-affecting changes": the visual suite masks<img>SVGs (the very gapcheck-svg-floorwas built to cover), so rendered review + the floor gate are the real gates, notbin/test/bin/dtest.🤖 Generated with Claude Code