fix(oracledb): modernize adapter config#513
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 74.30% 74.33% +0.02%
==========================================
Files 439 439
Lines 53273 53339 +66
Branches 8451 8455 +4
==========================================
+ Hits 39585 39648 +63
Misses 11061 11061
- Partials 2627 2630 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
d267e6a to
95a3730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the Oracle adapter config surface for current python-oracledb connection, pool, callback, and driver-feature behavior.
Details
OracleConnectionParamsandOraclePoolParamswith current python-oracledb options for authentication, networking, TLS, sharding, tagging, DRCP, pool configuration, and database event support.threadedforwarding while preserving native poolsession_callbackbehavior.on_connection_createin a defined order for sync and async pools, including awaitable async callbacks.Review Notes
This branch is rebased onto the latest
mainand keeps the Oracle changes focused on config fidelity and callback behavior.