Skip to content

fix(oracledb): modernize adapter config#513

Merged
cofin merged 1 commit into
mainfrom
codex/adapter-config-oracledb
Jun 9, 2026
Merged

fix(oracledb): modernize adapter config#513
cofin merged 1 commit into
mainfrom
codex/adapter-config-oracledb

Conversation

@cofin

@cofin cofin commented Jun 9, 2026

Copy link
Copy Markdown
Member

Summary

Refreshes the Oracle adapter config surface for current python-oracledb connection, pool, callback, and driver-feature behavior.

Details

  • Expands OracleConnectionParams and OraclePoolParams with current python-oracledb options for authentication, networking, TLS, sharding, tagging, DRCP, pool configuration, and database event support.
  • Narrows finite Oracle settings with enums and literals for protocol, server type, pool boundary, vector return format, and SQLSpec event backend selection.
  • Removes stale threaded forwarding while preserving native pool session_callback behavior.
  • Chains SQLSpec internal setup, native session callbacks, and on_connection_create in a defined order for sync and async pools, including awaitable async callbacks.
  • Clarifies SQLSpec event queue support versus python-oracledb database events, and avoids advertising an adapter switch that cannot force unsupported native pipeline execution.
  • Adds unit coverage for the typed config surface, extra kwarg forwarding, stale option filtering, and callback ordering.

Review Notes

This branch is rebased onto the latest main and keeps the Oracle changes focused on config fidelity and callback behavior.

@codecov-commenter

codecov-commenter commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.33%. Comparing base (0dc2787) to head (95a3730).

Files with missing lines Patch % Lines
sqlspec/adapters/oracledb/config.py 97.46% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   74.30%   74.33%   +0.02%     
==========================================
  Files         439      439              
  Lines       53273    53339      +66     
  Branches     8451     8455       +4     
==========================================
+ Hits        39585    39648      +63     
  Misses      11061    11061              
- Partials     2627     2630       +3     
Flag Coverage Δ
integration 58.28% <91.13%> (+0.03%) ⬆️
py3.10 71.11% <94.93%> (+0.03%) ⬆️
py3.11 71.13% <94.93%> (+0.02%) ⬆️
py3.12 71.12% <94.93%> (+0.02%) ⬆️
py3.13 71.12% <94.93%> (+0.02%) ⬆️
py3.14 73.48% <85.18%> (+<0.01%) ⬆️
unit 61.54% <93.67%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sqlspec/adapters/oracledb/config.py 87.86% <97.46%> (+2.91%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cofin cofin force-pushed the codex/adapter-config-oracledb branch from d267e6a to 95a3730 Compare June 9, 2026 03:43
@cofin cofin marked this pull request as ready for review June 9, 2026 03:49
@cofin cofin merged commit e393979 into main Jun 9, 2026
23 checks passed
@cofin cofin deleted the codex/adapter-config-oracledb branch June 9, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants