Skip to content

ESLint fixes in src/client/ioc#15043

Merged
kimadeline merged 2 commits into
microsoft:mainfrom
kimadeline:fix-eslint-src-client-ioc
Dec 23, 2020
Merged

ESLint fixes in src/client/ioc#15043
kimadeline merged 2 commits into
microsoft:mainfrom
kimadeline:fix-eslint-src-client-ioc

Conversation

@kimadeline

Copy link
Copy Markdown

No description provided.

@kimadeline kimadeline added the no-changelog No news entry required label Dec 23, 2020
@kimadeline kimadeline self-assigned this Dec 23, 2020
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #15043 (0bbd701) into main (86d556f) will decrease coverage by 0%.
The diff coverage is 33%.

@@          Coverage Diff           @@
##            main   #15043   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        558      558           
  Lines      26220    26223    +3     
  Branches    3729     3729           
======================================
+ Hits       17149    17150    +1     
- Misses      8377     8379    +2     
  Partials     694      694           
Impacted Files Coverage Δ
src/client/ioc/container.ts 56% <0%> (-4%) ⬇️
src/client/ioc/types.ts 100% <ø> (ø)
src/client/ioc/serviceManager.ts 39% <50%> (-1%) ⬇️
...t/application/diagnostics/checks/lsNotSupported.ts 75% <0%> (ø)
.../application/diagnostics/checks/envPathVariable.ts 93% <0%> (ø)
...pplication/diagnostics/checks/pythonInterpreter.ts 91% <0%> (ø)
...pplication/diagnostics/checks/upgradeCodeRunner.ts 96% <0%> (ø)
...ication/diagnostics/checks/macPythonInterpreter.ts 85% <0%> (ø)
...ication/diagnostics/checks/powerShellActivation.ts 80% <0%> (ø)
...ication/diagnostics/checks/pythonPathDeprecated.ts 96% <0%> (ø)
... and 2 more

@kimadeline
kimadeline marked this pull request as ready for review December 23, 2020 16:43
@kimadeline
kimadeline merged commit 01796ad into microsoft:main Dec 23, 2020
@kimadeline
kimadeline deleted the fix-eslint-src-client-ioc branch December 23, 2020 18:08
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65%. Comparing base (86d556f) to head (0bbd701).
⚠️ Report is 2661 commits behind head on main.

Files with missing lines Patch % Lines
src/client/ioc/container.ts 0% 1 Missing ⚠️
src/client/ioc/serviceManager.ts 50% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #15043   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        558      558           
  Lines      26220    26223    +3     
  Branches    3729     3729           
======================================
+ Hits       17149    17150    +1     
- Misses      8377     8379    +2     
  Partials     694      694           
Files with missing lines Coverage Δ
src/client/ioc/types.ts 100% <ø> (ø)
src/client/ioc/container.ts 56% <0%> (-4%) ⬇️
src/client/ioc/serviceManager.ts 39% <50%> (-1%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants