opcache.file_cache_permissions

Author: jack-worman

ext/opcache/tests/file_cache_permissions.phpt

@@ -0,0 +1,32 @@
+--TEST--
+opcache.file_cache_permissions
+--EXTENSIONS--
+opcache
+--SKIPIF--
+<?php
+$fileCache = sys_get_temp_dir() . '/9664b02e-6f64-42dd-b088-99f3dccc3422';
+@mkdir($fileCache, 0777, true);
+?>
+--INI--
+opcache.enable="1"
+opcache.enable_cli="1"
+opcache.file_cache="{TMP}/9664b02e-6f64-42dd-b088-99f3dccc3422"
+opcache.file_cache_only="1"
+opcache.file_update_protection="0"
+opcache.file_cache_permissions="0660"
+--FILE--
+<?php
+$fileCache = sys_get_temp_dir() . '/9664b02e-6f64-42dd-b088-99f3dccc3422';
+$iterator = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($fileCache, FilesystemIterator::SKIP_DOTS));
+foreach ($iterator as $splFileInfo) {
+    if (!$splFileInfo->isFile()) {
+        continue;
+    }
+    if (str_ends_with($splFileInfo->getPathname(), '.bin')) {
+        var_dump(sprintf('%o', fileperms($splFileInfo->getPathname()) & 0o777));
+        break;
+    }
+}
+?>
+--EXPECT--
+string(3) "660"

ext/opcache/zend_accelerator_module.c

@@ -18,7 +18,6 @@
 */
 
 #include <time.h>
-#include <fcntl.h>
 
 #include "php.h"
 #include "ZendAccelerator.h"
@@ -321,7 +320,7 @@ ZEND_INI_BEGIN()
 #endif
 
 	STD_PHP_INI_ENTRY("opcache.file_cache"                    , NULL  , PHP_INI_SYSTEM, OnUpdateFileCache, accel_directives.file_cache,                    zend_accel_globals, accel_globals)
-	STD_PHP_INI_ENTRY("opcache.file_cache_permissions", "384" /* S_IRUSR | S_IWUSR */, PHP_INI_SYSTEM, OnUpdateLong, accel_directives.file_cache_permissions, zend_accel_globals, accel_globals)
+	STD_PHP_INI_ENTRY("opcache.file_cache_permissions", "0600", PHP_INI_SYSTEM, OnUpdateLong, accel_directives.file_cache_permissions, zend_accel_globals, accel_globals)
 	STD_PHP_INI_BOOLEAN("opcache.file_cache_read_only"          , "0"   , PHP_INI_SYSTEM, OnUpdateBool,    accel_directives.file_cache_read_only,          zend_accel_globals, accel_globals)
 	STD_PHP_INI_BOOLEAN("opcache.file_cache_only"               , "0"   , PHP_INI_SYSTEM, OnUpdateBool,	   accel_directives.file_cache_only,               zend_accel_globals, accel_globals)
 	STD_PHP_INI_BOOLEAN("opcache.file_cache_consistency_checks" , "1"   , PHP_INI_SYSTEM, OnUpdateBool,	   accel_directives.file_cache_consistency_checks, zend_accel_globals, accel_globals)

ext/opcache/zend_file_cache.c

@@ -1179,6 +1179,11 @@ int zend_file_cache_script_store(zend_persistent_script *script, bool in_shm)
 		efree(filename);
 		return FAILURE;
 	}
+#ifndef ZEND_WIN32
+	if (fchmod(fd, ZCG(accel_directives).file_cache_permissions) == -1) {
+		zend_accel_error(ACCEL_LOG_WARNING, "Unable to change opcache file permissions in %s: %s (%d)", filename, strerror(errno), errno);
+	}
+#endif
 
 	if (zend_file_cache_flock(fd, LOCK_EX) != 0) {
 		close(fd);

php.ini-development

@@ -1778,7 +1778,7 @@ ldap.max_links = -1
 ;opcache.file_cache=
 
 ; The permissions of the files cached.
-;opcache.file_cache_permissions=384 (0o600)
+;opcache.file_cache_permissions=0600
 
 ; Enables or disables read-only mode for the second level cache directory.
 ; It should improve performance for read-only containers,

php.ini-production

@@ -1780,7 +1780,7 @@ ldap.max_links = -1
 ;opcache.file_cache=
 
 ; The permissions of the files cached.
-;opcache.file_cache_permissions=384 (0o600)
+;opcache.file_cache_permissions=0600
 
 ; Enables or disables read-only mode for the second level cache directory.
 ; It should improve performance for read-only containers,