Skip to content

Commit b467b79

Browse files
authored
Pin pytest below 9.2 until pytest-benchmark is fixed (#1248)
pytest 9.2 removed Node._nodeid, which pytest-benchmark 5.3.0 still reads, so test_benchmark_text_string_to_metric_families errors at setup. The fix (ionelmc/pytest-benchmark#323) is merged but not yet released. Assisted-by: Claude Sonnet 5.5 Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
1 parent f1a0e3a commit b467b79

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎tox.ini‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@ envlist = coverage-clean,py{3.10,3.11,3.12,3.13,3.14,py3.10,3.10-nooptionals},co
55
deps =
66
asgiref
77
coverage
8-
pytest
8+
# pytest 9.2 removed Node._nodeid, which pytest-benchmark 5.3.0 still reads:
9+
# https://github.com/ionelmc/pytest-benchmark/issues/321
10+
# Drop the upper bound once a pytest-benchmark release includes the fix.
11+
pytest<9.2
912
pytest-benchmark
1013
attrs
1114
{py3.10,pypy3.10}: twisted

0 commit comments

Comments
 (0)