From a226ba1dcb9de368ec1b9402649f397b5c36683e Mon Sep 17 00:00:00 2001 From: Gregory Moskaliuk Date: Tue, 17 Nov 2026 23:57:57 +0100 Subject: [PATCH] Preload core view manager prop setters off the UI thread on Android The first prop update of each view manager class looks up its prop setters on the UI thread during the first mount: a `$$PropsSetter` class lookup that throws ClassNotFoundException unless the app generates one, then a reflective scan of the class hierarchy for @ReactProp methods. ReactInstance now does that for View, Text, Image, ScrollView and TextInput on a background thread while the JS bundle loads. The setters are cached in the existing thread-safe maps; if the UI thread gets there first, it computes them itself as before. Co-Authored-By: Claude Opus 5.5 --- .../facebook/react/runtime/ReactInstance.kt | 53 ++++++++++++ .../uimanager/ViewManagerPropertyUpdater.kt | 10 +++ .../ViewManagerPropertyUpdaterTest.kt | 84 +++++++++++++++++++ 3 files changed, 147 insertions(+) create mode 100644 packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ViewManagerPropertyUpdaterTest.kt diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactInstance.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactInstance.kt index de3416e75f46..c1abde5b6e9e 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactInstance.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactInstance.kt @@ -66,10 +66,18 @@ import com.facebook.react.uimanager.UIConstantsProviderBinding import com.facebook.react.uimanager.UIConstantsProviderBinding.ConstantsForViewManagerProvider import com.facebook.react.uimanager.UIManagerModuleConstantsHelper import com.facebook.react.uimanager.ViewManager +import com.facebook.react.uimanager.ViewManagerPropertyUpdater import com.facebook.react.uimanager.ViewManagerRegistry import com.facebook.react.uimanager.ViewManagerResolver import com.facebook.react.uimanager.events.EventDispatcher import com.facebook.react.util.RNLog +import com.facebook.react.views.image.ReactImageManager +import com.facebook.react.views.scroll.ReactNestedScrollViewManager +import com.facebook.react.views.scroll.ReactScrollViewManager +import com.facebook.react.views.text.PreparedLayoutTextViewManager +import com.facebook.react.views.text.ReactTextViewManager +import com.facebook.react.views.textinput.ReactTextInputManager +import com.facebook.react.views.view.ReactViewManager import com.facebook.soloader.SoLoader import com.facebook.systrace.Systrace import com.facebook.systrace.SystraceMessage @@ -270,6 +278,8 @@ internal class ReactInstance( // Initialize the FabricUIManager fabricUIManager.initialize() + preloadCoreViewManagerPropSetters() + Systrace.endSection(Systrace.TRACE_TAG_REACT) Systrace.endSection(Systrace.TRACE_TAG_REACT) } @@ -584,6 +594,49 @@ internal class ReactInstance( SoLoader.loadLibrary("rninstance") } + /** + * The first prop update of each view manager class looks up its prop setters: a `$$PropsSetter` + * class lookup that fails unless the app generates one, then a reflective scan for `@ReactProp` + * methods over the class and its superclasses, all on the UI thread during the first mount. Do + * that for the core components almost every first screen uses on a background thread while the + * JS bundle loads. The setters are cached in thread-safe maps; if the UI thread gets there + * first, it computes them itself as before. + */ + private fun preloadCoreViewManagerPropSetters() { + val viewManagerClasses: List>> = + listOf( + ReactViewManager::class.java, + if (ReactNativeFeatureFlags.enablePreparedTextLayout()) + PreparedLayoutTextViewManager::class.java + else ReactTextViewManager::class.java, + ReactImageManager::class.java, + if (ReactNativeFeatureFlags.useNestedScrollViewAndroid()) + ReactNestedScrollViewManager::class.java + else ReactScrollViewManager::class.java, + ReactTextInputManager::class.java, + ) + Thread( + { + Systrace.beginSection( + Systrace.TRACE_TAG_REACT, + "ReactInstance.preloadCoreViewManagerPropSetters", + ) + try { + for (viewManagerClass in viewManagerClasses) { + ViewManagerPropertyUpdater.preloadManagerSetter(viewManagerClass) + } + } catch (e: RuntimeException) { + // The UI thread computes the setters again on first use and reports the error. + FLog.w(TAG, "Failed to preload view manager prop setters", e) + } finally { + Systrace.endSection(Systrace.TRACE_TAG_REACT) + } + }, + "ReactPropSetterPreload", + ) + .start() + } + private fun createConstants( viewManagers: List>, customDirectEvents: MutableMap?, diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerPropertyUpdater.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerPropertyUpdater.kt index 6ed45e57e0e4..9bd80e45c41d 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerPropertyUpdater.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerPropertyUpdater.kt @@ -101,6 +101,16 @@ public object ViewManagerPropertyUpdater { return props } + /** + * Looks up and caches the prop setters of [managerClass], so that the first prop update of a view + * of that class does not pay for the lookup (a `$$PropsSetter` class lookup and, when there is + * none, a scan of the class hierarchy for [com.facebook.react.uimanager.annotations.ReactProp] + * methods). Safe to call from any thread. + */ + internal fun preloadManagerSetter(managerClass: Class>) { + @Suppress("UNCHECKED_CAST") findManagerSetter(managerClass as Class>) + } + private fun findManagerSetter( managerClass: Class>, ): ViewManagerSetter, V> { diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ViewManagerPropertyUpdaterTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ViewManagerPropertyUpdaterTest.kt new file mode 100644 index 000000000000..650aaf9caef5 --- /dev/null +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ViewManagerPropertyUpdaterTest.kt @@ -0,0 +1,84 @@ +/* + * Copyright (c) Meta Platforms, Inc. and affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + */ + +package com.facebook.react.uimanager + +import android.view.View +import com.facebook.react.bridge.JavaOnlyMap +import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests +import com.facebook.react.uimanager.annotations.ReactProp +import org.assertj.core.api.Assertions.assertThat +import org.junit.After +import org.junit.Before +import org.junit.Test +import org.junit.runner.RunWith +import org.robolectric.RobolectricTestRunner +import org.robolectric.RuntimeEnvironment + +@RunWith(RobolectricTestRunner::class) +class ViewManagerPropertyUpdaterTest { + + private class TestViewManager : SimpleViewManager() { + var testProp: Int? = null + + override fun getName(): String = "TestView" + + override fun createViewInstance(reactContext: ThemedReactContext): View = View(reactContext) + + @ReactProp(name = "testProp") + fun setTestProp(view: View, value: Int) { + testProp = value + } + } + + @Before + fun setUp() { + ReactNativeFeatureFlagsForTests.setUp() + ViewManagerPropertyUpdater.clear() + } + + @After + fun tearDown() { + ViewManagerPropertyUpdater.clear() + } + + @Test + fun setterPreloadedOnAnotherThreadUpdatesProps() { + val preloadThread = Thread { + ViewManagerPropertyUpdater.preloadManagerSetter(TestViewManager::class.java) + } + preloadThread.start() + preloadThread.join() + + val viewManager = TestViewManager() + viewManager.updateProperties( + View(RuntimeEnvironment.getApplication()), + ReactStylesDiffMap(JavaOnlyMap.of("testProp", 42.0)), + ) + + assertThat(viewManager.testProp).isEqualTo(42) + } + + @Test + fun preloadedSetterExportsTheSameProps() { + val propsComputedOnDemand = getNativeProps() + ViewManagerPropertyUpdater.clear() + + ViewManagerPropertyUpdater.preloadManagerSetter(TestViewManager::class.java) + + assertThat(getNativeProps()) + .isEqualTo(propsComputedOnDemand) + .containsEntry("testProp", "number") + } + + @Suppress("UNCHECKED_CAST") + private fun getNativeProps(): Map = + ViewManagerPropertyUpdater.getNativeProps( + TestViewManager::class.java as Class>, + null, + ) +}