refactor(plaid): share service account form

Author: Bill Leoutsakos

apps/sim/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/connect-service-account-modal.tsx

@@ -15,21 +15,19 @@ import { getErrorMessage } from '@sim/utils/errors'
 import { isApiClientError } from '@/lib/api/client/errors'
 import { serviceAccountJsonSchema } from '@/lib/api/contracts/credentials'
 import {
-  type ClientCredentialAccountProviderId,
-  getClientCredentialAccountDescriptor,
-} from '@/lib/credentials/client-credential-accounts/descriptors'
+  getServiceAccountFormDescriptor,
+  type ServiceAccountFormProviderId,
+} from '@/lib/credentials/service-account-form-descriptors'
 import {
   getTokenServiceAccountDescriptor,
   type TokenServiceAccountProviderId,
 } from '@/lib/credentials/token-service-accounts/descriptors'
 import { getServiceAccountCoverageSentence } from '@/lib/integrations/credential-display'
 import {
   ATLASSIAN_SERVICE_ACCOUNT_PROVIDER_ID,
-  PLAID_SERVICE_ACCOUNT_PROVIDER_ID,
   SLACK_CUSTOM_BOT_PROVIDER_ID,
 } from '@/lib/oauth/types'
-import { ClientCredentialAccountModal } from '@/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/client-credential-account-modal'
-import { PlaidServiceAccountModal } from '@/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/plaid-service-account-modal'
+import { ServiceAccountFormModal } from '@/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/service-account-form-modal'
 import { TokenServiceAccountModal } from '@/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/token-service-account-modal'
 import { ConnectSlackBotModal } from '@/app/workspace/[workspaceId]/integrations/components/connect-slack-bot-modal/connect-slack-bot-modal'
 import { withBrandIcon } from '@/blocks/brand-icon'
@@ -46,9 +44,8 @@ export type ServiceAccountProviderId =
   | typeof GOOGLE_SERVICE_ACCOUNT_PROVIDER_ID
   | typeof ATLASSIAN_SERVICE_ACCOUNT_PROVIDER_ID
   | typeof SLACK_CUSTOM_BOT_PROVIDER_ID
-  | typeof PLAID_SERVICE_ACCOUNT_PROVIDER_ID
   | TokenServiceAccountProviderId
-  | ClientCredentialAccountProviderId
+  | ServiceAccountFormProviderId
 
 /** Sim setup guides for each provider, docked bottom-left of each modal. */
 const GOOGLE_SERVICE_ACCOUNT_DOCS_URL = 'https://docs.sim.ai/integrations/google-service-account'
@@ -139,8 +136,9 @@ interface ConnectServiceAccountModalProps {
  * - `atlassian-service-account`: API token + site domain. Validated by the
  *   server against the Atlassian API; user-facing errors are mapped from the
  *   route's `error.code`.
- * - `plaid-service-account`: application client ID + environment secret + one
- *   Item access token. Validated server-side against Plaid `/item/get`.
+ * - descriptor-backed providers: field-driven forms for client-credential
+ *   providers and Plaid Item credentials. Verification remains provider-specific
+ *   on the server.
  */
 export function ConnectServiceAccountModal({
   open,
@@ -154,14 +152,14 @@ export function ConnectServiceAccountModal({
   credentialDescription,
   onCreated,
 }: ConnectServiceAccountModalProps) {
-  const clientCredentialDescriptor = getClientCredentialAccountDescriptor(serviceAccountProviderId)
-  if (clientCredentialDescriptor) {
+  const serviceAccountFormDescriptor = getServiceAccountFormDescriptor(serviceAccountProviderId)
+  if (serviceAccountFormDescriptor) {
     return (
-      <ClientCredentialAccountModal
+      <ServiceAccountFormModal
         open={open}
         onOpenChange={onOpenChange}
         workspaceId={workspaceId}
-        descriptor={clientCredentialDescriptor}
+        descriptor={serviceAccountFormDescriptor}
         serviceName={serviceName}
         serviceIcon={serviceIcon}
         credentialId={credentialId}
@@ -216,21 +214,6 @@ export function ConnectServiceAccountModal({
       />
     )
   }
-  if (serviceAccountProviderId === PLAID_SERVICE_ACCOUNT_PROVIDER_ID) {
-    return (
-      <PlaidServiceAccountModal
-        open={open}
-        onOpenChange={onOpenChange}
-        workspaceId={workspaceId}
-        serviceName={serviceName}
-        serviceIcon={serviceIcon}
-        credentialId={credentialId}
-        initialDisplayName={credentialDisplayName}
-        initialDescription={credentialDescription}
-        onCreated={onCreated}
-      />
-    )
-  }
   return (
     <GoogleServiceAccountModal
       open={open}