Conversation
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Walkthrough
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @vjymisal0, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
| // Forward the run-scoped exporter credentials so child processes can export spans to the run. | ||
| OTEL_EXPORTER_OTLP_HEADERS: z.string().optional(), |
Summary
Child Node.js processes spawned by a task inherit the OTLP endpoint but not its exporter headers. As a result, a child process cannot configure
NodeTracerProvider/OTLPTraceExporterto send spans to the current Trigger.dev run.Preserve the optional
OTEL_EXPORTER_OTLP_HEADERSvalue inRunnerEnvand forward it throughgatherProcessEnv(), alongside the existing endpoint variables. Child processes can now use the standard OpenTelemetry environment configuration without IPC.Test plan
corepack pnpm exec oxlint packages/cli-v3/src/entryPoints/managed/env.tscorepack pnpm exec oxfmt --check packages/cli-v3/src/entryPoints/managed/env.tsgit diff --checkThe full CLI typecheck is currently blocked by pre-existing workspace generation errors (
@trigger.dev/schema-to-jsonand@trigger.dev/databasedeclarations).Fixes #4766