Workaround #4524 by synchronizing tasks set#4569
Merged
Merged
Conversation
armanbilge
commented
Mar 15, 2026
Comment on lines
+283
to
284
| @deprecated("Not intended to be public", "3.7.1") | ||
| final class ConcurrentState( |
Member
Author
There was a problem hiding this comment.
To comply with our no-source-breaking-patches versioning scheme, we may want to hold off the deprecation until 3.8.
Contributor
There was a problem hiding this comment.
Eh, I think it's fine. As fas as I can see, anyone trying to use this would've realized, that they can't (not in any useful way).
durban
approved these changes
Mar 18, 2026
| val currentID: AtomicLong = new AtomicLong(), | ||
| val currentNanos: AtomicLong = new AtomicLong(), | ||
| val tasks: java.util.SortedSet[Task] = | ||
| Collections.synchronizedSortedSet(new ConcurrentSkipListSet(Task.comparator)), |
Contributor
There was a problem hiding this comment.
Could just use a ju.TreeSet instead the ConcurrentSkipListSet. As it is now, on the JVM it's "doubly thread safe". (Which is not incorrect, of course, just unnecessary.)
Contributor
|
@djspiewak Did you really wanted to close this? As far as I can tell, the original issue still exists, and this seems like a reasonable workaround... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4524.