Repository navigation
pr: with -d, no blank line after a last line that lacks a newline - #16636
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Binary size comparison: |
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-dand no header (-t,-T, or a page shorter than 11 lines), a last line without a newline was followed by an extra blank line:GNU adds the blank line of
-donly after a line that ended with a newline.FileLinenow records whether it is an unterminated last line, andwrite_columnsends that row with a single newline in single-column output without a header. With a header and trailer the page is padded to its length anyway, and-Fkeeps the blank line, as GNU does. Multi-column output is unchanged.The test covers
a,a\nbanda\nb\nwith-t -d, and fails onmain. I compared a matrix of inputs (with and without a final newline, form feeds) and options (-d,-t -d,-d -l 10,-d -n -t,-d -F,-T -d,-t -d -o 2) against GNUpr. Every case either matches GNU now or behaves as onmain. The only GNU build I have locally is coreutils 8.32.AI disclosure: written with help from Claude Code. Nothing was derived from GNU source.
🤖 Generated with Claude Code