Repository navigation
Conversation
|
GNU testsuite comparison: |
6d3cf3b to
370c1e7
Compare
|
GNU testsuite comparison: |
370c1e7 to
bff0098
Compare
|
GNU testsuite comparison: |
bff0098 to
c9eff3e
Compare
|
GNU testsuite comparison: |
c6513d5 to
02f294e
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
9599887 to
c5dfe85
Compare
|
GNU testsuite comparison: |
17ac24b to
246d338
Compare
|
GNU testsuite comparison: |
959661c to
79b05e6
Compare
|
GNU testsuite comparison: |
6ce3a00 to
97a50f9
Compare
|
GNU testsuite comparison: |
97a50f9 to
714a72e
Compare
467ccd5 to
64187bf
Compare
|
GNU testsuite comparison: |
|
sorry, it needs to be rebased! |
fce3d31 to
b0c02d9
Compare
|
GNU testsuite comparison: |
|
the test failures are infrastructure or intermittent issues, not regressions caused by our changes to the |
b0c02d9 to
fbf9c75
Compare
|
GNU testsuite comparison: |
5ec5fe3 to
e3f4d2b
Compare
|
GNU testsuite comparison: |
Special permission bits were being lost when install chowned files, since chown inherently strips setuid/setgid bits for security. This change applies a second chmod after chown to preserve those bits. The fix: - Uses libc::chmod for proper special bit support - Updates error handling with io::Error conversion - Adds comprehensive test coverage - Maintains behavior for non-special permissions
e3f4d2b to
c9bbeaf
Compare
|
GNU testsuite comparison: |
|
hi, this one can't be merged as it is:
|
|
checked this against current main and it looks like the original issue has already been addressed upstream.
I also compared the compiled GNU, main, and PR binaries. Main matches GNU on the relevant success and failure paths, while this PR's older implementation can still leave setuid bits set when chown fails. So there's no useful fix left to carry forward here. I'll close this as superseded. Thanks for the review! |
Fixes #9134
install -m4755failed to set special permission bits because chown strips them for security. Added second chmod call after chown and improved error handling with libc::chmod for proper special bit support. Updated callers to handle io::Error and added localized error messages. and tests included.