Skip to content

fix gemma4 to vllm weight conversion#3677

Draft
aireenmei wants to merge 1 commit intomohit/hengtao/gemma4from
mohit/hengtao/aireen/gemma4
Draft

fix gemma4 to vllm weight conversion#3677
aireenmei wants to merge 1 commit intomohit/hengtao/gemma4from
mohit/hengtao/aireen/gemma4

Conversation

@aireenmei
Copy link
Copy Markdown
Collaborator

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/utils/model_creation_utils.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@aireenmei aireenmei force-pushed the mohit/hengtao/aireen/gemma4 branch from 0c5eeb9 to b126e15 Compare April 16, 2026 00:37
@aireenmei aireenmei force-pushed the mohit/hengtao/aireen/gemma4 branch from b126e15 to a4fe344 Compare April 16, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant