Skip to content

Fix job conditions and artifact handling in pypi_release workflow for workflow_dispatch #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 25, 2026
Merged

Fix job conditions and artifact handling in pypi_release workflow for workflow_dispatch #4273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/workflows/pypi_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ on:
publish:
description: 'Set to true to publish to PyPI.'
required: false
default: 'false'
default: false
type: boolean

permissions:
Expand Down Expand Up @@ -83,7 +83,8 @@ jobs:
needs: handle_result
if: |
always() &&
(needs.handle_result.result == 'success' || needs.handle_result.result == 'skipped')
(needs.handle_result.result == 'success' || needs.handle_result.result == 'skipped') &&
(github.event_name == 'repository_dispatch' || inputs.publish)
# "release" environment is configured in MaxText repository settings.
# This environment requires manual approval before proceeding to the next job.
environment: release
Expand All @@ -93,7 +94,9 @@ jobs:

build_maxtext_package:
needs: release_approval
if: needs.release_approval.result == 'success'
if: |
always() &&
(needs.release_approval.result == 'success' || needs.release_approval.result == 'skipped')
uses: ./.github/workflows/build_package.yml
with:
device_type: tpu
Expand All @@ -104,14 +107,15 @@ jobs:

publish_maxtext_to_pypi:
name: Publish MaxText to PyPI
needs: release_approval
needs: [release_approval, build_maxtext_package]
runs-on: ubuntu-latest
environment: release
if: github.event_name == 'repository_dispatch' || github.event.inputs.publish == 'true'
if: needs.build_maxtext_package.result == 'success' && (github.event_name == 'repository_dispatch' || inputs.publish)
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce
with:
name: maxtext-wheel
path: dist/
- name: Publish MaxText wheel to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
Expand Down Expand Up @@ -156,7 +160,7 @@ jobs:
shell: bash
run: |
SOURCE_IMAGE="gcr.io/${{ vars.PROJECT_NAME }}/${{ matrix.image_name }}"
GITHUB_RUN_ID="${{ github.event.client_payload.github_run_id }}"
GITHUB_RUN_ID="${{ github.event_name == 'workflow_dispatch' && inputs.run_id || github.event.client_payload.github_run_id }}"
gcloud container images add-tag \
"${SOURCE_IMAGE}:${GITHUB_RUN_ID}" \
"${SOURCE_IMAGE}:${{ needs.get_latest_maxtext_pypi_version.outputs.latest_pypi_version }}" \
Expand Down
Loading