Fix error when an interactive param is also connected#2121
Merged
Conversation
When a parameter is interactive and connected, the connection should win. OSL was incorrectly treating the interactive trait as taking precedence, attempting to write into the read-only interactive buffer during shader execution. Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Contributor
|
Looks good, but could you please add the corresponding fix to batched_backenllvm.cpp? |
aconty
approved these changes
May 28, 2026
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Collaborator
Author
Sure thing, done! |
lgritz
approved these changes
May 29, 2026
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
May 29, 2026
…reFoundation#2121) When a parameter is interactive and connected, the connection should win. OSL was incorrectly treating the interactive trait as taking precedence, attempting to write into the read-only interactive buffer during shader execution. Fixed both single point and batch modes. --------- Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a parameter is interactive and connected, the connection should win. OSL was incorrectly treating the interactive trait as taking precedence, attempting to write into the read-only interactive buffer during shader execution.
Assisted-by: Claude Code / claude-sonnet-4-6
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.