Don't impose example-only conan deps (opengl/cimg/spdlog) on consumers - #253
Merged
Conversation
The conan recipe unconditionally required opengl, cimg, and spdlog and attached them to the HostSupport/Support components, but those packages are used only by the example plugins — nothing in the libraries or packaged headers references them. Consumers of the libraries now pull in just expat, matching the trimmed dependency set the ConanCenter recipe already uses. Example builds move behind a new build_examples option (default False) which drives BUILD_EXAMPLE_PLUGINS and the extra requirements; CI passes -o build_examples=True to keep building and testing the examples. The top-level find_package calls for the example deps are likewise gated on BUILD_EXAMPLE_PLUGINS so a library-only CMake build doesn't need them. Refs #238. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Gary Oberbrunner <garyo@darkstarsystems.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #246 / #238. The in-repo conan recipe required
opengl,cimg, andspdlogfor everyone and attached them to theHostSupport/Supportcomponents — but those are used only by the example plugins. Verified: no source file or packaged header outsideExamples/andSupport/Plugins/*.cppreferences them.disable-example-requirementspatch at the next release).build_examplesoption (defaultFalse) gates the extra requirements and drivesBUILD_EXAMPLE_PLUGINSvia the toolchain.find_package(opengl_system/cimg/spdlog)calls are gated onBUILD_EXAMPLE_PLUGINS, so a library-only CMake build no longer needs them.-o build_examples=Trueso all examples still build and run in CI.Tested locally (macOS, apple-clang 21):
conan createboth with and withoutbuild_examples; the default package contains only headers + libs and its consumer graph shows justexpat/2.7.1, while the examples variant builds all.ofxplugins and pulls cimg/spdlog/opengl as before.🤖 Generated with Claude Code