Repository navigation
Flaky test KillingLimit_TerminatesOverCapProcess makes CI on main red (child exits before the kill) - #762
Merged
Conversation
…erministic
Make termination by the output limit the only way the child process ends in
KillingLimit_TerminatesOverCapProcess by using an unbounded producer
('exec yes 0123456789abcdef') and a bounded CancellationToken safety net.
Assert StdoutLimitExceeded, !Success, and that the process terminated with a
non-zero exit code (SIGKILL exit code 137 on Linux).
Add a separate deterministic test
KillingLimit_CleanExitBeforeKill_ReportsSuccessWithLimitExceeded documenting
and asserting that if a process finishes and exits cleanly with code 0 before
the runner's limit-kill takes effect, the runner faithfully reports ExitCode = 0,
Success = true, and StdoutLimitExceeded = true with bounded stdout retention.
CodeyBox-Prompt-Revision: 1
Co-Authored-By: CodeyBox <noreply@codeybox.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated via CodeyBox — work item 5e56b634952d44078b065ffdcf9e0865
Initiated by CodeyBox operator
Co-Authored-By: CodeyBox noreply@codeybox.invalid
🤖 Generated with CodeyBox