fix(cli): allow slow Relayfile provider status - #1487
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe default Relayfile control-plane client now uses a 30-second request timeout. Tests verify delayed provider-status requests and shared-client cleanup. The changelog documents the updated request budget. ChangesRelayfile timeout update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
0727494 to
9058c06
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/cli/commands/integration-relayfile-contract.test.ts`:
- Around line 236-253: The integration relay contract test currently delays only
10,100 ms, so it does not enforce the required 30-second request budget. Update
the test around defaultRelayfileBridge().isConnected to assert the configured
30,000 ms timeout at the default-client boundary, or increase the mock delay and
test timeout enough to distinguish a 30-second budget from shorter values.
- Around line 243-249: Isolate the test around
defaultRelayfileBridge().isConnected('github') from sharedClient by resetting
sharedClient before and after the test, or by using a newly constructed client
with explicit socket configuration. Ensure RelayfileControlPlaneClient resolves
the current RELAYFILE_SOCK value for this test and cannot retain another test’s
deleted temporary socket.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2d3d3958-2cc3-45aa-90c2-cc55d5d21541
📒 Files selected for processing (3)
CHANGELOG.mdpackages/cli/src/cli/commands/integration-relayfile-contract.test.tspackages/cli/src/cli/commands/integration.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/cli/src/cli/commands/integration.ts
- CHANGELOG.md
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Summary
@relayfile/clientdefault of 10 secondsLive reproduction
The branch-built CLI repeatedly failed
integration subscribeat exactly 10 seconds while production Relayfile provider status completed in ~9.7 seconds before client overhead. With this change and AgentWorkforce/relayfile#415, the same local CLI command successfully created both the scoped Relay inbound target and Relayfile webhook subscription.Verification
integration-relayfile-contract.test.ts: 11 passed, 4 skippednpm run typecheck: passedintegration.tsRelated end-to-end path-filter fix: #1486.