Skip to content

Fix path separator for remote_zip in computer_client.py#8182

Open
tjc6666666666666 wants to merge 1 commit into
AstrBotDevs:masterfrom
tjc6666666666666:patch-2
Open

Fix path separator for remote_zip in computer_client.py#8182
tjc6666666666666 wants to merge 1 commit into
AstrBotDevs:masterfrom
tjc6666666666666:patch-2

Conversation

@tjc6666666666666
Copy link
Copy Markdown
Contributor

@tjc6666666666666 tjc6666666666666 commented May 13, 2026

Ensure remote_zip uses forward slashes for compatibility.

Modifications / 改动点

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Fix incorrect path separator when constructing the remote skills.zip path for sandbox uploads.

Ensure remote_zip uses forward slashes for compatibility.
@auto-assign auto-assign Bot requested review from Fridemn and anka-afk May 13, 2026 17:53
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:core The bug / feature is about astrbot's core, backend labels May 13, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • To avoid potential // in the path if SANDBOX_SKILLS_ROOT already ends with a slash, consider normalizing it, e.g., remote_zip = f"{SANDBOX_SKILLS_ROOT.rstrip('/')}/skills.zip".
  • Since this path is intended to be POSIX-style, it may be clearer and more robust to construct it via PurePosixPath (or a small helper) instead of manual string concatenation so that future call sites remain consistent.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- To avoid potential `//` in the path if `SANDBOX_SKILLS_ROOT` already ends with a slash, consider normalizing it, e.g., `remote_zip = f"{SANDBOX_SKILLS_ROOT.rstrip('/')}/skills.zip"`.
- Since this path is intended to be POSIX-style, it may be clearer and more robust to construct it via `PurePosixPath` (or a small helper) instead of manual string concatenation so that future call sites remain consistent.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the path construction for the sandbox skills bundle in computer_client.py to ensure forward slashes are used for compatibility. The reviewer suggests using the more idiomatic Path.as_posix() method instead of manual string concatenation and recommends translating the Chinese comment into English to maintain consistency with the rest of the codebase.

Comment on lines +507 to +508
# 强制使用沙盒支持的正斜杠 /,彻底解决路径分隔符问题
remote_zip = f"{SANDBOX_SKILLS_ROOT}/skills.zip"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The codebase primarily uses English for technical comments. To maintain consistency, it is recommended to use English here. Additionally, using Path.as_posix() is a more idiomatic way to ensure forward slashes in path strings across different platforms, and it more safely handles potential edge cases in the root path (like trailing slashes or mixed separators) compared to manual string concatenation.

Suggested change
# 强制使用沙盒支持的正斜杠 /,彻底解决路径分隔符问题
remote_zip = f"{SANDBOX_SKILLS_ROOT}/skills.zip"
# Force forward slashes for sandbox compatibility.
remote_zip = (Path(SANDBOX_SKILLS_ROOT) / "skills.zip").as_posix()
References
  1. The codebase primarily uses English for technical comments. (link)
  2. Use Path.as_posix() for idiomatic cross-platform path handling. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core The bug / feature is about astrbot's core, backend size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant