Attach button inner-fill combinators to every selector - #1307
Merged
Conversation
Appending > .wp-block-button to a comma-separated wrapper prelude applied
the child combinator only to the last marker. The first selector became
.wp-block-buttons { width: 100% }, expanding the wrapper to the header
and leaving the inner link at 7px.
Split the prelude and append the combinator to each selector.
box-sizing:border-box on the inner control moved the border box of source buttons that already filled their wrapper. The 15-saas solved fixture regressed by 6 pixels on bordered .tier-cta controls. Emit width only.
Contributor
Author
|
The solved-site-promotion gate initially failed here: Cause was #1304's Fixed in d429aa1 by emitting width only. Gate is green. AI assistance: Claude Sonnet 4.5 via OpenCode read the gate evidence, traced the fixture CSS, and made the change. Chris Huber reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1306.
Problem
#1304 appends
> .wp-block-buttonto the wrapper prelude. When that prelude lists desktop and mobile markers, CSS applies the combinator only to the last selector:The first selector is
.wp-block-buttons { width: 100% }. After #1304, Nimbus Contacts wrapper is 1440px and the inner link is still 7×88.Change
Split the prelude and append the combinator to each selector.
Coverage
tests/unit/button-wrapper-fill-selector-list.phpfails on trunk (combinator only on the last marker) and passes here.composer testexits 0.AI assistance
Claude Sonnet 4.5 via OpenCode measured the v8 import after #1304 and implemented the split. Chris Huber reviewed.