Lower percent-width column layout tables to core/columns - #1309
Merged
Conversation
Single-row headerless tables whose class names them as columns and whose cells all declare percentage widths are layout grids, not data tables. Genuine tables without those signals stay core/table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1308
Single-row headerless tables with a column-layout class (
multicol/col/columns) and percentage widths on every cell becomecore/columnswith those percentages..layout-tableand headerless tables without those signals staycore/table.Test
php tests/contract/run.phpAI assistance
Grok 4.6 through OpenCode diagnosed missing column widths on the tasteandtravelitaly import and implemented this fix.