Repository navigation
Upgrade sass - #233
Closed
adamwoodnz wants to merge 2 commits into
Closed
Upgrade sass#233adamwoodnz wants to merge 2 commits into
adamwoodnz wants to merge 2 commits into
Conversation
Looking at package-lock.json it seems most likely this project is on Node 12
adamwoodnz
force-pushed
the
try/upgrade-sass
branch
from
October 21, 2024 22:24
10167bd to
808df8f
Compare
dd32
approved these changes
Oct 22, 2024
dd32
left a comment
dd32
left a comment
Member
There was a problem hiding this comment.
The change to css/style.css seems sane, so I'm making an assumption that this is a safe change to make.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing dependencies for development I ran into the following
Error: Can't find Python executable "python", you can set the PYTHON env variable.Later versions of Sass don't require Python, so this PR updates it and dependencies. The resulting changes to the built CSS consist of quotes and removing empty lines.
I've also added a
.nvmrcfile to aid in environment consistency between developers. Looking at the existing package-lock.json, it seems that it was most likely generated with npm 6, which shipped with Node 12.